games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-02-03 13:01:33 +02:00
Code Issues Releases Activity

CGHeroInstance::setType: fix to give proper subID to random heroes

Browse Source 
Hero class id is used to determine hero object appearance, but after than we use subID to store it's unique id.
This change should fix issues 2127 and 2277 since random heroes not going to override others in heroesPool.
This commit is contained in:
Arseniy Shestakov 2016-09-18 10:01:09 +03:00
parent f6df107a55
commit 635c48f889
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/mapObjects/CGHeroInstance.cpp
View File

@ -255,7 +255,8 @@ void CGHeroInstance::setType(si32 ID, si32 subID)
assert(ID == Obj::HERO); // just in case
type = VLC->heroh->heroes[subID];
portrait = type->imageIndex;
CGObjectInstance::setType(ID, type->heroClass->id);
CGObjectInstance::setType(ID, type->heroClass->id); // to find object handler we must use heroClass->id
this->subID = subID; // after setType subID used to store unique hero identify id. Check issue 2277 for details
randomizeArmy(type->heroClass->faction);
}