games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2026-06-19 22:57:37 +02:00
Code Issues Releases Activity

Add comment on H3 logic bug

Browse Source
This commit is contained in:
Ivan Savenko
2026-01-27 18:23:12 +00:00
parent 8e5f123010
commit 7a90ed79d3
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/bonuses/Updaters.cpp
+3
View File
@@ -98,6 +98,9 @@ std::shared_ptr<Bonus> TimesHeroLevelDivideStackLevelUpdater::createUpdatedBonus
{
if(context.getNodeType() == BonusNodeType::HERO)
{
// FIXME: current logic is (val * hero level) / stack level
// However H3 logic is val * (hero level / stack level)
// Probably needs creation of temporary limiter & passing hero level into it, to perform all math in one place
auto newBonus = TimesHeroLevelUpdater::createUpdatedBonus(b, context);
newBonus->updater = divideStackLevel;
return newBonus;