games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-25 22:42:04 +02:00
Code Issues Releases Activity

Issue2888 (#421)

Browse Source 
Fixed issue 2888
* Merged AFTER_ATTACK & BEFORE_ATTACK cast modes.
* Introduced new caster class for creature ability usage
* Added few tests
This commit is contained in:
Alexander Shishkin
2018-03-02 13:22:51 +03:00
committed by GitHub
parent 386805c4e0
commit 8b002ad774
26 changed files with 450 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/game/CGameStateTest.cpp
View File

@@ -26,6 +26,7 @@
#include "../../lib/spells/CSpellHandler.h"
#include "../../lib/spells/ISpellMechanics.h"
#include "../../lib/spells/AbilityCaster.h"
class CGameStateTest : public ::testing::Test, public SpellCastEnvironment, public MapListener
{
@@ -224,12 +225,14 @@ TEST_F(CGameStateTest, issue2765)
{
const CSpell * age = SpellID(SpellID::AGE).toSpell();
ASSERT_NE(age, nullptr);
//here tested ballista, but this applied to all war machines
spells::BattleCast cast(gameState->curB, att, spells::Mode::AFTER_ATTACK, age);
cast.aimToUnit(def);
cast.setSpellLevel(3);
EXPECT_FALSE(age->canBeCastAt(gameState->curB, spells::Mode::AFTER_ATTACK, att, def->getPosition()));
spells::AbilityCaster caster(att, 3);
//here tested ballista, but this applied to all war machines
spells::BattleCast cast(gameState->curB, &caster, spells::Mode::PASSIVE, age);
cast.aimToUnit(def);
EXPECT_FALSE(age->canBeCastAt(gameState->curB, spells::Mode::PASSIVE, &caster, def->getPosition()));
EXPECT_TRUE(cast.castIfPossible(this));//should be possible, but with no effect (change to aimed cast check?)