games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2024-12-22 22:13:35 +02:00
Code Issues Releases Activity

miniscule bonus system cleanup

Browse Source 
update comments, remove one never used method, make another method private
This commit is contained in:
K 2024-09-18 16:41:41 +02:00
parent 110def5a1e
commit bda1adbdfd
3 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/bonuses/CBonusSystemNode.cpp
View File

@ -625,13 +625,6 @@ void CBonusSystemNode::limitBonuses(const BonusList &allBonuses, BonusList &out)
} }
} }
TBonusListPtr CBonusSystemNode::limitBonuses(const BonusList &allBonuses) const
{
auto ret = std::make_shared<BonusList>();
limitBonuses(allBonuses, *ret);
return ret;
}
void CBonusSystemNode::treeHasChanged() void CBonusSystemNode::treeHasChanged()
{ {
treeChanged++; treeChanged++;

3
lib/bonuses/CBonusSystemNode.h
View File

@ -55,6 +55,7 @@ private:
void getAllBonusesRec(BonusList &out, const CSelector & selector) const; void getAllBonusesRec(BonusList &out, const CSelector & selector) const;
TConstBonusListPtr getAllBonusesWithoutCaching(const CSelector &selector, const CSelector &limit) const; TConstBonusListPtr getAllBonusesWithoutCaching(const CSelector &selector, const CSelector &limit) const;
std::shared_ptr<Bonus> getUpdatedBonus(const std::shared_ptr<Bonus> & b, const TUpdaterPtr & updater) const; std::shared_ptr<Bonus> getUpdatedBonus(const std::shared_ptr<Bonus> & b, const TUpdaterPtr & updater) const;
void limitBonuses(const BonusList &allBonuses, BonusList &out) const; //out will bo populed with bonuses that are not limited here
void getRedParents(TCNodes &out) const; //retrieves list of red parent nodes (nodes bonuses propagate from) void getRedParents(TCNodes &out) const; //retrieves list of red parent nodes (nodes bonuses propagate from)
void getRedAncestors(TCNodes &out) const; void getRedAncestors(TCNodes &out) const;
@ -84,8 +85,6 @@ public:
explicit CBonusSystemNode(ENodeTypes NodeType); explicit CBonusSystemNode(ENodeTypes NodeType);
virtual ~CBonusSystemNode(); virtual ~CBonusSystemNode();
void limitBonuses(const BonusList &allBonuses, BonusList &out) const; //out will bo populed with bonuses that are not limited here
TBonusListPtr limitBonuses(const BonusList &allBonuses) const; //same as above, returns out by val for convenience
TConstBonusListPtr getAllBonuses(const CSelector &selector, const CSelector &limit, const std::string &cachingStr = "") const override; TConstBonusListPtr getAllBonuses(const CSelector &selector, const CSelector &limit, const std::string &cachingStr = "") const override;
void getParents(TCNodes &out) const; //retrieves list of parent nodes (nodes to inherit bonuses from), void getParents(TCNodes &out) const; //retrieves list of parent nodes (nodes to inherit bonuses from),

4
lib/bonuses/IBonusBearer.h
View File

@ -17,9 +17,7 @@ class DLL_LINKAGE IBonusBearer
{ {
public: public:
//new bonusing node interface //new bonusing node interface
// * selector is predicate that tests if HeroBonus matches our criteria // * selector is predicate that tests if Bonus matches our criteria
// * root is node on which call was made (nullptr will be replaced with this)
//interface
IBonusBearer() = default; IBonusBearer() = default;
virtual ~IBonusBearer() = default; virtual ~IBonusBearer() = default;
virtual TConstBonusListPtr getAllBonuses(const CSelector &selector, const CSelector &limit, const std::string &cachingStr = "") const = 0; virtual TConstBonusListPtr getAllBonuses(const CSelector &selector, const CSelector &limit, const std::string &cachingStr = "") const = 0;