1
0
mirror of https://github.com/vcmi/vcmi.git synced 2024-12-26 22:57:00 +02:00
vcmi/mapeditor/validator.cpp
MichalZr6 0be5a1a2ad Code review followup with additional refactor
Changes following review
2024-08-23 10:43:48 +02:00

200 lines
6.1 KiB
C++

/*
* validator.cpp, part of VCMI engine
*
* Authors: listed in file AUTHORS in main folder
*
* License: GNU General Public License v2.0 or later
* Full text of license available in license.txt file, in main folder
*
*/
#include "StdInc.h"
#include "validator.h"
#include "mapcontroller.h"
#include "ui_validator.h"
#include "../lib/mapping/CMap.h"
#include "../lib/mapObjects/MapObjects.h"
#include "../lib/modding/CModHandler.h"
#include "../lib/modding/CModInfo.h"
#include "../lib/spells/CSpellHandler.h"
#include "../lib/CHeroHandler.h"
Validator::Validator(const CMap * map, QWidget *parent) :
QDialog(parent),
ui(new Ui::Validator)
{
ui->setupUi(this);
show();
setAttribute(Qt::WA_DeleteOnClose);
std::array<QString, 2> icons{":/icons/mod-update.png", ":/icons/mod-delete.png"};
for(auto & issue : Validator::validate(map))
{
auto * item = new QListWidgetItem(QIcon(icons[issue.critical ? 1 : 0]), issue.message);
ui->listWidget->addItem(item);
}
}
Validator::~Validator()
{
delete ui;
}
std::set<Validator::Issue> Validator::validate(const CMap * map)
{
std::set<Validator::Issue> issues;
if(!map)
{
issues.insert({ tr("Map is not loaded"), true });
return issues;
}
try
{
//check player settings
int hplayers = 0;
int cplayers = 0;
std::map<PlayerColor, int> amountOfTowns;
std::map<PlayerColor, int> amountOfHeroes;
for(int i = 0; i < map->players.size(); ++i)
{
auto & p = map->players[i];
if (p.canAnyonePlay())
amountOfTowns[PlayerColor(i)] = 0;
if(p.canComputerPlay)
++cplayers;
if(p.canHumanPlay)
++hplayers;
if(p.allowedFactions.empty())
issues.insert({ tr("No factions allowed for player %1").arg(i), true });
}
if(hplayers + cplayers == 0)
issues.insert({ tr("No players allowed to play this map"), true });
if(hplayers + cplayers == 1)
issues.insert({ tr("Map is allowed for one player and cannot be started"), true });
if(!hplayers)
issues.insert({ tr("No human players allowed to play this map"), true });
std::set<const CHero * > allHeroesOnMap; //used to find hero duplicated
//checking all objects in the map
for(auto o : map->objects)
{
//owners for objects
if(o->getOwner() == PlayerColor::UNFLAGGABLE)
{
if(dynamic_cast<CGMine *>(o.get()) ||
dynamic_cast<CGDwelling *>(o.get()) ||
dynamic_cast<CGTownInstance *>(o.get()) ||
dynamic_cast<CGGarrison *>(o.get()) ||
dynamic_cast<CGHeroInstance *>(o.get()))
{
issues.insert({ tr("Armored instance %1 is UNFLAGGABLE but must have NEUTRAL or player owner").arg(o->instanceName.c_str()), true });
}
}
if(o->getOwner() != PlayerColor::NEUTRAL && o->getOwner().getNum() < map->players.size())
{
if(!map->players[o->getOwner().getNum()].canAnyonePlay())
issues.insert({ tr("Object %1 is assigned to non-playable player %2").arg(o->instanceName.c_str(), o->getOwner().toString().c_str()), true });
}
//count towns
if(auto * ins = dynamic_cast<CGTownInstance *>(o.get()))
{
++amountOfTowns[ins->getOwner()];
}
//checking and counting heroes and prisons
if(auto * ins = dynamic_cast<CGHeroInstance *>(o.get()))
{
if(ins->ID == Obj::PRISON)
{
if(ins->getOwner() != PlayerColor::NEUTRAL)
issues.insert({ tr("Prison %1 must be a NEUTRAL").arg(ins->instanceName.c_str()), true });
}
else
{
if(ins->getOwner() == PlayerColor::NEUTRAL)
issues.insert({ tr("Hero %1 must have an owner").arg(ins->instanceName.c_str()), true });
++amountOfHeroes[ins->getOwner()];
}
if(ins->type)
{
if(map->allowedHeroes.count(ins->getHeroType()) == 0)
issues.insert({ tr("Hero %1 is prohibited by map settings").arg(ins->type->getNameTranslated().c_str()), false });
if(!allHeroesOnMap.insert(ins->type).second)
issues.insert({ tr("Hero %1 has duplicate on map").arg(ins->type->getNameTranslated().c_str()), false });
}
else if(ins->ID != Obj::RANDOM_HERO)
issues.insert({ tr("Hero %1 has an empty type and must be removed").arg(ins->instanceName.c_str()), true });
}
//checking for arts
if(auto * ins = dynamic_cast<CGArtifact *>(o.get()))
{
if(ins->ID == Obj::SPELL_SCROLL)
{
if (ins->storedArtifact)
{
if (map->allowedSpells.count(ins->storedArtifact->getScrollSpellID()) == 0)
issues.insert({ tr("Spell scroll %1 is prohibited by map settings").arg(ins->storedArtifact->getScrollSpellID().toEntity(VLC->spells())->getNameTranslated().c_str()), false });
}
else
issues.insert({ tr("Spell scroll % 1 doesn't have instance assigned and must be removed").arg(ins->instanceName.c_str()), true });
}
else
{
if(ins->ID == Obj::ARTIFACT && map->allowedArtifact.count(ins->getArtifact()) == 0)
{
issues.insert({ tr("Artifact % 1 is prohibited by map settings").arg(ins->getObjectName().c_str()), false });
}
}
}
}
//verification of starting towns
for (const auto & [player, counter] : amountOfTowns)
{
if (counter == 0)
{
// FIXME: heroesNames are empty even though heroes are on the map
// if(map->players[playerTCounter.first].heroesNames.empty())
if(amountOfHeroes.count(player) == 0)
issues.insert({ tr("Player %1 has no towns and heroes assigned").arg(player + 1), true });
else
issues.insert({ tr("Player %1 doesn't have any starting town").arg(player + 1), false });
}
}
//verification of map name and description
if(map->name.empty())
issues.insert({ tr("Map name is not specified"), false });
if(map->description.empty())
issues.insert({ tr("Map description is not specified"), false });
//verificationfor mods
for(auto & mod : MapController::modAssessmentMap(*map))
{
if(!map->mods.count(mod.first))
{
issues.insert({ tr("Map contains object from mod \"%1\", but doesn't require it").arg(QString::fromStdString(VLC->modh->getModInfo(mod.first).getVerificationInfo().name)), true });
}
}
}
catch(const std::exception & e)
{
issues.insert({ tr("Exception occurs during validation: %1").arg(e.what()), true });
}
catch(...)
{
issues.insert({ tr("Unknown exception occurs during validation"), true });
}
return issues;
}