git/prek
1
0
Fork 0
mirror of https://github.com/j178/prek.git synced 2026-03-24 01:20:26 +02:00
Code Activity

fix(tests): use version filter in minimum_prek_version snapshots (#1539)

Browse Source 
Replace hardcoded version `0.3.1` with `[VERSION]` placeholder using
insta's filter mechanism. This prevents test failures when the version
is bumped.
This commit is contained in:
Shaan Majid
2026-02-02 20:47:32 -06:00
committed by GitHub
parent 73e14e65d3
commit 8dc7ff2550
1 changed files with 29 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
crates/prek/src/config.rs
View File

@@ -1172,6 +1172,12 @@ mod tests {
use super::*;
use std::io::Write as _;
/// Filter to replace dynamic version in snapshots
const VERSION_FILTER: (&str, &str) = (
r"current version `\d+\.\d+\.\d+(?:-[0-9A-Za-z]+(?:\.[0-9A-Za-z]+)*)?`",
"current version `[CURRENT_VERSION]`",
);
#[test]
fn parse_file_patterns_regex_and_glob() {
#[derive(Debug, Deserialize)]
@@ -1658,15 +1664,17 @@ mod tests {
minimum_prek_version: '10.0.0'
"};
let err = serde_saphyr::from_str::<Config>(yaml).unwrap_err();
insta::assert_snapshot!(err, @"
error: line 8 column 23: Required minimum prek version `10.0.0` is greater than current version `0.3.1`. Please consider updating prek. at line 8, column 23
--> <input>:8:23
|
6 | entry: echo test
7 | language: system
8 | minimum_prek_version: '10.0.0'
| ^ Required minimum prek version `10.0.0` is greater than current version `0.3.1`. Please consider updating prek. at line 8, column 23
");
insta::with_settings!({ filters => vec![VERSION_FILTER] }, {
insta::assert_snapshot!(err, @"
error: line 8 column 23: Required minimum prek version `10.0.0` is greater than current version `[CURRENT_VERSION]`. Please consider updating prek. at line 8, column 23
--> <input>:8:23
|
6 | entry: echo test
7 | language: system
8 | minimum_prek_version: '10.0.0'
| ^ Required minimum prek version `10.0.0` is greater than current version `[CURRENT_VERSION]`. Please consider updating prek. at line 8, column 23
");
});
// Test that valid minimum_prek_version field works in hook config
let yaml = indoc::indoc! {r"
@@ -1677,16 +1685,18 @@ mod tests {
minimum_prek_version: '10.0.0'
"};
let err = serde_saphyr::from_str::<Manifest>(yaml).unwrap_err();
insta::assert_snapshot!(err, @"
error: line 1 column 3: Required minimum prek version `10.0.0` is greater than current version `0.3.1`. Please consider updating prek. at line 1, column 3
--> <input>:1:3
|
1 | - id: test-hook
| ^ Required minimum prek version `10.0.0` is greater than current version `0.3.1`. Please consider updating prek. at line 1, column 3
2 | name: Test Hook
3 | entry: echo test
|
");
insta::with_settings!({ filters => vec![VERSION_FILTER] }, {
insta::assert_snapshot!(err, @"
error: line 1 column 3: Required minimum prek version `10.0.0` is greater than current version `[CURRENT_VERSION]`. Please consider updating prek. at line 1, column 3
--> <input>:1:3
|
1 | - id: test-hook
| ^ Required minimum prek version `10.0.0` is greater than current version `[CURRENT_VERSION]`. Please consider updating prek. at line 1, column 3
2 | name: Test Hook
3 | entry: echo test
|
");
});
}
#[test]