[FIX] Cleanup code (#1061)

Code cleanup

middleware/body_dump_test.go

@@ -1,6 +1,7 @@
 package middleware
 
 import (
+	"errors"
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
@@ -31,10 +32,65 @@ func TestBodyDump(t *testing.T) {
 		requestBody = string(reqBody)
 		responseBody = string(resBody)
 	})
+
 	if assert.NoError(t, mw(h)(c)) {
 		assert.Equal(t, requestBody, hw)
 		assert.Equal(t, responseBody, hw)
 		assert.Equal(t, http.StatusOK, rec.Code)
 		assert.Equal(t, hw, rec.Body.String())
 	}
+
+	// Must set default skipper
+	BodyDumpWithConfig(BodyDumpConfig{
+		Skipper: nil,
+		Handler: func(c echo.Context, reqBody, resBody []byte) {
+			requestBody = string(reqBody)
+			responseBody = string(resBody)
+		},
+	})
+}
+
+func TestBodyDumpFails(t *testing.T) {
+	e := echo.New()
+	hw := "Hello, World!"
+	req := httptest.NewRequest(echo.POST, "/", strings.NewReader(hw))
+	rec := httptest.NewRecorder()
+	c := e.NewContext(req, rec)
+	h := func(c echo.Context) error {
+		return errors.New("some error")
+	}
+
+	requestBody := ""
+	responseBody := ""
+	mw := BodyDump(func(c echo.Context, reqBody, resBody []byte) {
+		requestBody = string(reqBody)
+		responseBody = string(resBody)
+	})
+
+	if !assert.Error(t, mw(h)(c)) {
+		t.FailNow()
+	}
+
+	assert.Panics(t, func() {
+		mw = BodyDumpWithConfig(BodyDumpConfig{
+			Skipper: nil,
+			Handler: nil,
+		})
+	})
+
+	assert.NotPanics(t, func() {
+		mw = BodyDumpWithConfig(BodyDumpConfig{
+			Skipper: func(c echo.Context) bool {
+				return true
+			},
+			Handler: func(c echo.Context, reqBody, resBody []byte) {
+				requestBody = string(reqBody)
+				responseBody = string(resBody)
+			},
+		})
+
+		if !assert.Error(t, mw(h)(c)) {
+			t.FailNow()
+		}
+	})
 }