1
0
mirror of https://github.com/interviewstreet/go-jira.git synced 2024-11-30 08:47:11 +02:00

Initial commit of bug fixes found by atom's gometalinter.

This commit is contained in:
Garrett Graupmann 2017-02-23 16:48:06 -08:00
parent 3a142b6278
commit 39a47d13a0
3 changed files with 6 additions and 6 deletions

View File

@ -76,7 +76,7 @@ func TestAuthenticationService_AcquireSessionCookie_Success(t *testing.T) {
}
if testClient.Authentication.authType != authTypeSession {
t.Error("Expected authType %d. Got %d", authTypeSession, testClient.Authentication.authType)
t.Errorf("Expected authType %d. Got %d", authTypeSession, testClient.Authentication.authType)
}
}
@ -87,15 +87,15 @@ func TestAuthenticationService_SetBasicAuth(t *testing.T) {
testClient.Authentication.SetBasicAuth("test-user", "test-password")
if testClient.Authentication.username != "test-user" {
t.Error("Expected username test-user. Got %s", testClient.Authentication.username)
t.Errorf("Expected username test-user. Got %s", testClient.Authentication.username)
}
if testClient.Authentication.password != "test-password" {
t.Error("Expected password test-password. Got %s", testClient.Authentication.password)
t.Errorf("Expected password test-password. Got %s", testClient.Authentication.password)
}
if testClient.Authentication.authType != authTypeBasic {
t.Error("Expected authType %d. Got %d", authTypeBasic, testClient.Authentication.authType)
t.Errorf("Expected authType %d. Got %d", authTypeBasic, testClient.Authentication.authType)
}
}

View File

@ -435,7 +435,7 @@ type SearchOptions struct {
// MaxResults: The maximum number of projects to return per page. Default: 50.
MaxResults int `url:"maxResults,omitempty"`
// Expand: Expand specific sections in the returned issues
Expand string `url:expand,omitempty"`
Expand string `url:"expand,omitempty"`
}
// searchResult is only a small wrapper around the Search (with JQL) method

View File

@ -37,7 +37,7 @@ type MetaIssueType struct {
IconUrl string `json:"iconurl,omitempty"`
Name string `json:"name,omitempty"`
Subtasks bool `json:"subtask,omitempty"`
Expand string `json:"expand,omitempty"`
Expand string `json:",omitempty"`
Fields tcontainer.MarshalMap `json:"fields,omitempty"`
}