go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-25 21:29:14 +02:00
Code Issues Releases Activity

fix: use constants for http methods instead of strings (#994)

Browse Source
This commit is contained in:
Grachev Mikhail 2019-03-31 20:11:13 +03:00 committed by Carlos Alexandro Becker
parent 7230b1cd31
commit 7de278535a
3 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/http/http.go
View File

@ -244,7 +244,7 @@ func uploadAssetToServer(ctx *context.Context, put *config.Put, target, username
// newUploadRequest creates a new h.Request for uploading
func newUploadRequest(target, username, secret string, headers map[string]string, a *asset) (*h.Request, error) {
req, err := h.NewRequest("PUT", target, a.ReadCloser)
req, err := h.NewRequest(h.MethodPut, target, a.ReadCloser)
if err != nil {
return nil, err
}

18
internal/pipe/artifactory/artifactory_test.go
View File

@ -67,7 +67,7 @@ func TestRunPipe_ModeBinary(t *testing.T) {
// Dummy artifactories
mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -93,7 +93,7 @@ func TestRunPipe_ModeBinary(t *testing.T) {
}`)
})
mux.HandleFunc("/example-repo-local/mybin/linux/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -119,7 +119,7 @@ func TestRunPipe_ModeBinary(t *testing.T) {
}`)
})
mux.HandleFunc("/production-repo-remote/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "productionuser" with secret "productionuser-apikey"
testHeader(t, r, "Authorization", "Basic cHJvZHVjdGlvbnVzZXI6cHJvZHVjdGlvbnVzZXItYXBpa2V5")
@ -145,7 +145,7 @@ func TestRunPipe_ModeBinary(t *testing.T) {
}`)
})
mux.HandleFunc("/production-repo-remote/mybin/linux/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "productionuser" with secret "productionuser-apikey"
testHeader(t, r, "Authorization", "Basic cHJvZHVjdGlvbnVzZXI6cHJvZHVjdGlvbnVzZXItYXBpa2V5")
@ -248,7 +248,7 @@ func TestRunPipe_ModeArchive(t *testing.T) {
// Dummy artifactories
mux.HandleFunc("/example-repo-local/goreleaser/1.0.0/bin.tar.gz", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -274,7 +274,7 @@ func TestRunPipe_ModeArchive(t *testing.T) {
uploads.Store("targz", true)
})
mux.HandleFunc("/example-repo-local/goreleaser/1.0.0/bin.deb", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -388,7 +388,7 @@ func TestRunPipe_BadCredentials(t *testing.T) {
// Dummy artifactories
mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -446,7 +446,7 @@ func TestRunPipe_UnparsableErrorResponse(t *testing.T) {
// Dummy artifactories
mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -501,7 +501,7 @@ func TestRunPipe_UnparsableResponse(t *testing.T) {
// Dummy artifactory with invalid JSON
mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")

14
internal/pipe/put/put_test.go
View File

@ -67,7 +67,7 @@ func TestRunPipe_ModeBinary(t *testing.T) {
// Dummy http server
mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -76,7 +76,7 @@ func TestRunPipe_ModeBinary(t *testing.T) {
w.WriteHeader(http.StatusCreated)
})
mux.HandleFunc("/example-repo-local/mybin/linux/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -85,7 +85,7 @@ func TestRunPipe_ModeBinary(t *testing.T) {
w.WriteHeader(http.StatusCreated)
})
mux.HandleFunc("/production-repo-remote/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "productionuser" with secret "productionuser-apikey"
testHeader(t, r, "Authorization", "Basic cHJvZHVjdGlvbnVzZXI6cHJvZHVjdGlvbnVzZXItYXBpa2V5")
@ -94,7 +94,7 @@ func TestRunPipe_ModeBinary(t *testing.T) {
w.WriteHeader(http.StatusCreated)
})
mux.HandleFunc("/production-repo-remote/mybin/linux/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "productionuser" with secret "productionuser-apikey"
testHeader(t, r, "Authorization", "Basic cHJvZHVjdGlvbnVzZXI6cHJvZHVjdGlvbnVzZXItYXBpa2V5")
@ -180,7 +180,7 @@ func TestRunPipe_ModeArchive(t *testing.T) {
// Dummy http server
mux.HandleFunc("/example-repo-local/goreleaser/1.0.0/bin.tar.gz", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -189,7 +189,7 @@ func TestRunPipe_ModeArchive(t *testing.T) {
uploads.Store("targz", true)
})
mux.HandleFunc("/example-repo-local/goreleaser/1.0.0/bin.deb", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")
@ -287,7 +287,7 @@ func TestRunPipe_BadCredentials(t *testing.T) {
// Dummy http server
mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "PUT")
testMethod(t, r, http.MethodPut)
testHeader(t, r, "Content-Length", "9")
// Basic auth of user "deployuser" with secret "deployuser-secret"
testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")