go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-17 20:47:50 +02:00
Code Issues Releases Activity

snapcraft pipe test coverage increased

Browse Source
This commit is contained in:
Carlos Alexandro Becker 2017-08-03 22:29:02 -03:00
parent 41dba4581f
commit a705c7bc7d
No known key found for this signature in database
GPG Key ID: E61E2F7DC14AB940
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pipeline/snapcraft/snapcraft.go
View File

@ -52,7 +52,7 @@ func (Pipe) Run(ctx *context.Context) error {
log.Error("no snapcraft summary defined, skipping") log.Error("no snapcraft summary defined, skipping")
return nil return nil
} }
if ctx.Config.Snapcraft.Summary == "" { if ctx.Config.Snapcraft.Description == "" {
log.Error("no snapcraft description defined, skipping") log.Error("no snapcraft description defined, skipping")
return nil return nil
} }

4
pipeline/snapcraft/snapcraft_test.go
View File

@ -31,6 +31,8 @@ func TestRunPipeMissingInfo(t *testing.T) {
Snapcraft: snap, Snapcraft: snap,
}, },
} }
// FIXME: there is no way to tell here if the pipe actually ran
// or if it was indeed skipped.
assert.NoError(Pipe{}.Run(ctx)) assert.NoError(Pipe{}.Run(ctx))
}) })
} }
@ -54,7 +56,7 @@ func TestRunPipe(t *testing.T) {
}, },
}, },
} }
for _, plat := range []string{"linuxamd64", "linux386", "darwinamd64"} { for _, plat := range []string{"linuxamd64", "linux386", "darwinamd64", "linuxarm64", "linuxarmhf"} {
var folder = "mybin_" + plat var folder = "mybin_" + plat
assert.NoError(os.Mkdir(filepath.Join(dist, folder), 0755)) assert.NoError(os.Mkdir(filepath.Join(dist, folder), 0755))
var binPath = filepath.Join(dist, folder, "mybin") var binPath = filepath.Join(dist, folder, "mybin")