go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-10-30 23:58:09 +02:00
Code Issues Releases Activity

chore: fix all existing lint issues (#4637)

Browse Source 
The PR fixes lint issues, pins `golangci-lint` to `v1.56.2`, disables
`only-new-issues`, and enables `fail-on-issues` in the lint workflow.
After this, all new lint issues will fail CI.

The full log of fixed lint issues:
```sh
❯ golangci-lint run
cmd/docs.go:24:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
                RunE: func(cmd *cobra.Command, args []string) error {
                           ^
cmd/man.go:26:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
                RunE: func(cmd *cobra.Command, args []string) error {
                           ^
cmd/healthcheck.go:36:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
                RunE: func(cmd *cobra.Command, args []string) error {
                           ^
cmd/build.go:72:33: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
                RunE: timedRunE("build", func(cmd *cobra.Command, args []string) error {
                                              ^
cmd/schema.go:29:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
                RunE: func(cmd *cobra.Command, args []string) error {
                           ^
internal/pipe/nix/nix_test.go:547:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint)
                                require.ErrorAs(t, err, &tt.expectDefaultErrorIs)
                                ^
internal/pipe/nix/nix_test.go:556:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint)
                                require.ErrorAs(t, err, &tt.expectRunErrorIs)
                                ^
internal/pipe/nix/nix_test.go:567:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint)
                                require.ErrorAs(t, err, &tt.expectPublishErrorIs)
                                ^
internal/pipe/winget/winget_test.go:709:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint)
                                require.ErrorAs(t, err, &tt.expectPublishErrorIs)
                                ^
internal/pipe/winget/winget_test.go:728:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint)
                                require.ErrorAs(t, err, &tt.expectPublishErrorIs)
                                ^
internal/pipe/docker/docker_test.go:56:29: unused-parameter: parameter 'use' seems to be unused, consider removing or renaming it as _ (revive)
                return func(t *testing.T, use string) {
                                          ^
internal/gio/safe_test.go:23:4: go-require: require must only be used in the goroutine running the test function (testifylint)
                        require.Equal(t, 1, s)
                        ^
internal/gio/safe_test.go:24:4: go-require: require must only be used in the goroutine running the test function (testifylint)
                        require.NoError(t, err)
                        ^
internal/pipe/gomod/gomod_proxy_test.go:126:3: useless-assert: asserting of the same variable (testifylint)
                require.Equal(t, ctx.ModulePath, ctx.ModulePath)
                ^
internal/pipe/gomod/gomod_proxy_test.go:152:3: useless-assert: asserting of the same variable (testifylint)
                require.Equal(t, ctx.ModulePath, ctx.ModulePath)
                ^
internal/pipe/gomod/gomod_proxy_test.go:178:3: useless-assert: asserting of the same variable (testifylint)
                require.Equal(t, ctx.ModulePath, ctx.ModulePath)
                ^
internal/pipe/gomod/gomod_proxy_test.go:239:3: useless-assert: asserting of the same variable (testifylint)
                require.Equal(t, ctx.ModulePath, ctx.ModulePath)
                ^
internal/artifact/artifact_test.go:638:46: unused-parameter: parameter 'a' seems to be unused, consider removing or renaming it as _ (revive)
                require.EqualError(t, artifacts.Visit(func(a *Artifact) error {
                                                           ^
internal/pipe/milestone/milestone.go:79: File is not `gofumpt`-ed (gofumpt)

internal/http/http_test.go:217:19: unused-parameter: parameter 'k' seems to be unused, consider removing or renaming it as _ (revive)
        assetOpen = func(k string, a *artifact.Artifact) (*asset, error) {
                         ^
internal/middleware/logging/logging_test.go:12:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
        require.NoError(t, Log("foo", func(ctx *context.Context) error {
                                           ^
internal/middleware/logging/logging_test.go:16:40: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
        require.NoError(t, PadLog("foo", func(ctx *context.Context) error {
                                              ^
internal/pipe/chocolatey/chocolatey_test.go:277:15: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive)
                        exec: func(cmd string, args ...string) ([]byte, error) {
                                   ^
internal/client/gitlab.go:325: File is not `gofumpt`-ed (gofumpt)

internal/pipe/linkedin/client_test.go:58:77: unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive)
        server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
                                                                                   ^
internal/middleware/errhandler/error_test.go:15:34: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
                require.NoError(t, Handle(func(ctx *context.Context) error {
                                               ^
internal/middleware/errhandler/error_test.go:21:34: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
                require.NoError(t, Handle(func(ctx *context.Context) error {
                                               ^
internal/middleware/errhandler/error_test.go:27:32: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
                require.Error(t, Handle(func(ctx *context.Context) error {
                                             ^
internal/middleware/errhandler/error_test.go:36:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
                require.NoError(t, memo.Wrap(func(ctx *context.Context) error {
                                                  ^
internal/middleware/errhandler/error_test.go:42:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
                require.NoError(t, memo.Wrap(func(ctx *context.Context) error {
                                                  ^
internal/middleware/errhandler/error_test.go:48:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
                require.NoError(t, memo.Wrap(func(ctx *context.Context) error {
                                                  ^
internal/pipe/ko/ko.go:175:29: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
                build.WithBaseImages(func(ctx stdctx.Context, s string) (name.Reference, build.Result, error) {
                                          ^
```
This commit is contained in:
Oleksandr Redko
2024-02-19 13:49:39 +02:00
committed by GitHub
parent fd24a00e47
commit a9c76d7655
19 changed files with 27 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/lint.yml vendored
View File

@@ -26,4 +26,4 @@ jobs:
uses: golangci/golangci-lint-action@3cfe3a4abbb849e10058ce4af15d205b6da42804 # v3
with:
args: --timeout=5m
only-new-issues: true
version: v1.56.2

4
.golangci.yaml
View File

@@ -39,3 +39,7 @@ linters-settings:
gocritic:
enabled-checks:
- exitAfterDefer
testifylint:
enable-all: true
disable:
- error-is-as # false positive

2
cmd/build.go
View File

@@ -69,7 +69,7 @@ When using ` + "`--single-target`" + `, the ` + "`GOOS`" + ` and ` + "`GOARCH`"
SilenceErrors: true,
Args: cobra.NoArgs,
ValidArgsFunction: cobra.NoFileCompletions,
RunE: timedRunE("build", func(cmd *cobra.Command, args []string) error {
RunE: timedRunE("build", func(_ *cobra.Command, _ []string) error {
ctx, err := buildProject(root.opts)
if err != nil {
return err

2
cmd/docs.go
View File

@@ -21,7 +21,7 @@ func newDocsCmd() *docsCmd {
Hidden: true,
Args: cobra.NoArgs,
ValidArgsFunction: cobra.NoFileCompletions,
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(_ *cobra.Command, _ []string) error {
root.cmd.Root().DisableAutoGenTag = true
return doc.GenMarkdownTreeCustom(root.cmd.Root(), "www/docs/cmd", func(_ string) string {
return ""

2
cmd/healthcheck.go
View File

@@ -33,7 +33,7 @@ func newHealthcheckCmd() *healthcheckCmd {
SilenceErrors: true,
Args: cobra.NoArgs,
ValidArgsFunction: cobra.NoFileCompletions,
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(_ *cobra.Command, _ []string) error {
if root.quiet {
log.Log = log.New(io.Discard)
}

2
cmd/man.go
View File

@@ -23,7 +23,7 @@ func newManCmd() *manCmd {
Hidden: true,
Args: cobra.NoArgs,
ValidArgsFunction: cobra.NoFileCompletions,
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(_ *cobra.Command, _ []string) error {
manPage, err := mcoral.NewManPage(1, root.cmd.Root())
if err != nil {
return err

2
cmd/schema.go
View File

@@ -26,7 +26,7 @@ func newSchemaCmd() *schemaCmd {
SilenceErrors: true,
Args: cobra.NoArgs,
ValidArgsFunction: cobra.NoFileCompletions,
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(_ *cobra.Command, _ []string) error {
schema := jsonschema.Reflect(&config.Project{})
schema.Definitions["FileInfo"] = jsonschema.Reflect(&config.FileInfo{})
schema.Description = "goreleaser configuration definition file"

2
internal/artifact/artifact_test.go
View File

@@ -635,7 +635,7 @@ func TestVisit(t *testing.T) {
})
t.Run("nok", func(t *testing.T) {
require.EqualError(t, artifacts.Visit(func(a *Artifact) error {
require.EqualError(t, artifacts.Visit(func(_ *Artifact) error {
return fmt.Errorf("fake err")
}), `fake err`)
})

1
internal/client/gitlab.go
View File

@@ -322,7 +322,6 @@ func (c *gitlabClient) CreateRelease(ctx *context.Context, body string) (release
Ref: &ref,
TagName: &tagName,
})
if err != nil {
log.WithError(err).Debug("error creating release")
return "", err

5
internal/gio/safe_test.go
View File

@@ -6,6 +6,7 @@ import (
"sync"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
@@ -20,8 +21,8 @@ func TestSafe(t *testing.T) {
for i := 0; i < chars; i++ {
go func() {
s, err := io.WriteString(w, "a")
require.Equal(t, 1, s)
require.NoError(t, err)
assert.Equal(t, 1, s)
assert.NoError(t, err)
wg.Done()
}()
}

2
internal/http/http_test.go
View File

@@ -214,7 +214,7 @@ func TestUpload(t *testing.T) {
w.WriteHeader(h.StatusCreated)
w.Header().Set("Location", r.URL.RequestURI())
}))
assetOpen = func(k string, a *artifact.Artifact) (*asset, error) {
assetOpen = func(_ string, _ *artifact.Artifact) (*asset, error) {
return &asset{
ReadCloser: io.NopCloser(bytes.NewReader(content)),
Size: int64(len(content)),

12
internal/middleware/errhandler/error_test.go
View File

@@ -12,19 +12,19 @@ import (
func TestError(t *testing.T) {
t.Run("no errors", func(t *testing.T) {
require.NoError(t, Handle(func(ctx *context.Context) error {
require.NoError(t, Handle(func(_ *context.Context) error {
return nil
})(nil))
})
t.Run("pipe skipped", func(t *testing.T) {
require.NoError(t, Handle(func(ctx *context.Context) error {
require.NoError(t, Handle(func(_ *context.Context) error {
return pipe.ErrSkipValidateEnabled
})(nil))
})
t.Run("some err", func(t *testing.T) {
require.Error(t, Handle(func(ctx *context.Context) error {
require.Error(t, Handle(func(_ *context.Context) error {
return fmt.Errorf("pipe errored")
})(nil))
})
@@ -33,19 +33,19 @@ func TestError(t *testing.T) {
func TestErrorMemo(t *testing.T) {
memo := Memo{}
t.Run("no errors", func(t *testing.T) {
require.NoError(t, memo.Wrap(func(ctx *context.Context) error {
require.NoError(t, memo.Wrap(func(_ *context.Context) error {
return nil
})(nil))
})
t.Run("pipe skipped", func(t *testing.T) {
require.NoError(t, memo.Wrap(func(ctx *context.Context) error {
require.NoError(t, memo.Wrap(func(_ *context.Context) error {
return pipe.ErrSkipValidateEnabled
})(nil))
})
t.Run("some err", func(t *testing.T) {
require.NoError(t, memo.Wrap(func(ctx *context.Context) error {
require.NoError(t, memo.Wrap(func(_ *context.Context) error {
return fmt.Errorf("pipe errored")
})(nil))
})

4
internal/middleware/logging/logging_test.go
View File

@@ -9,11 +9,11 @@ import (
)
func TestLogging(t *testing.T) {
require.NoError(t, Log("foo", func(ctx *context.Context) error {
require.NoError(t, Log("foo", func(_ *context.Context) error {
return nil
})(nil))
require.NoError(t, PadLog("foo", func(ctx *context.Context) error {
require.NoError(t, PadLog("foo", func(_ *context.Context) error {
log.Info("a")
return nil
})(nil))

2
internal/pipe/chocolatey/chocolatey_test.go
View File

@@ -274,7 +274,7 @@ func TestPublish(t *testing.T) {
},
},
},
exec: func(cmd string, args ...string) ([]byte, error) {
exec: func(_ string, _ ...string) ([]byte, error) {
return nil, errors.New(`unable to push`)
},
err: "failed to push chocolatey package: unable to push: ",

2
internal/pipe/docker/docker_test.go
View File

@@ -53,7 +53,7 @@ func TestRunPipe(t *testing.T) {
}
type imageLabelFinder func(*testing.T, string)
shouldFindImagesWithLabels := func(image string, filters ...string) func(*testing.T, string) {
return func(t *testing.T, use string) {
return func(t *testing.T, _ string) {
t.Helper()
for _, filter := range filters {
cmd := exec.Command("docker", "images", "-q", "--filter", "reference=*/"+image, "--filter", filter)

5
internal/pipe/gomod/gomod_proxy_test.go
View File

@@ -122,8 +122,6 @@ func TestGoModProxy(t *testing.T) {
require.Equal(t, ".", ctx.Config.Builds[0].UnproxiedMain)
require.Equal(t, filepath.Join(dist, "proxy", "foo"), ctx.Config.Builds[0].Dir)
require.Equal(t, ".", ctx.Config.Builds[0].UnproxiedDir)
require.Equal(t, ctx.ModulePath, ctx.ModulePath)
})
t.Run("nfpm", func(t *testing.T) {
@@ -149,7 +147,6 @@ func TestGoModProxy(t *testing.T) {
requireGoMod(t)
require.Equal(t, ctx.ModulePath+"/cmd/nfpm", ctx.Config.Builds[0].Main)
require.Equal(t, filepath.Join(dist, "proxy", "foo"), ctx.Config.Builds[0].Dir)
require.Equal(t, ctx.ModulePath, ctx.ModulePath)
})
// this repo does not have a go.sum file, which is ok, a project might not have any dependencies
@@ -175,7 +172,6 @@ func TestGoModProxy(t *testing.T) {
requireGoMod(t)
require.Equal(t, ctx.ModulePath, ctx.Config.Builds[0].Main)
require.Equal(t, filepath.Join(dist, "proxy", "foo"), ctx.Config.Builds[0].Dir)
require.Equal(t, ctx.ModulePath, ctx.ModulePath)
})
t.Run("no perms", func(t *testing.T) {
@@ -236,7 +232,6 @@ func TestGoModProxy(t *testing.T) {
requireGoMod(t)
require.Equal(t, ctx.ModulePath, ctx.Config.Builds[0].Main)
require.Equal(t, filepath.Join(dist, "proxy", "foo"), ctx.Config.Builds[0].Dir)
require.Equal(t, ctx.ModulePath, ctx.ModulePath)
})
}

2
internal/pipe/ko/ko.go
View File

@@ -172,7 +172,7 @@ func (o *buildOptions) makeBuilder(ctx *context.Context) (*build.Caching, error)
},
}),
build.WithPlatforms(o.platforms...),
build.WithBaseImages(func(ctx stdctx.Context, s string) (name.Reference, build.Result, error) {
build.WithBaseImages(func(_ stdctx.Context, _ string) (name.Reference, build.Result, error) {
ref, err := name.ParseReference(o.baseImage)
if err != nil {
return nil, nil, err

2
internal/pipe/linkedin/client_test.go
View File

@@ -55,7 +55,7 @@ func TestCreateLinkedInClient(t *testing.T) {
}
func TestClient_Share(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, _ *http.Request) {
_, _ = io.WriteString(rw, `
{
"sub": "foo",

1
internal/pipe/milestone/milestone.go
View File

@@ -76,7 +76,6 @@ func doPublish(ctx *context.Context, vcsClient client.Client) error {
Info("closing milestone")
err = vcsClient.CloseMilestone(ctx, repo, name)
if err != nil {
if milestone.FailOnError {
return err