1
0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-17 20:47:50 +02:00

feat: skip_push on docker to match draft releases

This commit is contained in:
Carlos Alexandro Becker 2018-03-24 18:41:24 -03:00 committed by Carlos Alexandro Becker
parent 79a48eae7b
commit b5818a7225
3 changed files with 33 additions and 0 deletions

View File

@ -183,6 +183,7 @@ type Docker struct {
Image string `yaml:",omitempty"`
Dockerfile string `yaml:",omitempty"`
Latest bool `yaml:",omitempty"`
SkipPush bool `yaml:"skip_push,omitempty"`
OldTagTemplate string `yaml:"tag_template,omitempty"`
TagTemplates []string `yaml:"tag_templates,omitempty"`
Files []string `yaml:"extra_files,omitempty"`

View File

@ -200,6 +200,11 @@ func publish(ctx *context.Context, docker config.Docker, images []string) error
log.Warn(pipeline.ErrSkipPublishEnabled.Error())
return nil
}
if docker.SkipPush {
// TODO: this should also be better handled
log.Warn(pipeline.Skip("skip_push is set").Error())
return nil
}
for _, image := range images {
if err := dockerPush(ctx, docker, image); err != nil {
return err

View File

@ -92,6 +92,33 @@ func TestRunPipe(t *testing.T) {
},
assertError: shouldNotErr,
},
"valid_skip_push": {
publish: true,
docker: config.Docker{
Image: registry + "goreleaser/test_run_pipe",
Goos: "linux",
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
SkipPush: true,
TagTemplates: []string{
"{{.Tag}}-{{.Env.FOO}}",
"v{{.Major}}",
"v{{.Major}}.{{.Minor}}",
"latest",
},
Files: []string{
"testdata/extra_file.txt",
},
},
expect: []string{
registry + "goreleaser/test_run_pipe:v1.0.0-123",
registry + "goreleaser/test_run_pipe:v1",
registry + "goreleaser/test_run_pipe:v1.0",
registry + "goreleaser/test_run_pipe:latest",
},
assertError: shouldNotErr,
},
"valid_no_latest": {
publish: true,
docker: config.Docker{