mirror of
https://github.com/goreleaser/goreleaser.git
synced 2025-03-17 20:47:50 +02:00
fix: skip releasing to brew when skipping publishing (#2193)
This fixes an issues that causes builds to still try to release to brew even though the `--skip-publish` flag was passed
This commit is contained in:
parent
a86a9956de
commit
c85472a20f
@ -48,6 +48,9 @@ func (Pipe) String() string {
|
||||
|
||||
// Publish brew formula.
|
||||
func (Pipe) Publish(ctx *context.Context) error {
|
||||
if ctx.SkipPublish {
|
||||
return pipe.ErrSkipPublishEnabled
|
||||
}
|
||||
// we keep GitHub as default for now, in line with releases
|
||||
if string(ctx.TokenType) == "" {
|
||||
ctx.TokenType = context.TokenTypeGitHub
|
||||
|
@ -10,6 +10,7 @@ import (
|
||||
|
||||
"github.com/goreleaser/goreleaser/internal/artifact"
|
||||
"github.com/goreleaser/goreleaser/internal/client"
|
||||
"github.com/goreleaser/goreleaser/internal/pipe"
|
||||
"github.com/goreleaser/goreleaser/internal/testlib"
|
||||
"github.com/goreleaser/goreleaser/pkg/config"
|
||||
"github.com/goreleaser/goreleaser/pkg/context"
|
||||
@ -853,6 +854,16 @@ func TestRunTokenTypeNotImplementedForBrew(t *testing.T) {
|
||||
require.Equal(t, ErrTokenTypeNotImplementedForBrew{TokenType: "gitea"}, doRun(ctx, ctx.Config.Brews[0], client))
|
||||
}
|
||||
|
||||
func TestRunPipe_SkipWhenPublishFalse(t *testing.T) {
|
||||
ctx := context.New(config.Project{})
|
||||
ctx.SkipPublish = true
|
||||
|
||||
require.NoError(t, Pipe{}.Default(ctx))
|
||||
err := Pipe{}.Publish(ctx)
|
||||
require.True(t, pipe.IsSkip(err))
|
||||
require.EqualError(t, err, pipe.ErrSkipPublishEnabled.Error())
|
||||
}
|
||||
|
||||
func TestDefault(t *testing.T) {
|
||||
testlib.Mktmp(t)
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user