this bug comes and goes every couple of versions it seems.
this will change the snapcraft implementation to run the first item
without concurrency, so all needed shared directories can be created
without issues, and then grows the limit of the wait group so the other
ones can run in parallel.
I haven't tested this yet, but I think it'll work.
- [x] test
- [x] godoc
refs https://github.com/goreleaser/goreleaser/issues/1715 refs
https://bugs.launchpad.net/snapcraft/+bug/1889741
<!--
Hi, thanks for contributing!
Please make sure you read our CONTRIBUTING guide.
Also, add tests and the respective documentation changes as well.
-->
<!-- If applied, this commit will... -->
...
<!-- Why is this change being made? -->
...
<!-- # Provide links to any relevant tickets, URLs or other resources
-->
...
---------
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
The PR cleans up unnecessary loop variable copying and enables the
[`copyloopvar`](https://golangci-lint.run/usage/linters/#copyloopvar)
linter for detecting this redundant variable copying.
#### Additional notes
After the project upgraded to Go version 1.22 in #4779, copying
variables inside a `for` loop became unnecessary. See this [blog
post](https://go.dev/blog/loopvar-preview) for a detailed explanation.
The `copyloopvar` linter is only available from `golangci-lint` v1.57
onwards, so we also need to update this tool.
log all skip reasons instead of only one, using a multierror.Error to
merge them all.
refs https://github.com/orgs/goreleaser/discussions/4469
---------
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
<!--
Hi, thanks for contributing!
Please make sure you read our CONTRIBUTING guide.
Also, add tests and the respective documentation changes as well.
-->
<!-- If applied, this commit will... -->
...
<!-- Why is this change being made? -->
...
<!-- # Provide links to any relevant tickets, URLs or other resources -->
...
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
* feat: update x/sync
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
* test: fixes
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
* fix: revert
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
* test: fix race condition
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
* chore(deps): bump github.com/golangci/golangci-lint from 1.23.7 to 1.27.0
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: tests
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: skip aware semerrgroup
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: skip aware semerrgroup
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* Honor order of functions in semerrgroup
* Separate implementation for parallel vs. serial
* Remove lock around serialGroup
* Short circuit when err != nil
* Simplify error logic
