Carlos A Becker
00b76540ca
fix(snap): ignore human review error msg
...
closes #2194
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
2021-05-21 02:53:22 +00:00
Carlos Alexandro Becker
860b4a8f81
chore: gofumpt & lint ( #2190 )
...
Signed-off-by: Carlos Becker <caarlos0@gmail.com>
2021-04-25 14:20:49 -03:00
Carlos Alexandro Becker
5866b9cb63
refactor: use os and io packages intead of ioutil when possible ( #2189 )
2021-04-25 13:00:51 -03:00
Carlos Alexandro Becker
66117f3126
fix: several fd leaks (on tests) ( #2187 )
2021-04-25 11:34:40 -03:00
Peer Xu
c539ee0212
feat: support snapcraft layout ( #2112 )
...
* feat: add layout field to snapcraft pipe
* refactor: change bind-file to bind_file for snap description
* doc: update snapcraft layout document
2021-03-17 10:18:56 -03:00
Ani Channarasappa
a816d969c9
fix: update snapcraft command from 'push' to 'upload' ( #2051 )
...
as per deprecation message
2021-02-09 01:40:01 +00:00
dependabot[bot]
1b0b6be8c5
chore(deps): bump github.com/golangci/golangci-lint from 1.33.0 to 1.34.1 ( #1975 )
...
* chore(deps): bump github.com/golangci/golangci-lint
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint ) from 1.33.0 to 1.34.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases )
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md )
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.33.0...v1.34.1 )
Signed-off-by: dependabot[bot] <support@github.com>
* fix: lint issues
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: go mod tidy
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-12-29 15:40:21 +00:00
Carlos Alexandro Becker
92f52ac406
refactor(test): use testing.TB Cleanup and Tempdir ( #1945 )
...
* refactor: use t.Cleanup instead of defer
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* refactor: use t.Cleanup instead of defer
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* refactor: use t.Cleanup instead of defer
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* refactor: use t.Cleanup instead of defer
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: filepath
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-12-12 13:27:35 -03:00
Jonas Bögle
cc3590adb8
tests: fix snapcraft tests ( #1862 )
2020-10-24 11:01:34 -03:00
Carlos Alexandro Becker
2d8823b8cf
feat: snap restart-condition ( #1837 )
...
* feat: snap restart-condition
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* docs: restart-condition
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-10-06 10:59:53 -03:00
Carlos Alexandro Becker
a6a4f29374
fix: use require on snapcraft tests ( #1836 )
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-10-05 22:05:22 -03:00
Carlos Alexandro Becker
65ffbf1921
refactor: replace pkg/errors.Wrap with fmt.Errorf ( #1812 )
...
* refactor: remove pkg/errors
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* refactor: remove pkg/errors
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2020-09-21 17:47:51 +00:00
Carlos Alexandro Becker
10a237364b
fix: avoid copying the completer multiple times ( #1680 )
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-07-20 10:36:09 -03:00
Aggelos Kolaitis
a69b525ddb
fix: Completer script link errors for snapcraft ( #1679 )
2020-07-17 16:11:08 -03:00
Aggelos Kolaitis
0c0063a5b4
feat: Support custom command and extra files in snaps ( #1553 )
2020-06-06 15:07:18 -03:00
Carlos Alexandro Becker
69c8a502db
chore(deps): bump github.com/golangci/golangci-lint from 1.23.7 to 1.27.0 ( #1563 )
...
* chore(deps): bump github.com/golangci/golangci-lint from 1.23.7 to 1.27.0
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: tests
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-05-26 00:48:10 -03:00
Aggelos Kolaitis
20e3718a56
fix: snap package apps with multiple binaries ( #1449 )
2020-04-17 17:24:32 +00:00
Carlos Alexandro Becker
81417ea989
feat: improve output a bit ( #1380 )
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-03-06 01:25:09 -03:00
Carlos Alexandro Becker
2e69fa0667
fix: snapcraft: do not push when skip publish ( #1374 )
...
* fix: snapcraft: do not publish when skip publish
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: snapcraft: do not publish when skip publish
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-03-04 01:14:40 -03:00
Carlos Alexandro Becker
a099acf5f5
fix: snap autocompletions ( #1346 )
...
closes #1343
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-02-17 09:12:32 -03:00
Carlos Alexandro Becker
d85fff06a2
fix gomips support ( #1331 )
...
* wip: fix gomips
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* wip: fix gomips
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* test: added more
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* test: added more
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-02-05 22:08:18 -03:00
Carlos Alexandro Becker
a4c91105b5
fix: snap with empty apps name
...
refs #1267
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-01-30 10:57:07 -03:00
Carlos Alexandro Becker
f1fc2c03bd
fix: lint
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2020-01-26 12:24:00 -03:00
Jared Folkins
eb528971b9
fix: allow snapcraft apps: directive
to use custom commands ( #1267 )
...
* enhc: allow snapcraft apps: directive to utilize custom commands, defaults to binary name if no apps: are specified
* refactor: snapcraft tests
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
2020-01-26 12:23:08 -03:00
Carlos Alexandro Becker
468401bc54
feat: remove singular snapcraft config ( #1281 )
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2019-12-27 17:31:03 -03:00
Carlos Alexandro Becker
b477ffa095
refactor: pointer to artifact ( #1110 )
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2019-08-12 17:44:48 -03:00
Carlos Alexandro Becker
8286402e3e
fix: better duplicate ID message
...
refs #1090
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2019-07-27 10:55:56 -03:00
Carlos Alexandro Becker
04f17669cc
feat(snap): allow previous in review process ( #1070 )
...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
2019-07-20 18:31:04 -03:00
Tom Payne
c9546ec81b
feat: add support for completer in snaps ( #1055 )
...
* feat: add support for completer in snaps
* test: add completer test
2019-06-22 22:37:55 -03:00
Tobias Kündig
3eec7e3e9d
fix: wrap snapcraft command in TrimSpace ( #1035 )
2019-05-29 16:08:48 -03:00
Carlos Alexandro Becker
d355350f63
fix: nfpm id ( #1030 )
...
* fix: nfpm id
* fix: import order
2019-05-29 09:13:52 -03:00
Carlos Alexandro Becker
7e809382df
fix: armhf on arm v6 ( #1027 )
...
* fix: armhf on arm v6
* fix: armel is arm5, so fix test
2019-05-29 09:09:52 -03:00
Carlos Alexandro Becker
3ec6e5f05b
feat: multiple snapcraft ( #1025 )
...
* feat: multiple snapcraft
* test: more tests
2019-05-27 12:47:05 -03:00
Grachev Mikhail
2b8258f003
feat: add base key to snapcraft ( #1011 )
2019-04-18 17:21:40 -03:00
Grachev Mikhail
3da2b375c9
feat: add license to snapcraft ( #1010 )
2019-04-17 17:26:30 -03:00
Simon Barendse
2de196a745
fix: use bin name instead of bin path to set snap app config ( #1002 )
...
* fix: use bin name instead of bin path to set snap app config
* feat: add testcase for snap with binary in dir
2019-04-09 12:14:48 -03:00
Simon Barendse
ce69ee5316
fix: use the filename of the binary in snapcraft ( #1001 )
...
* fix: use the filename of the binary in snapcraft
When builds.binary is a path, only use the filename as the name
of the snapcraft app and as the command, instead of the full path.
* docs: use a path in the binary name
2019-04-09 09:14:28 -03:00
Carlos Alexandro Becker
486d5303fd
fix(snapcraft): improve logs
2019-03-19 21:45:08 -03:00
Carlos Alexandro Becker
7c712120bc
feat: added Plugs attribute to snapcraft.Metadata ( #984 , #980 , #979 )
...
* feat: added Plugs attribute to snapcraft.Metadata allowing plugs to be configured as plugs.<plug-name>.<attribute-name>
* fix (test): added snapcraft plugs configuration test
* fix: snapcraft Metadata to use correct data type for Plugs
* fix: refactor Snapcraft Plug configuration
* fix: test on newer snapcraft
hopefully
* docs: snap plugs
2019-03-14 09:56:11 -03:00
Carlos Alexandro Becker
a69ef61d60
fix: snapshot version handling
2018-12-13 12:11:12 -02:00
Carlos Alexandro Becker
513473b446
fix: snapcraft: broken permissions
2018-12-12 18:32:22 -02:00
Carlos Alexandro Becker
7060eb8450
chore: small code improvements
2018-12-12 18:24:22 -02:00
Garcia, Julio C
2da661bc77
fix: improve log output #845
...
Fixed missunderstanding
2018-10-27 13:36:58 -03:00
Garcia, Julio C
0f6d8daa05
fix: improve log output #845
...
Removed the "creating" prefixes.
2018-10-27 13:36:58 -03:00
Carlos Alexandro Becker
84fdac7f2b
chore: improved log
2018-10-20 17:54:41 -03:00
Carlos Alexandro Becker
75c999ac73
chore: added a TODO
2018-10-20 17:47:55 -03:00
Carlos Alexandro Becker
f7268a0979
fix: deploy goreleases to snap store
2018-10-20 17:41:31 -03:00
Carlos Alexandro Becker
32d9440dff
test: added more tests
2018-10-20 17:25:18 -03:00
Carlos Alexandro Becker
6310b8c12d
fix: lint
2018-10-20 17:25:18 -03:00
Carlos Alexandro Becker
3d87275c09
fix: allow to publish snaps
2018-10-20 17:25:18 -03:00