mirror of
https://github.com/goreleaser/goreleaser.git
synced 2025-01-08 03:31:59 +02:00
a9c76d7655
The PR fixes lint issues, pins `golangci-lint` to `v1.56.2`, disables `only-new-issues`, and enables `fail-on-issues` in the lint workflow. After this, all new lint issues will fail CI. The full log of fixed lint issues: ```sh ❯ golangci-lint run cmd/docs.go:24:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: func(cmd *cobra.Command, args []string) error { ^ cmd/man.go:26:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: func(cmd *cobra.Command, args []string) error { ^ cmd/healthcheck.go:36:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: func(cmd *cobra.Command, args []string) error { ^ cmd/build.go:72:33: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: timedRunE("build", func(cmd *cobra.Command, args []string) error { ^ cmd/schema.go:29:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: func(cmd *cobra.Command, args []string) error { ^ internal/pipe/nix/nix_test.go:547:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectDefaultErrorIs) ^ internal/pipe/nix/nix_test.go:556:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectRunErrorIs) ^ internal/pipe/nix/nix_test.go:567:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectPublishErrorIs) ^ internal/pipe/winget/winget_test.go:709:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectPublishErrorIs) ^ internal/pipe/winget/winget_test.go:728:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectPublishErrorIs) ^ internal/pipe/docker/docker_test.go:56:29: unused-parameter: parameter 'use' seems to be unused, consider removing or renaming it as _ (revive) return func(t *testing.T, use string) { ^ internal/gio/safe_test.go:23:4: go-require: require must only be used in the goroutine running the test function (testifylint) require.Equal(t, 1, s) ^ internal/gio/safe_test.go:24:4: go-require: require must only be used in the goroutine running the test function (testifylint) require.NoError(t, err) ^ internal/pipe/gomod/gomod_proxy_test.go:126:3: useless-assert: asserting of the same variable (testifylint) require.Equal(t, ctx.ModulePath, ctx.ModulePath) ^ internal/pipe/gomod/gomod_proxy_test.go:152:3: useless-assert: asserting of the same variable (testifylint) require.Equal(t, ctx.ModulePath, ctx.ModulePath) ^ internal/pipe/gomod/gomod_proxy_test.go:178:3: useless-assert: asserting of the same variable (testifylint) require.Equal(t, ctx.ModulePath, ctx.ModulePath) ^ internal/pipe/gomod/gomod_proxy_test.go:239:3: useless-assert: asserting of the same variable (testifylint) require.Equal(t, ctx.ModulePath, ctx.ModulePath) ^ internal/artifact/artifact_test.go:638:46: unused-parameter: parameter 'a' seems to be unused, consider removing or renaming it as _ (revive) require.EqualError(t, artifacts.Visit(func(a *Artifact) error { ^ internal/pipe/milestone/milestone.go:79: File is not `gofumpt`-ed (gofumpt) internal/http/http_test.go:217:19: unused-parameter: parameter 'k' seems to be unused, consider removing or renaming it as _ (revive) assetOpen = func(k string, a *artifact.Artifact) (*asset, error) { ^ internal/middleware/logging/logging_test.go:12:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, Log("foo", func(ctx *context.Context) error { ^ internal/middleware/logging/logging_test.go:16:40: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, PadLog("foo", func(ctx *context.Context) error { ^ internal/pipe/chocolatey/chocolatey_test.go:277:15: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) exec: func(cmd string, args ...string) ([]byte, error) { ^ internal/client/gitlab.go:325: File is not `gofumpt`-ed (gofumpt) internal/pipe/linkedin/client_test.go:58:77: unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive) server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) { ^ internal/middleware/errhandler/error_test.go:15:34: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, Handle(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:21:34: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, Handle(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:27:32: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.Error(t, Handle(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:36:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, memo.Wrap(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:42:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, memo.Wrap(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:48:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, memo.Wrap(func(ctx *context.Context) error { ^ internal/pipe/ko/ko.go:175:29: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) build.WithBaseImages(func(ctx stdctx.Context, s string) (name.Reference, build.Result, error) { ^ ```
121 lines
2.4 KiB
Go
121 lines
2.4 KiB
Go
package linkedin
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/goreleaser/goreleaser/internal/testctx"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCreateLinkedInClient(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
cfg oauthClientConfig
|
|
wantErr error
|
|
}{
|
|
{
|
|
"non-empty context and access token",
|
|
oauthClientConfig{
|
|
Context: testctx.New(),
|
|
AccessToken: "foo",
|
|
},
|
|
nil,
|
|
},
|
|
{
|
|
"empty context",
|
|
oauthClientConfig{
|
|
Context: nil,
|
|
AccessToken: "foo",
|
|
},
|
|
fmt.Errorf("context is nil"),
|
|
},
|
|
{
|
|
"empty access token",
|
|
oauthClientConfig{
|
|
Context: testctx.New(),
|
|
AccessToken: "",
|
|
},
|
|
fmt.Errorf("empty access token"),
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
_, err := createLinkedInClient(tt.cfg)
|
|
if tt.wantErr != nil {
|
|
require.EqualError(t, err, tt.wantErr.Error())
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestClient_Share(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, _ *http.Request) {
|
|
_, _ = io.WriteString(rw, `
|
|
{
|
|
"sub": "foo",
|
|
"activity": "123456789"
|
|
}
|
|
`)
|
|
}))
|
|
defer server.Close()
|
|
|
|
c, err := createLinkedInClient(oauthClientConfig{
|
|
Context: testctx.New(),
|
|
AccessToken: "foo",
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("could not create client: %v", err)
|
|
}
|
|
|
|
c.baseURL = server.URL
|
|
|
|
link, err := c.Share("test")
|
|
if err != nil {
|
|
t.Fatalf("could not share: %v", err)
|
|
}
|
|
|
|
wantLink := "https://www.linkedin.com/feed/update/123456789"
|
|
require.Equal(t, wantLink, link)
|
|
}
|
|
|
|
func TestClientLegacyProfile_Share(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
|
if req.URL.Path == "/v2/userinfo" {
|
|
rw.WriteHeader(http.StatusForbidden)
|
|
return
|
|
}
|
|
// this is the response from /v2/me (legacy as a fallback)
|
|
_, _ = io.WriteString(rw, `
|
|
{
|
|
"id": "foo",
|
|
"activity": "123456789"
|
|
}
|
|
`)
|
|
}))
|
|
defer server.Close()
|
|
|
|
c, err := createLinkedInClient(oauthClientConfig{
|
|
Context: testctx.New(),
|
|
AccessToken: "foo",
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("could not create client: %v", err)
|
|
}
|
|
|
|
c.baseURL = server.URL
|
|
|
|
link, err := c.Share("test")
|
|
if err != nil {
|
|
t.Fatalf("could not share: %v", err)
|
|
}
|
|
|
|
wantLink := "https://www.linkedin.com/feed/update/123456789"
|
|
require.Equal(t, wantLink, link)
|
|
}
|