mirror of
https://github.com/goreleaser/goreleaser.git
synced 2025-01-24 04:16:27 +02:00
a9c76d7655
The PR fixes lint issues, pins `golangci-lint` to `v1.56.2`, disables `only-new-issues`, and enables `fail-on-issues` in the lint workflow. After this, all new lint issues will fail CI. The full log of fixed lint issues: ```sh ❯ golangci-lint run cmd/docs.go:24:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: func(cmd *cobra.Command, args []string) error { ^ cmd/man.go:26:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: func(cmd *cobra.Command, args []string) error { ^ cmd/healthcheck.go:36:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: func(cmd *cobra.Command, args []string) error { ^ cmd/build.go:72:33: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: timedRunE("build", func(cmd *cobra.Command, args []string) error { ^ cmd/schema.go:29:14: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) RunE: func(cmd *cobra.Command, args []string) error { ^ internal/pipe/nix/nix_test.go:547:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectDefaultErrorIs) ^ internal/pipe/nix/nix_test.go:556:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectRunErrorIs) ^ internal/pipe/nix/nix_test.go:567:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectPublishErrorIs) ^ internal/pipe/winget/winget_test.go:709:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectPublishErrorIs) ^ internal/pipe/winget/winget_test.go:728:5: error-is-as: second argument to require.ErrorAs should not be *error (testifylint) require.ErrorAs(t, err, &tt.expectPublishErrorIs) ^ internal/pipe/docker/docker_test.go:56:29: unused-parameter: parameter 'use' seems to be unused, consider removing or renaming it as _ (revive) return func(t *testing.T, use string) { ^ internal/gio/safe_test.go:23:4: go-require: require must only be used in the goroutine running the test function (testifylint) require.Equal(t, 1, s) ^ internal/gio/safe_test.go:24:4: go-require: require must only be used in the goroutine running the test function (testifylint) require.NoError(t, err) ^ internal/pipe/gomod/gomod_proxy_test.go:126:3: useless-assert: asserting of the same variable (testifylint) require.Equal(t, ctx.ModulePath, ctx.ModulePath) ^ internal/pipe/gomod/gomod_proxy_test.go:152:3: useless-assert: asserting of the same variable (testifylint) require.Equal(t, ctx.ModulePath, ctx.ModulePath) ^ internal/pipe/gomod/gomod_proxy_test.go:178:3: useless-assert: asserting of the same variable (testifylint) require.Equal(t, ctx.ModulePath, ctx.ModulePath) ^ internal/pipe/gomod/gomod_proxy_test.go:239:3: useless-assert: asserting of the same variable (testifylint) require.Equal(t, ctx.ModulePath, ctx.ModulePath) ^ internal/artifact/artifact_test.go:638:46: unused-parameter: parameter 'a' seems to be unused, consider removing or renaming it as _ (revive) require.EqualError(t, artifacts.Visit(func(a *Artifact) error { ^ internal/pipe/milestone/milestone.go:79: File is not `gofumpt`-ed (gofumpt) internal/http/http_test.go:217:19: unused-parameter: parameter 'k' seems to be unused, consider removing or renaming it as _ (revive) assetOpen = func(k string, a *artifact.Artifact) (*asset, error) { ^ internal/middleware/logging/logging_test.go:12:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, Log("foo", func(ctx *context.Context) error { ^ internal/middleware/logging/logging_test.go:16:40: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, PadLog("foo", func(ctx *context.Context) error { ^ internal/pipe/chocolatey/chocolatey_test.go:277:15: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) exec: func(cmd string, args ...string) ([]byte, error) { ^ internal/client/gitlab.go:325: File is not `gofumpt`-ed (gofumpt) internal/pipe/linkedin/client_test.go:58:77: unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive) server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) { ^ internal/middleware/errhandler/error_test.go:15:34: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, Handle(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:21:34: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, Handle(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:27:32: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.Error(t, Handle(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:36:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, memo.Wrap(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:42:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, memo.Wrap(func(ctx *context.Context) error { ^ internal/middleware/errhandler/error_test.go:48:37: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) require.NoError(t, memo.Wrap(func(ctx *context.Context) error { ^ internal/pipe/ko/ko.go:175:29: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive) build.WithBaseImages(func(ctx stdctx.Context, s string) (name.Reference, build.Result, error) { ^ ```
360 lines
8.5 KiB
Go
360 lines
8.5 KiB
Go
package chocolatey
|
|
|
|
import (
|
|
"errors"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/goreleaser/goreleaser/internal/artifact"
|
|
"github.com/goreleaser/goreleaser/internal/client"
|
|
"github.com/goreleaser/goreleaser/internal/golden"
|
|
"github.com/goreleaser/goreleaser/internal/skips"
|
|
"github.com/goreleaser/goreleaser/internal/testctx"
|
|
"github.com/goreleaser/goreleaser/internal/testlib"
|
|
"github.com/goreleaser/goreleaser/pkg/config"
|
|
"github.com/goreleaser/goreleaser/pkg/context"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestContinueOnError(t *testing.T) {
|
|
require.True(t, Pipe{}.ContinueOnError())
|
|
}
|
|
|
|
func TestDescription(t *testing.T) {
|
|
require.NotEmpty(t, Pipe{}.String())
|
|
}
|
|
|
|
func TestSkip(t *testing.T) {
|
|
t.Run("skip", func(t *testing.T) {
|
|
require.True(t, Pipe{}.Skip(testctx.New()))
|
|
})
|
|
t.Run("skip flag", func(t *testing.T) {
|
|
ctx := testctx.NewWithCfg(config.Project{
|
|
Chocolateys: []config.Chocolatey{
|
|
{},
|
|
},
|
|
}, testctx.Skip(skips.Chocolatey))
|
|
require.True(t, Pipe{}.Skip(ctx))
|
|
})
|
|
|
|
t.Run("dont skip", func(t *testing.T) {
|
|
ctx := testctx.NewWithCfg(config.Project{
|
|
Chocolateys: []config.Chocolatey{
|
|
{},
|
|
},
|
|
})
|
|
require.False(t, Pipe{}.Skip(ctx))
|
|
})
|
|
}
|
|
|
|
func TestDefault(t *testing.T) {
|
|
testlib.Mktmp(t)
|
|
|
|
ctx := testctx.NewWithCfg(config.Project{
|
|
ProjectName: "myproject",
|
|
Chocolateys: []config.Chocolatey{
|
|
{},
|
|
},
|
|
}, testctx.GitHubTokenType)
|
|
|
|
require.NoError(t, Pipe{}.Default(ctx))
|
|
require.Equal(t, ctx.Config.ProjectName, ctx.Config.Chocolateys[0].Name)
|
|
require.Equal(t, ctx.Config.ProjectName, ctx.Config.Chocolateys[0].Title)
|
|
require.Equal(t, "v1", ctx.Config.Chocolateys[0].Goamd64)
|
|
}
|
|
|
|
func Test_doRun(t *testing.T) {
|
|
folder := t.TempDir()
|
|
file := filepath.Join(folder, "archive")
|
|
require.NoError(t, os.WriteFile(file, []byte("lorem ipsum"), 0o644))
|
|
|
|
tests := []struct {
|
|
name string
|
|
choco config.Chocolatey
|
|
exec func(cmd string, args ...string) ([]byte, error)
|
|
published int
|
|
err string
|
|
}{
|
|
{
|
|
name: "no artifacts",
|
|
choco: config.Chocolatey{
|
|
Name: "app",
|
|
IDs: []string{"no-app"},
|
|
Goamd64: "v1",
|
|
},
|
|
err: errNoWindowsArchive.Error(),
|
|
},
|
|
{
|
|
name: "choco command not found",
|
|
choco: config.Chocolatey{
|
|
Name: "app",
|
|
Goamd64: "v1",
|
|
},
|
|
exec: func(_ string, _ ...string) ([]byte, error) {
|
|
return nil, errors.New(`exec: "choco.exe": executable file not found in $PATH`)
|
|
},
|
|
err: `failed to generate chocolatey package: exec: "choco.exe": executable file not found in $PATH: `,
|
|
},
|
|
{
|
|
name: "skip publish",
|
|
choco: config.Chocolatey{
|
|
Name: "app",
|
|
Goamd64: "v1",
|
|
SkipPublish: true,
|
|
},
|
|
exec: func(cmd string, args ...string) ([]byte, error) {
|
|
checkPackCmd(t, cmd, args...)
|
|
return []byte("success"), nil
|
|
},
|
|
},
|
|
{
|
|
name: "success",
|
|
choco: config.Chocolatey{
|
|
Name: "app",
|
|
Goamd64: "v1",
|
|
},
|
|
exec: func(cmd string, args ...string) ([]byte, error) {
|
|
checkPackCmd(t, cmd, args...)
|
|
return []byte("success"), nil
|
|
},
|
|
published: 1,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
cmd = fakeCmd{execFn: tt.exec}
|
|
t.Cleanup(func() {
|
|
cmd = stdCmd{}
|
|
})
|
|
|
|
ctx := testctx.NewWithCfg(
|
|
config.Project{
|
|
Dist: folder,
|
|
ProjectName: "run-all",
|
|
},
|
|
testctx.WithCurrentTag("v1.0.1"),
|
|
testctx.WithVersion("1.0.1"),
|
|
)
|
|
|
|
ctx.Artifacts.Add(&artifact.Artifact{
|
|
Name: "app_1.0.1_windows_amd64.zip",
|
|
Path: file,
|
|
Goos: "windows",
|
|
Goarch: "amd64",
|
|
Goamd64: "v1",
|
|
Type: artifact.UploadableArchive,
|
|
Extra: map[string]interface{}{
|
|
artifact.ExtraID: "app",
|
|
artifact.ExtraFormat: "zip",
|
|
},
|
|
})
|
|
|
|
client := client.NewMock()
|
|
got := doRun(ctx, client, tt.choco)
|
|
|
|
var err string
|
|
if got != nil {
|
|
err = got.Error()
|
|
}
|
|
if tt.err != err {
|
|
t.Errorf("Unexpected error: %s (expected %s)", err, tt.err)
|
|
}
|
|
|
|
list := ctx.Artifacts.Filter(artifact.ByType(artifact.PublishableChocolatey)).List()
|
|
require.Len(t, list, tt.published)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_buildNuspec(t *testing.T) {
|
|
ctx := testctx.New(testctx.WithVersion("1.12.3"))
|
|
choco := config.Chocolatey{
|
|
Name: "goreleaser",
|
|
IDs: []string{},
|
|
Title: "GoReleaser",
|
|
Authors: "caarlos0",
|
|
ProjectURL: "https://goreleaser.com/",
|
|
Tags: "go docker homebrew golang package",
|
|
Summary: "Deliver Go binaries as fast and easily as possible",
|
|
Description: "GoReleaser builds Go binaries for several platforms, creates a GitHub release and then pushes a Homebrew formula to a tap repository. All that wrapped in your favorite CI.",
|
|
Dependencies: []config.ChocolateyDependency{
|
|
{ID: "nfpm"},
|
|
},
|
|
}
|
|
|
|
out, err := buildNuspec(ctx, choco)
|
|
require.NoError(t, err)
|
|
|
|
golden.RequireEqualExt(t, out, ".nuspec")
|
|
}
|
|
|
|
func Test_buildTemplate(t *testing.T) {
|
|
folder := t.TempDir()
|
|
file := filepath.Join(folder, "archive")
|
|
require.NoError(t, os.WriteFile(file, []byte("lorem ipsum"), 0o644))
|
|
ctx := testctx.New(testctx.WithVersion("1.0.0"), testctx.WithCurrentTag("v1.0.0"))
|
|
artifacts := []*artifact.Artifact{
|
|
{
|
|
Name: "app_1.0.0_windows_386.zip",
|
|
Goos: "windows",
|
|
Goarch: "386",
|
|
Goamd64: "v1",
|
|
Path: file,
|
|
},
|
|
{
|
|
Name: "app_1.0.0_windows_amd64.zip",
|
|
Goos: "windows",
|
|
Goarch: "amd64",
|
|
Goamd64: "v1",
|
|
Path: file,
|
|
},
|
|
}
|
|
|
|
choco := config.Chocolatey{
|
|
Name: "app",
|
|
}
|
|
|
|
client := client.NewMock()
|
|
|
|
data, err := dataFor(ctx, client, choco, artifacts)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
out, err := buildTemplate(choco.Name, scriptTemplate, data)
|
|
require.NoError(t, err)
|
|
|
|
golden.RequireEqualExt(t, out, ".script.ps1")
|
|
}
|
|
|
|
func TestPublish(t *testing.T) {
|
|
folder := t.TempDir()
|
|
file := filepath.Join(folder, "archive")
|
|
require.NoError(t, os.WriteFile(file, []byte("lorem ipsum"), 0o644))
|
|
|
|
fakenu := filepath.Join(t.TempDir(), "foo.nupkg")
|
|
require.NoError(t, os.WriteFile(fakenu, []byte("fake nupkg"), 0o644))
|
|
|
|
tests := []struct {
|
|
name string
|
|
artifacts []artifact.Artifact
|
|
exec func(cmd string, args ...string) ([]byte, error)
|
|
skip bool
|
|
err string
|
|
}{
|
|
{
|
|
name: "no artifacts",
|
|
},
|
|
{
|
|
name: "no api key",
|
|
artifacts: []artifact.Artifact{
|
|
{
|
|
Type: artifact.PublishableChocolatey,
|
|
Name: "app.1.0.1.nupkg",
|
|
Extra: map[string]interface{}{
|
|
artifact.ExtraFormat: nupkgFormat,
|
|
chocoConfigExtra: config.Chocolatey{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "push error",
|
|
artifacts: []artifact.Artifact{
|
|
{
|
|
Type: artifact.PublishableChocolatey,
|
|
Name: "app.1.0.1.nupkg",
|
|
Extra: map[string]interface{}{
|
|
artifact.ExtraFormat: nupkgFormat,
|
|
chocoConfigExtra: config.Chocolatey{
|
|
APIKey: "abcd",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
exec: func(_ string, _ ...string) ([]byte, error) {
|
|
return nil, errors.New(`unable to push`)
|
|
},
|
|
err: "failed to push chocolatey package: unable to push: ",
|
|
},
|
|
{
|
|
name: "success",
|
|
artifacts: []artifact.Artifact{
|
|
{
|
|
Type: artifact.PublishableChocolatey,
|
|
Name: "app.1.0.1.nupkg",
|
|
Path: fakenu,
|
|
Extra: map[string]interface{}{
|
|
artifact.ExtraFormat: nupkgFormat,
|
|
chocoConfigExtra: config.Chocolatey{
|
|
APIKey: "abcd",
|
|
SourceRepo: "abc",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
exec: func(cmd string, args ...string) ([]byte, error) {
|
|
checkPushCmd(t, cmd, args...)
|
|
return []byte("success"), nil
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
cmd = fakeCmd{execFn: tt.exec}
|
|
t.Cleanup(func() {
|
|
cmd = stdCmd{}
|
|
})
|
|
|
|
ctx := testctx.New()
|
|
for _, artifact := range tt.artifacts {
|
|
ctx.Artifacts.Add(&artifact)
|
|
}
|
|
|
|
got := Pipe{}.Publish(ctx)
|
|
|
|
var err string
|
|
if got != nil {
|
|
err = got.Error()
|
|
}
|
|
if tt.err != err {
|
|
t.Errorf("Unexpected error: %s (expected %s)", err, tt.err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestDependencies(t *testing.T) {
|
|
require.Equal(t, []string{"choco"}, Pipe{}.Dependencies(nil))
|
|
}
|
|
|
|
type fakeCmd struct {
|
|
execFn func(cmd string, args ...string) ([]byte, error)
|
|
}
|
|
|
|
var _ cmder = fakeCmd{}
|
|
|
|
func (f fakeCmd) Exec(_ *context.Context, cmd string, args ...string) ([]byte, error) {
|
|
return f.execFn(cmd, args...)
|
|
}
|
|
|
|
func checkPushCmd(tb testing.TB, cmd string, args ...string) {
|
|
tb.Helper()
|
|
tb.Log("would have run:", cmd, args)
|
|
require.Len(tb, args, 6)
|
|
require.Equal(tb, "choco", cmd)
|
|
require.FileExists(tb, args[5])
|
|
}
|
|
|
|
func checkPackCmd(tb testing.TB, cmd string, args ...string) {
|
|
tb.Helper()
|
|
tb.Log("would have run:", cmd, args)
|
|
require.Len(tb, args, 4)
|
|
require.Equal(tb, "choco", cmd)
|
|
require.FileExists(tb, args[1])
|
|
require.DirExists(tb, args[3])
|
|
}
|