go/ko-build
1
0
Fork 0
mirror of https://github.com/ko-build/ko.git synced 2024-12-09 08:46:13 +02:00
Code Issues Releases Activity

Allow plain registries as KO_DOCKER_REPO (#94)

Browse Source 
This allows you to use e.g. localhost:5000 as KO_DOCKER_REPO.

Fixes #93.
This commit is contained in:
jonjohnsonjr 2019-10-02 10:02:01 -07:00 committed by GitHub
parent 241d532569
commit 3880b61d2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/commands/resolver.go
View File

@ -93,9 +93,10 @@ func makePublisher(no *options.NameOptions, lo *options.LocalOptions, ta *option
if repoName == "" {
return nil, errors.New("KO_DOCKER_REPO environment variable is unset")
}
_, err := name.NewRepository(repoName)
if err != nil {
return nil, fmt.Errorf("failed to parse environment variable KO_DOCKER_REPO=%q as repository: %v", repoName, err)
if _, err := name.NewRegistry(repoName); err != nil {
if _, err := name.NewRepository(repoName); err != nil {
return nil, fmt.Errorf("failed to parse environment variable KO_DOCKER_REPO=%q as repository: %v", repoName, err)
}
}
return publish.NewDefault(repoName,

11
pkg/publish/options.go
View File

@ -48,11 +48,16 @@ func WithAuthFromKeychain(keys authn.Keychain) Option {
// means that docker.io/mattmoor actually gets interpreted as
// docker.io/library/mattmoor, which gets tricky when we start
// appending things to it in the publisher.
repo, err := name.NewRepository(i.base)
reg, err := name.NewRegistry(i.base)
if err != nil {
return err
// Workaround for localhost:5000 as KO_DOCKER_REPO.
repo, err := name.NewRepository(i.base)
if err != nil {
return err
}
reg = repo.Registry
}
auth, err := keys.Resolve(repo.Registry)
auth, err := keys.Resolve(reg)
if err != nil {
return err
}