go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2024-12-06 10:47:38 +02:00
Code Issues Releases Activity

Remove redundant waitgroup

Browse Source 
Turns out we're just running our refresh functions one after the other which isn't ideal but we can fix that separately.
As it stands this wait group isn't doing anything.
This commit is contained in:
Jesse Duffield 2023-07-08 15:22:26 +10:00
parent 26ca41a40e
commit 015a04fac6
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/gui/controllers/helpers/refresh_helper.go
View File

@ -63,8 +63,6 @@ func (self *RefreshHelper) Refresh(options types.RefreshOptions) error {
)
}
wg := sync.WaitGroup{}
f := func() {
var scopeSet *set.Set[types.RefreshableView]
if len(options.Scope) == 0 {
@ -87,15 +85,11 @@ func (self *RefreshHelper) Refresh(options types.RefreshOptions) error {
}
refresh := func(f func()) {
wg.Add(1)
func() {
if options.Mode == types.ASYNC {
self.c.OnWorker(f)
} else {
f()
}
wg.Done()
}()
if options.Mode == types.ASYNC {
self.c.OnWorker(f)
} else {
f()
}
}
if scopeSet.Includes(types.COMMITS) || scopeSet.Includes(types.BRANCHES) || scopeSet.Includes(types.REFLOG) || scopeSet.Includes(types.BISECT_INFO) {
@ -143,8 +137,6 @@ func (self *RefreshHelper) Refresh(options types.RefreshOptions) error {
refresh(func() { _ = self.mergeConflictsHelper.RefreshMergeState() })
}
wg.Wait()
self.refreshStatus()
if options.Then != nil {