go/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-01-04 03:48:07 +02:00
Code Issues Releases Activity

pkg/updates: Fix resource availability check in Updater

Browse Source 
When trying to download an update, a 'Could not find any binary at ...' error
message is shown erroneously. This happens since when checking the availability,
a response code of 403 ('Forbidden') instead of 200 ('OK') is expected. Since
'http.Head()' handles redirects automatically, there is no need to also accept
3xx status codes.

Fixes #1450.
This commit is contained in:
Moritz Haase 2022-03-18 10:59:58 +01:00 committed by Jesse Duffield
parent 4fde97b066
commit 4b56d428ff
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/updates/updates.go
View File

@ -329,7 +329,6 @@ func (u *Updater) verifyResourceFound(rawUrl string) bool {
}
defer resp.Body.Close()
u.Log.Info("Received status code ", resp.StatusCode)
// 403 means the resource is there (not going to bother adding extra request headers)
// 404 means its not
return resp.StatusCode == 403
// OK (200) indicates that the resource is present.
return resp.StatusCode == http.StatusOK
}