Stefan Haller
7953f7fa86
Make RenderDisplayStrings return the column positions
...
Not used by anything yet, but we'll need it later in this branch.
2023-08-28 14:21:06 +02:00
Stefan Haller
7a8df7795c
Take removed columns into account when applying column alignments
2023-08-28 14:21:06 +02:00
Stefan Haller
aa493d3a9e
Add failing test demonstrating bug with column alignments and removed columns
...
When columns to the left of a column with an alignment are removed, the
alignment applies to the wrong column. We'll fix this in the next commit.
2023-08-28 14:21:06 +02:00
Stefan Haller
72731f2c16
Change RenderDisplayStrings to return a slice of strings
...
We'll join them with newlines afterwards. This will make it easier to insert
other (non-model) items.
2023-08-28 14:21:06 +02:00
Stefan Haller
f680b6e82e
Cleanup: use slices.Delete to delete elements from a slice
...
I find this much easier to read.
2023-08-28 14:21:06 +02:00
Stefan Haller
ec22570eac
Add tests for renderLines
...
These are very simple yet, but we'll extend them in the next commits.
2023-08-28 14:21:06 +02:00
Stefan Haller
198ead7c14
Extract a ListRenderer struct
...
I'm doing this not so much because it's a great abstraction, but just because it
will make it much easier to write tests for it.
2023-08-28 14:21:06 +02:00
Stefan Haller
297a020abf
Call getDisplayStrings with a valid range of model indices
...
It's nicer if clients can rely on the indices being valid, and don't have to
clamp themselves.
2023-08-28 14:21:06 +02:00
Stefan Haller
473d989cde
Extract a renderLines function
...
We'll make some changes to how the display strings are rendered, so it helps to
have this code only once. This also fixes the problem that contexts using
refreshViewportOnChange weren't able to use column alignments so far. We didn't
need this yet, but it's just nice if everything works. :)
2023-08-28 14:21:06 +02:00
Stefan Haller
061bfce835
Change length parameter of getDisplayStrings to endIdx
...
It's more natural to work with this way, as we will see later in this branch.
2023-08-28 14:21:06 +02:00
Jesse Duffield
996e30e5d9
Add icons for files with .mdx and .svelte file extensions ( #2889 )
2023-08-28 20:25:03 +10:00
Jesse Duffield
ecd2a14a15
Add install instructions for openSUSE ( #2727 )
2023-08-28 20:10:49 +10:00
README-bot
8dfa8dc48c
Updated README.md
2023-08-28 09:52:42 +00:00
Jesse Duffield
f7c183a429
Add instruction in PR template to start PRs with an imperative ( #2967 )
2023-08-28 19:52:25 +10:00
Jesse Duffield
473f86fcaa
Add instruction in PR template to start PRs with an imperative
...
This spares me effort when it comes to making release notes.
Yes, sometimes it may be easier to start a message without an imperative e.g. 'When X happens, do Y'
but I don't want to overwhelm the contributor with details.
2023-08-28 19:46:45 +10:00
Jesse Duffield
28353da61b
Allow adding a port to webDomain part of services config ( #2908 )
2023-08-28 19:38:45 +10:00
Jesse Duffield
efd49f07fd
Support custom keybindings for confirm discard ( #2960 )
2023-08-28 19:36:39 +10:00
Jesse Duffield
b8e183acc4
Add installation guide using winget CLI ( #2963 )
2023-08-28 14:58:56 +10:00
Erick Garcia Godoy
821c4b05fe
Add Winget to installation guide
2023-08-27 05:50:12 -03:00
Erick Garcia Godoy
4272d84fa2
Add Winget to installation guide
2023-08-27 05:45:43 -03:00
Mark Skelton
e95505453e
Update docs
2023-08-25 08:52:52 -05:00
Mark Skelton
6dc34d19ea
Support custom keybindings for confirm discard
2023-08-25 08:50:05 -05:00
Stefan Haller
a670fbb33c
Select same commit again after pressing "e" to edit a commit ( #2954 )
2023-08-24 10:48:07 +02:00
Stefan Haller
98e6c119f5
Select same commit again after pressing "e" to edit a commit
...
When editing a commit, the index of the current commit can change; for example,
when merge commits are involved, or when working with stacked branches where
"update-ref" commands may be added above the selected commit.
Reselect the current commit after pressing "e"; this requires doing the refresh
blocking on the main thread. (Another option that I considered was to use a
SYNC refresh, and then select the new line with an OnUIThread inside the Then
function. This also works, but results in a very visible lag.)
2023-08-22 14:08:12 +02:00
Stefan Haller
c718a73d0a
Call Then function only after everything is done
...
I'm actually surprised how this could even have worked before.
2023-08-22 14:06:31 +02:00
Stefan Haller
d74c817fd8
Panic when trying to use RefreshOptions.Then with mode ASYNC
...
This doesn't work, and since it took me a while of debugging to figure this out,
alert other developers earlier when they try to do it.
2023-08-22 14:06:31 +02:00
Stefan Haller
93d19db158
Add assertion to show the problem
2023-08-22 14:06:29 +02:00
Raido Oras
d7b611aa05
Allow port in webDomain for services config values
2023-08-21 14:33:58 +03:00
Jesse Duffield
fc6008fdff
fix GitHub Actions warnings ( #2950 )
2023-08-21 19:27:26 +10:00
kyu08
a65d3119c0
upgrade golangci/golangci-lint-action to v3.7.0
2023-08-21 18:11:33 +09:00
kyu08
51ecf4089b
upgrade actions/setup-go to v4 and remove actions/cache for go cache
2023-08-21 18:10:52 +09:00
kyu08
0c0fe8997b
upgrade goreleaser/goreleaser-action to v4
2023-08-21 18:09:59 +09:00
kyu08
f86309dd03
upgrade JamesIves/github-sponsors-readme-action to v1.2.2
2023-08-21 18:09:33 +09:00
Stefan Haller
c31fcb7134
Switch to editor from commit message panel ( #2881 )
2023-08-21 10:12:26 +02:00
Stefan Haller
91ec42f3f8
Add integration test
2023-08-21 10:03:34 +02:00
Stefan Haller
8f628296ad
Mention ctrl+o binding in commit message sub title
...
Only do this when an onSwitchToEditor function is actually provided. For the
"Move patch into new commit" command we don't, because it isn't totally
straightforward in that case.
2023-08-21 10:03:34 +02:00
Stefan Haller
61bd3e8dd2
Add key binding for switching from the commit message panel to an editor
...
This is useful for when you begin to type the message in lazygit's commit panel,
and then realize that you'd rather use your editor's more powerful editing
capabilities. Pressing <c-o> will take you right there.
2023-08-21 10:03:34 +02:00
Stefan Haller
7263630967
Remove obsolete comment
2023-08-21 10:03:34 +02:00
Jesse Duffield
16711c6f1a
Added termux installation [README.md] ( #2892 )
2023-08-21 18:02:59 +10:00
Jesse Duffield
b2023f10b6
Fix: Update 'zh' to 'zh-CN' in lazygit Language Configuration ( #2842 )
2023-08-21 17:56:45 +10:00
Stefan Haller
e915488a83
Add gui.scrollOffBehavior config for scrolling list views by half-pages ( #2939 )
2023-08-21 09:11:03 +02:00
Stefan Haller
b2d629b50a
Add scrollOffEnabled config
2023-08-21 09:03:45 +02:00
Stefan Haller
125d4fa9dc
Pass UserConfig to checkScrollUp/Down instead of just the scrollOffMargin
...
This will allow us to add a scrollOffEnabled config and have the functions
respect it without changes to clients.
2023-08-21 08:10:28 +02:00
Stefan Haller
527a1596f3
Add tests for scroll-off margin of zero
2023-08-21 08:10:28 +02:00
Stefan Haller
51d9f70f9e
Fix section levels
...
These appeared as subsections of "Platform Defaults", which doesn't make sense.
2023-08-21 08:10:28 +02:00
Jesse Duffield
83727d48b5
Feature add git flow instructions ( #2785 )
2023-08-21 15:51:51 +10:00
Bart
8efc175340
Add git flow description in readme
2023-08-21 15:50:54 +10:00
Jesse Duffield
6a6cb25d7e
Handle trailing slash in worktree path ( #2947 )
2023-08-21 13:26:58 +10:00
README-bot
fd782ff568
Updated README.md
2023-08-21 01:26:29 +00:00
Jesse Duffield
dbfb469bad
Add Makefile ( #2937 )
2023-08-21 11:26:15 +10:00
