go/lego
go/lego
1
0
Fork 0
mirror of https://github.com/go-acme/lego.git synced 2024-11-28 09:33:13 +02:00
Code Issues Releases Activity

chore: update linter (#2190)

Browse Source
This commit is contained in:
Ludovic Fernandez 2024-05-27 13:04:32 +02:00 committed by GitHub
parent 92bde4cd56
commit 220c608c80
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/pr.yml vendored
View File

@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
env:
GO_VERSION: stable
GOLANGCI_LINT_VERSION: v1.58.1
GOLANGCI_LINT_VERSION: v1.59.0
HUGO_VERSION: 0.117.0
CGO_ENABLED: 0
LEGO_E2E_TESTS: CI

4
.golangci.yml
View File

@ -152,6 +152,10 @@ issues:
- funlen
- goconst
- maintidx
- path: (.+)_test.go
text: 'Error return value of `fmt.Fprintln` is not checked'
linters:
- errcheck
- path: providers/dns/dns_providers.go
linters:
- gocyclo

2
providers/dns/dynu/internal/client_test.go
View File

@ -106,7 +106,7 @@ func TestGetRootDomain(t *testing.T) {
require.NoError(t, err)
assert.NotNil(t, domain)
assert.NotNil(t, domain) //nolint:testifylint // false positive https://github.com/Antonboom/testifylint/issues/95
assert.Equal(t, test.expected.domain, domain)
})
}

2
providers/dns/rcodezero/internal/client_test.go
View File

@ -74,7 +74,7 @@ func TestClient_UpdateRecords_error(t *testing.T) {
resp, err := client.UpdateRecords(context.Background(), "example.org", rrSet)
require.ErrorAs(t, err, new(*APIResponse))
assert.Nil(t, resp)
assert.Nil(t, resp) //nolint:testifylint // false positive https://github.com/Antonboom/testifylint/issues/95
}
func TestClient_UpdateRecords(t *testing.T) {

4
providers/dns/servercow/internal/client_test.go
View File

@ -151,7 +151,7 @@ func TestClient_CreateUpdateRecord_error(t *testing.T) {
msg, err := client.CreateUpdateRecord(context.Background(), "lego.wtf", record)
require.Error(t, err)
assert.Nil(t, msg)
assert.Nil(t, msg) //nolint:testifylint // false positive https://github.com/Antonboom/testifylint/issues/95
}
func TestClient_DeleteRecord(t *testing.T) {
@ -218,5 +218,5 @@ func TestClient_DeleteRecord_error(t *testing.T) {
msg, err := client.DeleteRecord(context.Background(), "lego.wtf", record)
require.Error(t, err)
assert.Nil(t, msg)
assert.Nil(t, msg) //nolint:testifylint // false positive https://github.com/Antonboom/testifylint/issues/95
}