1
0
mirror of https://github.com/go-acme/lego.git synced 2024-12-23 01:07:23 +02:00
lego/.github/PULL_REQUEST_TEMPLATE/mnp.md
2024-09-20 03:34:39 +02:00

1.0 KiB

PULL REQUEST TEMPLATE FOR MAINTAINERS ONLY.

https://github.com/go-acme/lego/compare/master...ldez:branch?quick_pull=1&title=Add+DNS+provider+for+&labels=enhancement,area/dnsprovider,state/need-user-tests&template=mnp.md

?quick_pull=1&title=Add+DNS+provider+for+&labels=enhancement,area/dnsprovider,state/need-user-tests&template=mnp.md


  • adds a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
    make build
    rm -rf .lego
    
    EXAMPLE_USERNAME=xxx \
    ./dist/lego -m your_email@example.com --dns EXAMPLE -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    
    Note the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @xxx, can you run the command (with your domain, email, credentials, etc.)?

Closes #