go/notify
1
0
Fork 0
mirror of https://github.com/nikoksr/notify.git synced 2024-11-30 08:46:43 +02:00
Code Issues Releases Activity
128 Commits 1 Branch 60 Tags 8.4 MiB
ecdfb6f1cf
Commit Graph

128 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Niko Köser
ecdfb6f1cf
refactor(telegram): simplify telegram.AddReceivers function 
Since AddReceivers no longer belongs to the notify.Notifier interface
its no longer forced to use a variadic string array as its main
parameter which needed to be parsed to an int64 array internally. The
telegram.AddReceivers now takes a variadic int64 array as parameter.
 2021-02-10 15:11:32 +01:00
Niko Köser
bd82278932
refactor(notifier): remove AddReceivers function from notify.Notifier interface 
AddReceivers was added to the notify.Notifier interface in 3d7cc206e1
and the fact that it shouldn't be there was obviously overlooked during
the code review.
The AddReceivers function is present in all services so far, but it does
not define the behavior of our services. The behavior is defined only by
the Send function. The AddReceivers function is also not called once in
the code on a notify.notifier. This can also be seen by the fact that I
can remove the AddReceivers function from the notify.Notifier interface
without getting any errors in the rest of the code.
 2021-02-10 14:55:42 +01:00
Niko Köser
b3cad8fe68
refactor(use): simplify useService function 2021-02-10 14:52:09 +01:00
Niko Köser
236e66e284
chore(comment): put actual type names into comments 2021-02-10 14:51:32 +01:00
Niko Köser
4ffb7c09cf
chore(comment): add punctuation to function comment 2021-02-10 14:49:25 +01:00
Niko Köser
0d9ba9d696
Merge pull request #30 from prashanthpai/add-plivo-support 
feat(service): add Plivo service
 2021-02-09 13:21:27 +01:00
Prashanth Pai
67b2d011b8 feat(service): Add Plivo service 
Added support for Plivo as a backend service with unit tests and
documentation.

Signed-off-by: Prashanth Pai <mail@ppai.me>
 2021-02-09 09:30:52 +05:30
kodiakhq[bot]
77cea7b546
build(deps): bump github.com/bwmarrin/discordgo from 0.23.1 to 0.23.2 (#37) 
build(deps): bump github.com/bwmarrin/discordgo from 0.23.1 to 0.23.2
 2021-02-08 22:09:21 +00:00
kodiakhq[bot]
50efc1ac26
Merge branch 'main' into dependabot/go_modules/github.com/bwmarrin/discordgo-0.23.2 2021-02-08 22:07:28 +00:00
kodiakhq[bot]
484fe0be30
build(deps): bump actions/cache from v2 to v2.1.4 (#36) 
build(deps): bump actions/cache from v2 to v2.1.4
 2021-02-08 22:07:15 +00:00
Niko Köser
86507cdd02
Merge branch 'main' into dependabot/go_modules/github.com/bwmarrin/discordgo-0.23.2 2021-02-08 23:07:05 +01:00
Niko Köser
18442f1801
Merge branch 'main' into dependabot/github_actions/actions/cache-v2.1.4 2021-02-08 23:05:16 +01:00
Niko Köser
2a1ed66134
ci(deps): change dependabot label 2021-02-08 23:04:23 +01:00
dependabot[bot]
f3b41cfd04
build(deps): bump github.com/bwmarrin/discordgo from 0.23.1 to 0.23.2 
Bumps [github.com/bwmarrin/discordgo](https://github.com/bwmarrin/discordgo) from 0.23.1 to 0.23.2.
- [Release notes](https://github.com/bwmarrin/discordgo/releases)
- [Commits](https://github.com/bwmarrin/discordgo/compare/v0.23.1...v0.23.2)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-02-08 22:00:10 +00:00
dependabot[bot]
2c0aaa4b1d
build(deps): bump actions/cache from v2 to v2.1.4 
Bumps [actions/cache](https://github.com/actions/cache) from v2 to v2.1.4.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2...26968a09c0ea4f3e233fdddbafd1166051a095f6)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-02-08 21:59:48 +00:00
Niko Köser
a7c87c3e53
Merge pull request #17 from nikoksr/build/add-basic-ci 
build: add build helpers and basic CI
 2021-02-08 22:59:17 +01:00
Niko Köser
8da6b18f0d
Merge branch 'main' into build/add-basic-ci 2021-02-08 22:58:41 +01:00
Niko Köser
fd894832c7
Merge pull request #35 from nikoksr/refactor/apply-golangci-lint-changes 
refactor(lint): remove unnecessary new-lines
 2021-02-08 22:57:42 +01:00
Niko Köser
cb4125a4c1
refactor(lint): remove unnecessary new-lines 2021-02-08 22:55:57 +01:00
Niko Köser
21f787893a
Merge branch 'main' into build/add-basic-ci 2021-02-08 22:51:39 +01:00
Niko Köser
0fc65d5e3b
Merge pull request #14 from KrishanBhalla/feature/TwitterService 
feat(service): Add Twitter service
 2021-02-08 13:24:12 +01:00
KrishanBhalla
2c1e57417d
Update service/twitter/twitter.go 
Co-authored-by: Niko Köser <koeserniko@gmail.com>
 2021-02-08 08:28:30 +00:00
Niko Köser
3af97f8143
Merge branch 'main' into feature/TwitterService 2021-02-07 12:12:26 +01:00
Niko Köser
b7a214b523
Merge branch 'main' into build/add-basic-ci 2021-02-07 12:12:21 +01:00
Niko Köser
04cf3c11bc
Merge pull request #33 from pkwong4321/main 
fix(service):  Fix chat-id parsing in AddReceivers function
 2021-02-07 11:58:16 +01:00
Niko Köser
1cd736543e
Merge branch 'main' into main 2021-02-07 11:54:51 +01:00
Niko Köser
29b64fec77
Merge pull request #32 from prashanthpai/doc-fix-use-services 
docs(readme): Fix UseService usage
 2021-02-07 11:54:37 +01:00
Patrick Kwong
011cd2a766 Fix AddReceivers 2021-02-07 00:05:28 +08:00
Prashanth Pai
224b8a7b80 docs(readme): Fix UseService usage 
The `UseService` has been renamed to `UseServices`.

Signed-off-by: Prashanth Pai <mail@ppai.me>
 2021-02-06 14:50:21 +05:30
Niko Köser
2bda7f99bf
Merge branch 'main' into feature/TwitterService 2021-02-05 14:37:35 +01:00
Niko Köser
9c52d50fa2
Merge branch 'main' into build/add-basic-ci 2021-02-05 14:37:25 +01:00
Niko Köser
d6bfd2e9e7
Merge pull request #23 from Karitham/variadic-param-services 
feat(service): Notify.UseService now uses variadic arguments
 2021-02-05 14:36:03 +01:00
PL Pery
5f17225503
rename: Notify.UseService to Notify.UseServices 
Co-authored-by: Niko Köser <koeserniko@gmail.com>
 2021-02-05 14:24:31 +01:00
Niko Köser
45feb79eb6
Update go.sum 2021-02-05 09:24:58 +01:00
Niko Köser
a634506f6b
Update go.mod 2021-02-05 09:24:19 +01:00
Niko Köser
342243c659
Merge branch 'main' into feature/TwitterService 2021-02-05 09:17:10 +01:00
karitham
04dce61a01 fix miss-spell & run gofmt -s 2021-02-02 22:07:30 +01:00
karitham
f3c95c504a UseService now accepts multiple parameters 2021-02-02 22:03:42 +01:00
Niko Köser
49cf64c8c8
Merge branch 'main' into build/add-basic-ci 2021-02-02 18:34:23 +01:00
Niko Köser
d6d3ed15d3
Merge pull request #20 from KrishanBhalla/feature/PushBullet 
feat(service): AddPushbullet service
 2021-02-02 10:00:52 +01:00
KrishanBhalla
21736b6110 Removed whitespace 2021-02-01 19:48:33 +00:00
KrishanBhalla
e6d5c854d9
Update service/pushbullet/pushbullet.go 
Co-authored-by: Niko Köser <koeserniko@gmail.com>
 2021-02-01 19:22:06 +00:00
KrishanBhalla
4f6011a81a
Update pushbullet.go 2021-02-01 19:21:52 +00:00
KrishanBhalla
c159e97d01
Update service/pushbullet/usage.md 
Co-authored-by: Niko Köser <koeserniko@gmail.com>
 2021-02-01 19:20:53 +00:00
KrishanBhalla
45a066b5b0
Update service/pushbullet/usage.md 
Co-authored-by: Niko Köser <koeserniko@gmail.com>
 2021-02-01 19:20:41 +00:00
KrishanBhalla
8aa7416c8d
Update service/pushbullet/sms.go 
Co-authored-by: Niko Köser <koeserniko@gmail.com>
 2021-02-01 19:20:30 +00:00
KrishanBhalla
2568de75c0
Update service/pushbullet/pushbullet.go 
Co-authored-by: Niko Köser <koeserniko@gmail.com>
 2021-02-01 19:20:24 +00:00
KrishanBhalla
4383388f28
Update service/pushbullet/pushbullet.go 
Co-authored-by: Niko Köser <koeserniko@gmail.com>
 2021-02-01 19:20:19 +00:00
KrishanBhalla
ccaf02c352 patch: Removed validation from pushbullet.go AddReceivers 2021-02-01 17:32:04 +00:00
KrishanBhalla
d7489d5022 patch: Renamed PushBullet to Pushbullet 2021-02-01 17:29:48 +00:00