go/oauth2-proxy
1
0
Fork 0
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git synced 2025-10-30 23:47:52 +02:00
Code Issues Releases Activity

Merge pull request #925 from oauth2-proxy/fix-basic-auth

Browse Source 
Fix basic auth legacy header conversion
This commit is contained in:
Joel Speed
2020-11-19 20:14:44 +00:00
committed by GitHub
parent eb07005a5c 482cd32a17
commit 8bed7aafbd
3 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -43,6 +43,7 @@
## Changes since v6.1.1
- [#925](https://github.com/oauth2-proxy/oauth2-rpoxy/pull/925) Fix basic auth legacy header conversion (@JoelSpeed)
- [#916](https://github.com/oauth2-proxy/oauth2-rpoxy/pull/916) Add AlphaOptions struct to prepare for alpha config loading (@JoelSpeed)
- [#923](https://github.com/oauth2-proxy/oauth2-proxy/pull/923) Support TLS 1.3 (@aajisaka)
- [#918](https://github.com/oauth2-proxy/oauth2-proxy/pull/918) Fix log header output (@JoelSpeed)

3
pkg/apis/options/legacy_options.go
View File

@@ -232,7 +232,8 @@ func getBasicAuthHeader(preferEmailToUser bool, basicAuthPassword string) Header
Values: []HeaderValue{
{
ClaimSource: &ClaimSource{
Claim: claim,
Claim: claim,
Prefix: "Basic ",
BasicAuthPassword: &SecretSource{
Value: []byte(base64.StdEncoding.EncodeToString([]byte(basicAuthPassword))),
},

6
pkg/apis/options/legacy_options_test.go
View File

@@ -329,7 +329,8 @@ var _ = Describe("Legacy Options", func() {
Values: []HeaderValue{
{
ClaimSource: &ClaimSource{
Claim: "user",
Claim: "user",
Prefix: "Basic ",
BasicAuthPassword: &SecretSource{
Value: []byte(base64.StdEncoding.EncodeToString([]byte(basicAuthSecret))),
},
@@ -368,7 +369,8 @@ var _ = Describe("Legacy Options", func() {
Values: []HeaderValue{
{
ClaimSource: &ClaimSource{
Claim: "email",
Claim: "email",
Prefix: "Basic ",
BasicAuthPassword: &SecretSource{
Value: []byte(base64.StdEncoding.EncodeToString([]byte(basicAuthSecret))),
},