go/oauth2-proxy
1
0
Fork 0
mirror of https://github.com/oauth2-proxy/oauth2-proxy.git synced 2025-03-27 22:01:28 +02:00
Code Issues Releases Activity

De-duplicate code in GetLoginURL of in logingov provider

Browse Source 
Also add unit test to ensure logingov specific logic is applied.
This commit is contained in:
Alexander Block 2020-09-14 13:55:47 +02:00
parent fde09bea4e
commit 9a64e67d5b
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
providers/logingov.go
View File

@ -225,19 +225,11 @@ func (p *LoginGovProvider) Redeem(ctx context.Context, redirectURL, code string)
// GetLoginURL overrides GetLoginURL to add login.gov parameters
func (p *LoginGovProvider) GetLoginURL(redirectURI, state string) string {
a := *p.LoginURL
params, _ := url.ParseQuery(a.RawQuery)
params.Set("redirect_uri", redirectURI)
params.Set("approval_prompt", p.ApprovalPrompt)
params.Add("scope", p.Scope)
params.Set("client_id", p.ClientID)
params.Set("response_type", "code")
params.Add("state", state)
acr := p.AcrValues
if acr == "" {
acr = "http://idmanagement.gov/ns/assurance/loa/1"
a, params := DefaultGetLoginURL(p.ProviderData, redirectURI, state)
if p.AcrValues == "" {
acr := "http://idmanagement.gov/ns/assurance/loa/1"
params.Add("acr_values", acr)
}
params.Add("acr_values", acr)
params.Add("nonce", p.Nonce)
a.RawQuery = params.Encode()
return a.String()

7
providers/logingov_test.go
View File

@ -289,3 +289,10 @@ func TestLoginGovProviderBadNonce(t *testing.T) {
// The "badfakenonce" in the idtoken above should cause this to error out
assert.Error(t, err)
}
func TestLoginGovProviderGetLoginURL(t *testing.T) {
p, _, _ := newLoginGovProvider()
result := p.GetLoginURL("http://redirect/", "")
assert.Contains(t, result, "acr_values="+url.QueryEscape("http://idmanagement.gov/ns/assurance/loa/1"))
assert.Contains(t, result, "nonce=fakenonce")
}