1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00

Remove options field from Jaeger exporter (#1808)

The initialization options of the exporter are not used after the
Exporter is created. Stop saving them in a field.
This commit is contained in:
Tyler Yahn
2021-04-14 15:23:44 +00:00
committed by GitHub
parent 6db20e008d
commit 0489060896
+1 -3
View File
@@ -117,7 +117,6 @@ func NewRawExporter(endpointOption EndpointOption, opts ...Option) (*Exporter, e
e := &Exporter{
uploader: uploader,
o: o,
defaultServiceName: defaultServiceName,
}
bundler := bundler.NewBundler((*sdktrace.SpanSnapshot)(nil), func(bundle interface{}) {
@@ -158,7 +157,7 @@ func NewExportPipeline(endpointOption EndpointOption, opts ...Option) (trace.Tra
return nil, nil, err
}
pOpts := append(exporter.o.TracerProviderOptions, sdktrace.WithSyncer(exporter))
pOpts := append(o.TracerProviderOptions, sdktrace.WithSyncer(exporter))
tp := sdktrace.NewTracerProvider(pOpts...)
return tp, exporter.Flush, nil
}
@@ -180,7 +179,6 @@ func InstallNewPipeline(endpointOption EndpointOption, opts ...Option) (func(),
type Exporter struct {
bundler *bundler.Bundler
uploader batchUploader
o options
stoppedMu sync.RWMutex
stopped bool