go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00
Code Issues Releases Activity

stdoutmetric observ: skip metric work when instruments are disabled (#7868)

Browse Source 
Avoid unnecessary metric work in stdoutmetric exporter observability
paths by Enabled() checks of metrics.

Benchmark
BenchmarkExportMetrics
Before: ~354 ns/op, 216 B/op, 2 allocs/op (error path)
After: ~55 ns/op, 0 B/op, 0 allocs/op

This change is internal and I think does not need to be mentioned in the
changelog.
Issue: #7800

Co-authored-by: Damien Mathieu <42@dmathieu.com>
This commit is contained in:
Nesterov Yehor
2026-02-04 11:20:38 +01:00
committed by GitHub
parent f98bb30fe0
commit 1ee4a4126d
1 changed files with 44 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
exporters/stdout/stdoutmetric/internal/observ/instrumentation.go
+44 -13
View File
@@ -138,7 +138,11 @@ func NewInstrumentation(id int64) (*Instrumentation, error) {
// ExportOp that needs to be ended with End() when the export operation completes.
func (i *Instrumentation) ExportMetrics(ctx context.Context, count int64) ExportOp {
start := time.Now()
i.inflight.Add(ctx, count, i.addOpts...)
// Avoid work when observability is disabled.
if i.inflight.Enabled(ctx) {
i.inflight.Add(ctx, count, i.addOpts...)
}
return ExportOp{
ctx: ctx,
start: start,
@@ -160,30 +164,57 @@ type ExportOp struct {
// The err parameter indicates whether the operation failed. If err is not nil,
// it is added to metrics as attribute.
func (e ExportOp) End(err error) {
durationSeconds := time.Since(e.start).Seconds()
e.inst.inflight.Add(e.ctx, -e.nTraces, e.inst.addOpts...)
inflightEnabled := e.inst.inflight.Enabled(e.ctx)
exportedEnabled := e.inst.exported.Enabled(e.ctx)
durationEnabled := e.inst.duration.Enabled(e.ctx)
if !inflightEnabled && !exportedEnabled && !durationEnabled {
return
}
var durationSeconds float64
if durationEnabled {
durationSeconds = time.Since(e.start).Seconds()
}
if inflightEnabled {
e.inst.inflight.Add(e.ctx, -e.nTraces, e.inst.addOpts...)
}
if err == nil { // short circuit in case of success to avoid allocations
e.inst.exported.Inst().Add(e.ctx, e.nTraces, e.inst.addOpts...)
e.inst.duration.Inst().Record(e.ctx, durationSeconds, e.inst.recordOpts...)
if exportedEnabled {
e.inst.exported.Inst().Add(e.ctx, e.nTraces, e.inst.addOpts...)
}
if durationEnabled {
e.inst.duration.Inst().Record(e.ctx, durationSeconds, e.inst.recordOpts...)
}
return
}
if !exportedEnabled && !durationEnabled {
return
}
attrs := get[attribute.KeyValue](measureAttrsPool)
addOpts := get[metric.AddOption](addOptsPool)
recordOpts := get[metric.RecordOption](recordOptsPool)
defer func() {
put(measureAttrsPool, attrs)
put(addOptsPool, addOpts)
put(recordOptsPool, recordOpts)
}()
*attrs = append(*attrs, e.inst.attrs...)
*attrs = append(*attrs, semconv.ErrorType(err))
set := attribute.NewSet(*attrs...)
attrOpt := metric.WithAttributeSet(set)
*addOpts = append(*addOpts, attrOpt)
*recordOpts = append(*recordOpts, attrOpt)
e.inst.exported.Inst().Add(e.ctx, e.nTraces, *addOpts...)
e.inst.duration.Inst().Record(e.ctx, durationSeconds, *recordOpts...)
if exportedEnabled {
addOpts := get[metric.AddOption](addOptsPool)
defer put(addOptsPool, addOpts)
*addOpts = append(*addOpts, attrOpt)
e.inst.exported.Inst().Add(e.ctx, e.nTraces, *addOpts...)
}
if durationEnabled {
recordOpts := get[metric.RecordOption](recordOptsPool)
defer put(recordOptsPool, recordOpts)
*recordOpts = append(*recordOpts, attrOpt)
e.inst.duration.Inst().Record(e.ctx, durationSeconds, *recordOpts...)
}
}