go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-09-16 09:26:25 +02:00
Code Issues Releases Activity

Make timestamps sequential in lastvalue agg check (#1579)

Browse Source 
* Make timestamps sequential in lastvalue agg check

* Set PR number in changelog

* Fix location of sleep

The lastvalue timestamp is set on update. Correct the location of the
sleep to bridge the update of the two different aggregators.
This commit is contained in:
Tyler Yahn
2021-02-25 07:20:38 -08:00
committed by GitHub
parent 37688ef676
commit 43886e52f3
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -48,6 +48,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The sequential timing check of timestamps in the stdout exporter are now setup explicitly to be sequential (#1571). (#1572)
- Windows build of Jaeger tests now compiles with OS specific functions (#1576). (#1577)
- The sequential timing check of timestamps of go.opentelemetry.io/otel/sdk/metric/aggregator/lastvalue are now setup explicitly to be sequential (#1578). (#1579)
## [0.17.0] - 2020-02-12

2
sdk/metric/aggregator/lastvalue/lastvalue_test.go
View File

@@ -101,6 +101,8 @@ func TestLastValueMerge(t *testing.T) {
first1.AddNumber(profile.NumberKind, first2)
aggregatortest.CheckedUpdate(t, agg1, first1, descriptor)
// Ensure these should not have the same timestamp.
time.Sleep(time.Nanosecond)
aggregatortest.CheckedUpdate(t, agg2, first2, descriptor)
require.NoError(t, agg1.SynchronizedMove(ckpt1, descriptor))