1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-09-16 09:26:25 +02:00

Deprecated the bridge/opencensus/utils package (#2166)

* Deprecated the bridge/opencensus/utils package

* Update PR number in CHANGELOG.md

* Apply suggestions from code review
This commit is contained in:
Tyler Yahn
2021-08-09 11:33:25 -07:00
committed by GitHub
parent b1d1d52959
commit a3d4ff5c0c
4 changed files with 28 additions and 2 deletions

View File

@@ -16,6 +16,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Deprecated
- The `go.opentelemetry.io/otel/bridge/opencensus/utils` package is deprecated.
All functionality from this package now exists in the `go.opentelemetry.io/otel/bridge/opencensus` package.
The functions from that package should be used instead. (#2166)
### Removed
- Removed metrics test package `go.opentelemetry.io/otel/sdk/export/metric/metrictest`. (#2105)

View File

@@ -18,6 +18,8 @@ import (
octrace "go.opencensus.io/trace"
"go.opentelemetry.io/otel/bridge/opencensus/internal"
"go.opentelemetry.io/otel/bridge/opencensus/internal/oc2otel"
"go.opentelemetry.io/otel/bridge/opencensus/internal/otel2oc"
"go.opentelemetry.io/otel/trace"
)
@@ -27,3 +29,16 @@ import (
func NewTracer(tracer trace.Tracer) octrace.Tracer {
return internal.NewTracer(tracer)
}
// OTelSpanContextToOC converts from an OpenTelemetry SpanContext to an
// OpenCensus SpanContext, and handles any incompatibilities with the global
// error handler.
func OTelSpanContextToOC(sc trace.SpanContext) octrace.SpanContext {
return otel2oc.SpanContext(sc)
}
// OCSpanContextToOTel converts from an OpenCensus SpanContext to an
// OpenTelemetry SpanContext.
func OCSpanContextToOTel(sc octrace.SpanContext) trace.SpanContext {
return oc2otel.SpanContext(sc)
}

View File

@@ -23,7 +23,6 @@ import (
"go.opentelemetry.io/otel/attribute"
ocbridge "go.opentelemetry.io/otel/bridge/opencensus"
"go.opentelemetry.io/otel/bridge/opencensus/internal"
"go.opentelemetry.io/otel/bridge/opencensus/utils"
"go.opentelemetry.io/otel/codes"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
"go.opentelemetry.io/otel/sdk/trace/tracetest"
@@ -104,7 +103,7 @@ func TestStartSpanWithRemoteParent(t *testing.T) {
ctx := context.Background()
ctx, parent := tracer.Start(ctx, "OpenTelemetrySpan1")
_, span := octrace.StartSpanWithRemoteParent(ctx, "OpenCensusSpan", utils.OTelSpanContextToOC(parent.SpanContext()))
_, span := octrace.StartSpanWithRemoteParent(ctx, "OpenCensusSpan", ocbridge.OTelSpanContextToOC(parent.SpanContext()))
span.End()
spans := sr.Ended()

View File

@@ -12,6 +12,10 @@
// See the License for the specific language governing permissions and
// limitations under the License.
// Package utils provides utilities for the OpenCensus bridge.
//
// Deprecated: Use the equivalent functions from the bridge/opencensus package
// instead.
package utils // import "go.opentelemetry.io/otel/bridge/opencensus/utils"
import (
@@ -25,12 +29,16 @@ import (
// OTelSpanContextToOC converts from an OpenTelemetry SpanContext to an
// OpenCensus SpanContext, and handles any incompatibilities with the global
// error handler.
//
// Deprecated: Use OTelSpanContextToOC from bridge/opencensus instead.
func OTelSpanContextToOC(sc trace.SpanContext) octrace.SpanContext {
return otel2oc.SpanContext(sc)
}
// OCSpanContextToOTel converts from an OpenCensus SpanContext to an
// OpenTelemetry SpanContext.
//
// Deprecated: Use OCSpanContextToOTel from bridge/opencensus instead.
func OCSpanContextToOTel(sc octrace.SpanContext) trace.SpanContext {
return oc2otel.SpanContext(sc)
}