go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-02-15 13:53:24 +02:00
Code Issues Releases Activity

use global handler for span export err in otlp (#946)

Browse Source 
Currently there is no way to report errors using the global handlers for spans in the OTLP exporter, this change fixes that. Errors for the metrics exporter are already handled by the global handler.

Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
This commit is contained in:
alrex 2020-07-21 11:18:15 -07:00 committed by GitHub
parent f6b51df544
commit c8b657eb6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
exporters/otlp/otlp.go
View File

@ -28,6 +28,7 @@ import (
colmetricpb "go.opentelemetry.io/otel/internal/opentelemetry-proto-gen/collector/metrics/v1"
coltracepb "go.opentelemetry.io/otel/internal/opentelemetry-proto-gen/collector/trace/v1"
"go.opentelemetry.io/otel/api/global"
"go.opentelemetry.io/otel/api/metric"
"go.opentelemetry.io/otel/exporters/otlp/internal/transform"
metricsdk "go.opentelemetry.io/otel/sdk/export/metric"
@ -301,6 +302,7 @@ func (e *Exporter) uploadTraces(ctx context.Context, sdl []*tracesdk.SpanData) {
e.senderMu.Unlock()
if err != nil {
e.setStateDisconnected(err)
global.Handle(err)
}
}
}