go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-25 22:41:46 +02:00
Code Issues Releases Activity

Fix component name for stdouttrace (#7195)

Browse Source 
The STDOUT exporter not a standardized type. Use the [semantic
convention recommendation of a "language-defined name of the
type"](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/registry/attributes/otel.md#otel-component-type).
This commit is contained in:
Tyler Yahn
2025-08-17 08:46:13 -07:00
committed by GitHub
parent ee6d57b7cf
commit cdd18ab3a1
3 changed files with 41 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -71,6 +71,7 @@ The next release will require at least [Go 1.24].
### Fixed
- Fix `go.opentelemetry.io/otel/exporters/prometheus` to deduplicate suffixes if already present in metric name when UTF8 is enabled. (#7088)
- Fix the `go.opentelemetry.io/otel/exporters/stdout/stdouttrace` self-observability component type and name. (#7195)
<!-- Released section -->
<!-- Don't change this section unless doing release -->

6
exporters/stdout/stdouttrace/trace.go
View File

@@ -23,8 +23,10 @@ import (
"go.opentelemetry.io/otel/semconv/v1.36.0/otelconv"
)
// otelComponentType is a name identifying the type of the OpenTelemetry component.
const otelComponentType = "stdout_trace_exporter"
// otelComponentType is a name identifying the type of the OpenTelemetry
// component. It is not a standardized OTel component type, so it uses the
// Go package prefixed type name to ensure uniqueness and identity.
const otelComponentType = "go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter"
var zeroTime time.Time

48
exporters/stdout/stdouttrace/trace_test.go
View File

@@ -286,8 +286,12 @@ func TestSelfObservability(t *testing.T) {
DataPoints: []metricdata.DataPoint[int64]{
{
Attributes: attribute.NewSet(
semconv.OTelComponentName("stdout_trace_exporter/0"),
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
semconv.OTelComponentName(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/0",
),
semconv.OTelComponentTypeKey.String(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
),
),
Value: 0,
},
@@ -305,8 +309,12 @@ func TestSelfObservability(t *testing.T) {
DataPoints: []metricdata.DataPoint[int64]{
{
Attributes: attribute.NewSet(
semconv.OTelComponentName("stdout_trace_exporter/0"),
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
semconv.OTelComponentName(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/0",
),
semconv.OTelComponentTypeKey.String(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
),
),
Value: 2,
},
@@ -323,8 +331,12 @@ func TestSelfObservability(t *testing.T) {
DataPoints: []metricdata.HistogramDataPoint[float64]{
{
Attributes: attribute.NewSet(
semconv.OTelComponentName("stdout_trace_exporter/0"),
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
semconv.OTelComponentName(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/0",
),
semconv.OTelComponentTypeKey.String(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
),
),
},
},
@@ -368,8 +380,12 @@ func TestSelfObservability(t *testing.T) {
DataPoints: []metricdata.DataPoint[int64]{
{
Attributes: attribute.NewSet(
semconv.OTelComponentName("stdout_trace_exporter/1"),
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
semconv.OTelComponentName(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/1",
),
semconv.OTelComponentTypeKey.String(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
),
),
Value: 0,
},
@@ -387,8 +403,12 @@ func TestSelfObservability(t *testing.T) {
DataPoints: []metricdata.DataPoint[int64]{
{
Attributes: attribute.NewSet(
semconv.OTelComponentName("stdout_trace_exporter/1"),
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
semconv.OTelComponentName(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/1",
),
semconv.OTelComponentTypeKey.String(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
),
semconv.ErrorType(context.Canceled),
),
Value: 2,
@@ -406,8 +426,12 @@ func TestSelfObservability(t *testing.T) {
DataPoints: []metricdata.HistogramDataPoint[float64]{
{
Attributes: attribute.NewSet(
semconv.OTelComponentName("stdout_trace_exporter/1"),
semconv.OTelComponentTypeKey.String("stdout_trace_exporter"),
semconv.OTelComponentName(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter/1",
),
semconv.OTelComponentTypeKey.String(
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace.Exporter",
),
semconv.ErrorType(context.Canceled),
),
},