1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00

address feedback from #7478 (#7718)

Addresses
https://github.com/open-telemetry/opentelemetry-go/pull/7478#pullrequestreview-3583818326,
which was left after the PR merged.
This commit is contained in:
David Ashpole
2025-12-16 13:01:43 -05:00
committed by GitHub
parent 279f1453fe
commit fa89e4c5ed
+3 -3
View File
@@ -18,7 +18,7 @@ type lastValuePoint[N int64 | float64] struct {
res FilteredExemplarReservoir[N]
}
// lastValue summarizes a set of measurements as the last one made.
// lastValueMap summarizes a set of measurements as the last one made.
type lastValueMap[N int64 | float64] struct {
newRes func(attribute.Set) FilteredExemplarReservoir[N]
values limitedSyncMap
@@ -98,7 +98,7 @@ func (s *deltaLastValue[N]) copyAndClearDpts(
t time.Time,
) int {
// Ignore if dest is not a metricdata.Gauge. The chance for memory reuse of
// the lastValuePoints is missed (better luck next time).
// the DataPoints is missed (better luck next time).
gData, _ := (*dest).(metricdata.Gauge[N])
// delta always clears values on collection
readIdx := s.hcwg.swapHotAndWait()
@@ -122,7 +122,7 @@ func (s *deltaLastValue[N]) copyAndClearDpts(
// Do not report stale values.
s.hotColdValMap[readIdx].values.Clear()
*dest = gData
return n
return i
}
// cumulativeLastValue summarizes a set of measurements as the last one made.