1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00
Commit Graph

635 Commits

Author SHA1 Message Date
Vladimir Mihailenco 7ebd7b5ffa Fix BatchSpanProcessor.Shutdown to wait until all spans are processed (#766)
* Fix BatchSpanProcessor.Shutdown to wait until all spans are processed

Currently it exits too soon - before drainQueue is finished

* Check bsp.stopCh to reliably drop span when batcher is stopped

* Enable tests

* Always use WithBlocking

Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
2020-06-09 15:20:48 -07:00
Tyler Yahn c58680a772 Merge pull request #807 from dcwangmit01/fix-otlp-example
Fixed OTLP example's accidental early close of exporter
2020-06-09 14:04:38 -07:00
David C Wang ce49579d66 Fixed OTLP example's accidental early close of exporter
* The exp.Stop() as argument to handleErr is getting executed
  immediately.  Wrap this with an anonymous func so that this
  argument is executed when the defer statement is activated.
* From the "Tour of Go" docs on Defer: "The deferred call's arguments
  are evaluated immediately, but the function call is not executed
  until the surrounding function returns."
2020-06-09 20:36:17 +00:00
Tyler Yahn a98bb979df Update Tracer API with instrumentation version (#802)
* Update Tracer API with instrumentation version

Add option to the `Provider.Tracer` method to specify the
instrumentation version.

Update the global, noop, opentracing bridge, and default SDK
implementations.

This does not propagate the instrumentation library version to the
exported span. That is left for a follow-on PR.

* Revert trace_test.go

This is for the next PR.

* Update SDK to include version for default instrumentation

If the instrumentation library name is empty and the default
instrumentation is uses, include the SDK version.

* Update comments and documentation

* Remove default instrumentation version
2020-06-09 11:47:54 -07:00
Joshua MacDonald 9401bd9cda Remove Context arguments from Aggregator.Checkpoint and Integrator.Process (#803)
* Typo

* Swap order of ddsketch.New for consistency w/ histogram.New

* Remove Integrator.Process ctx argument

* Remove Aggregator.Checkpoint ctx argument

* Revert bugfix
2020-06-09 11:00:50 -07:00
Tyler Yahn a43367a7a4 Merge pull request #790 from vmingchen/otlp-example
Add example that uses OTLP and the collector
2020-06-04 08:40:09 -07:00
Tyler Yahn 9318a73297 Run precommit 2020-06-04 08:29:10 -07:00
Tyler Yahn cafdc869ea Merge branch 'master' into otlp-example 2020-06-04 08:19:57 -07:00
Tyler Yahn eb14b395bb Merge pull request #791 from MrAlias/err-handle
Update Error Handling
2020-06-02 13:44:20 -07:00
Tyler Yahn 5fa286d44d Update internal/metric/async.go
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2020-06-02 13:40:20 -07:00
Tyler Yahn 50f0f85c79 Discard error in trace testing 2020-06-02 13:33:19 -07:00
Tyler Yahn e73d119d6c Update concurrency support in test Handlers 2020-06-02 13:03:02 -07:00
Tyler Yahn 8c5b1663a2 Fix push_test.go
Add test handler
2020-06-02 12:50:34 -07:00
Tyler Yahn 2efa30feec Error on span name set with uninitialized 2020-06-02 12:43:01 -07:00
wtong98 f86491e1ec Add replace directive to example go.mod 2020-06-02 14:31:30 -05:00
Tyler Yahn 3e95c9c78e Update error handling exporters to use global.Handle 2020-06-02 12:30:55 -07:00
wtong98 cffb360324 Merge branch 'master' into otlp-example.
Sync the local branch with upstream changes
2020-06-02 14:28:46 -05:00
Tyler Yahn 0cb2666b7c Update internal metric testing with global.Handle 2020-06-02 12:27:55 -07:00
Tyler Yahn 0b928ed0a1 Update metric SDK to use oterror.Handler 2020-06-02 12:26:25 -07:00
wtong98 4ac30219ae Fix go.mod dependencies 2020-06-02 14:11:23 -05:00
Tyler Yahn cff4ddf888 Merge pull request #777 from MrAlias/otlp
Add gRPC Default Service Config To OTLP Exporter
2020-06-02 10:45:45 -07:00
Tyler Yahn 289f372308 Merge branch 'master' into otlp 2020-06-02 10:41:44 -07:00
Tyler Yahn 1ed9058802 Merge pull request #788 from Aneurysm9/OTG-786
Ensure zipkin exporter reads and closes response body
2020-06-02 09:01:13 -07:00
Anthony J Mirabella 0e8fb1cb4f Ensure zipkin exporter reads and closes response body 2020-06-02 11:46:34 -04:00
Tyler Yahn d9b6d9c05d Merge pull request #778 from MrAlias/oterror
Add oterror package and implementation in api/global
2020-06-02 08:14:30 -07:00
Tyler Yahn af0c2d608c Merge branch 'master' into oterror 2020-06-02 08:08:08 -07:00
Tyler Yahn 3ee928a67f Merge pull request #784 from Aneurysm9/OTG-499
Add options to specify propagators for httptrace and grpctrace
2020-06-01 11:59:00 -07:00
Tyler Yahn c50803d259 Update global Handler delegate to atomic value 2020-06-01 11:50:35 -07:00
wtong98 70d737b128 Split OTLP README to own directory 2020-06-01 13:27:23 -05:00
Anthony J Mirabella be093d9d4b Add license header to httptrace_test.go 2020-06-01 14:08:32 -04:00
Anthony J Mirabella a5c21051c8 Add option to specify propagators to use with grpctrace Extract and Inject 2020-06-01 13:56:53 -04:00
Anthony J Mirabella aea2257ee4 Add option to specify propagators to use with httptrace Extract and Inject 2020-06-01 13:47:43 -04:00
Tyler Yahn 57e65fe7f8 Fix tests
Old tests were masking the underlying function they were trying to test.
2020-06-01 10:38:05 -07:00
Tyler Yahn 7967e53fd9 Fix spelling in handler_test.go 2020-06-01 09:28:27 -07:00
Tyler Yahn 528fde0bef Merge branch 'master' into oterror 2020-06-01 09:21:58 -07:00
Tyler Yahn 823703a6bb Merge pull request #782 from tensorchen/remove_dup_key
using api/standard keys instead of custom keys
2020-06-01 09:17:26 -07:00
Tyler Yahn 9c6c712c54 Merge branch 'master' into otlp 2020-06-01 09:15:29 -07:00
Tyler Yahn e70d9092b1 Update global Handle
Move delegate call outside of lock to avoid deadlock.
2020-06-01 09:13:30 -07:00
Tyler Yahn f736b8b0e2 Merge remote-tracking branch 'upstream/master' into oterror 2020-06-01 09:12:10 -07:00
Tyler Yahn 0c3127c27e Update README.md with batcher comment 2020-06-01 09:09:26 -07:00
wtong98 de094be4fc Touch up details 2020-06-01 08:41:57 -05:00
tensorchen 1f9a66f1f9 using api/standard keys instead of custom keys
remove httptrace dup keys

format codestyle
2020-06-01 01:03:03 +08:00
Joshua MacDonald 86a10268b8 Minor cleanups in sdk/metric/aggregator (#781)
* Typo

* Swap order of ddsketch.New for consistency w/ histogram.New
2020-05-30 20:16:40 -07:00
Tyler Yahn 07d5f77749 Rename plugin directory to instrumentation (#779)
* Rename plugin directory to instrumentation

As per https://github.com/open-telemetry/opentelemetry-specification/pull/539

* Update package paths

* Fix tracer names in othttp instrumentation
2020-05-30 14:53:32 -07:00
Tyler Yahn 61f51b4f0e Update Handler comments 2020-05-29 15:53:42 -07:00
Tyler Yahn ec6512f656 Lint 2020-05-29 15:49:58 -07:00
Tyler Yahn 559606c419 Add global handler test 2020-05-29 15:34:53 -07:00
Tyler Yahn 39b4eb5806 Add global handler 2020-05-29 13:30:11 -07:00
Tyler Yahn 8e70cfb5c4 Split global.go 2020-05-29 13:04:55 -07:00
Tyler Yahn 7cccff7944 Add api/oterror package 2020-05-29 12:57:04 -07:00