1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2026-06-03 18:35:08 +02:00
Commit Graph

64 Commits

Author SHA1 Message Date
Aaron Clawson cf93d0db65 Add @dashpole (David Ashpole) as a maintainer (#4830)
* Add David Ashpole as a maintainer

* Sort the maintiners by surname.

Co-authored-by: Robert Pająk <pellared@hotmail.com>

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
2024-01-17 16:30:45 -06:00
Liz Fong-Jones 19622d3855 chore(docs): explicitly mark lizthegrey emeritus (#4822)
* chore(docs): explicitly mark lizthegrey emeritus

Follow-on to open-telemetry/opentelemetry-go#1745 - we didn't have an emeritus section then, but we do now as of open-telemetry/opentelemetry-go#2888.

* lint

* sort in order of date
2024-01-12 07:12:25 -08:00
Robert Pająk 8e756513a6 sdk/metric: Record measurements when context is done (#4671) 2023-12-15 19:14:16 +01:00
Michael Blum ca2b22b3be Document PR commits preference in CONTRIBUTING.md (#4704) 2023-11-13 08:22:34 +01:00
Tyler Yahn d9afe946d4 Document cross-module internal package rule (#4427)
Co-authored-by: Robert Pająk <pellared@hotmail.com>
2023-08-09 15:12:17 -07:00
Robert Pająk fd5284f75c styleguide: tests goroutine leaks and naming (#4348)
* internal/global: Fix goroutine leaks in tests
2023-07-24 09:35:06 +02:00
Aaron Clawson 9c61b56338 Add decision about v2 API (#3968) 2023-06-21 18:15:03 +02:00
Robert Pająk b2246d5865 [chore] Clarify that internal and test packages do not need docs (#4140)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-05-26 08:23:50 -07:00
Anthony Mirabella 0cdd5cecd9 Move @Aneurysm9 to approver (#4137)
* Move @Aneurysm9 to approver

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Remove @Aneurysm9 from CODEOWNERS

---------

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-05-26 08:13:37 -07:00
Anthony Mirabella bcc2af02f4 Add @pellared as maintainer (#4138)
* Add @pellared as maintainer

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Add @pellared as maintainer in CODEOWNERS

---------

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
2023-05-26 07:49:44 -07:00
Robert Pająk ff9fa334c9 [chore] Update documentation guidelines (#4136)
* Simplify documentation guidelines

* Add info how to localy run pkg.go.dev
2023-05-25 08:24:46 -07:00
Charlie Le 8dcabc3ef9 feat(ci): Add codespell to Makefile and GitHub Actions (#3996)
* feat(ci): Add codespell to Makefile and GitHub Actions

This is a followup from
https://github.com/open-telemetry/opentelemetry-go/pull/3980 to add the
automation for checking for code spelling errors to a different PR.

[Codespell][] makes use of the `.codespellrc` file automatically as a config
file for convenience. The configuration file specifies directories and
flags to pass to `codespell`. Codespell also makes use of the
`.codespellignore` file to ignore certain word spellings.

There is a new section in `Makefile` for installing python tooling.
It is similar to how the go tools are installed. It sets up a virtualenv
in `venv `and installs python tooling there if it hasn't been installed
yet.

The new [codespell workflow][] will run in pull requests to annotate
misspelled words. It is set up to only warn the user with annotations in
the pull request if there are typos, but we can fail the pull request as
well if we want to by deleting the [warn_only][] key.

[codespell]: https://github.com/codespell-project/codespell
[codespell workflow]: https://github.com/codespell-project/actions-codespell
[warn_only]: https://github.com/codespell-project/actions-codespell#parameter-only_warn

* Use docker to run python and codespell

Since this is a Go project, having a dependency on python seemed
disconcerting. So, docker is used to create a virtual environment
with a python image and also run the tools that were installed.

* Remove wording on requirement for python

* Apply suggestions from code review

Co-authored-by: Damien Mathieu <42@dmathieu.com>

* Pin versions into requirements.txt

* Pin version in requirements.txt

* Fix typo in license

* Revert typo fix on deleted file

* Update .github/workflows/codespell.yaml

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update codespell.yaml

* Update codespell.yaml

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-05-18 09:06:27 -07:00
Patrice Chalin 1dff818526 [website_docs] Update path to spec, run formatter (#4084)
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
2023-05-15 06:55:29 -07:00
Robert Pająk 4d473d105a [chore] Pin otel-specification hyperlinks (#4033)
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-05-09 08:45:39 -07:00
Joshua MacDonald c5e2799a63 move jmacd to emeritus (#4024)
* move jmacd to emeritus

* Remove @jmacd from CODEOWNERS

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
2023-04-20 10:04:27 -07:00
Charlie Le 1b55281859 docs(typos): Run codespell to fix typos (#3980)
* docs(typos): Run codespell to fix typos

There were a lot of typos through the repository, so I ran
[codespell][], a tool for automatically fixing typos, to fix them.

```console
make codespell
```

There's already a tool called [misspell][] that's supposed to take care
of this, but misspell hasn't been updated for 6 years, and it doesn't
seem to be catching any of the typos that codespell can.

[codespell]: https://github.com/codespell-project/codespell
[misspell]: https://github.com/client9/misspell

* Revert and ignore spelling for Consequentially

* Add GH workflow for codespell

* Revert GH Workflow and Makefile for codespell

Per @pellared, since there's no instructions for setting up codespell,
it was suggested that the changes for setting up a workflow and section
in Makefile include instructions for setting up codespell as well.

* Revert spelling on consequently

---------

Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-04-11 17:28:13 -07:00
Tyler Yahn 9215136863 Update "How to Get PRs Merged" section of CONTRIBUTING.md (#3868)
* Update "How to Get PRs Merged" sec of CONTRIBUTING

* Link to local approvers and maintainers

---------

Co-authored-by: Damien Mathieu <damien.mathieu@elastic.co>
2023-03-17 11:40:22 -07:00
Robert Pająk 9b398a63d7 Update SIG meeting notes URL (#3869)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2023-03-14 09:36:13 -07:00
Damien Mathieu 68aa5984fd update dmathieu's affiliation (#3721) 2023-02-13 07:28:30 -08:00
Damien Mathieu a496d2285d add @dmathieu as an approver (#2908) 2022-05-18 09:21:57 -07:00
Tyler Yahn a0bed80424 Change @paivagustavo to emeritus status (#2888) 2022-05-06 11:06:38 -07:00
Chester Cheung 76bff3fe89 add hanyuancheung as an approver (#2638)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2022-02-25 08:03:15 -08:00
Tyler Yahn bd817df68c Change Options to accept type not pointer (#2558)
* Change trace options to accept type not pointer

Add benchmark to show allocation improvement.

* Update CONTRIBUTING.md guidelines

* Update all Option iface

* Fix grammar in CONTRIBUTING
2022-02-01 15:51:23 -06:00
Sam Xie 24aecc561d Update affiliation for Sam Xie (#2458) 2021-12-15 08:45:53 -06:00
Tyler Yahn b42ab7d2b4 Make MadVikingGod (Aaron Clawson) a maintainer (#2404) 2021-11-19 07:30:32 -08:00
Robert Pająk 00a1ec5fc4 Add documentation guidelines and improve Jaeger exporter readme (#2082)
* Add documentation guidelines and improve Jaeger exporter readme

* Improve docs

* Update CONTRIBUTING.md
2021-07-16 12:07:21 -04:00
Tyler Yahn 4ffdf0343c Add @pellard as an Approver (#2047) 2021-07-01 09:11:28 -07:00
Tyler Yahn 694c9a413d Interface stability documentation (#2012)
* Interface stability documentation

* Update versioning policy

* Update CONTRIBUTING

* Document how to extend immutable interfaces

* Markdown format VERSIONING changes
2021-06-18 07:56:11 -07:00
Aaron Clawson c1f460e097 Update API configs. (#1921)
* Added Reason to Contributing and Updated TracerConfig

* PR comment fixup

* Changed how span Options work.

* Fix Markdown linting

* Added meter configs.

* Fixes from PR comments

* fix for missing instrument

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-05-27 07:53:56 -07:00
Tyler Yahn f06cace69b Add @MadVikingGod as a project Approver (#1923) 2021-05-17 08:41:24 -07:00
Robert Pająk ae85fab3c3 Document functional options (#1899)
* Document functional options

* Update CONTRIBUTING.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update CONTRIBUTING.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-05-11 21:28:46 -04:00
Robert Pająk d4c8ffadad Replace spaces to tabs in Go code snippets (#1854)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-28 08:19:15 -07:00
Robert Pająk 392a44fa46 Refine configuration design docs (#1841)
* Refine configuration design docs

* Remove repetition

* Fix typo

* Unify code blocks

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-27 11:04:09 -07:00
Tyler Yahn ca130e54e8 Markdownlint (#1842) 2021-04-26 08:42:41 -07:00
Tyler Yahn c61f4b6dfc Set @lizthegrey to emeritus status (#1745) 2021-03-29 11:09:09 -04:00
Tyler Yahn 26f006b806 Reinstate @paivagustavo as an Approver (#1734)
According to the [community
charter](https://github.com/open-telemetry/community/blob/main/community-membership.md#responsibilities-and-privileges-2):

> Expected to be responsive to review requests (inactivity for more than
> 1 month may result in suspension until active again)

Given @paivagustavo has returned to an active state, this reinstates
their status as an Approver.
2021-03-28 08:37:41 -07:00
Anthony Mirabella 90bd4ab50c Update employer information for maintainers (#1683)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-03-09 10:55:46 -08:00
Tyler Yahn 875a25835f Add docs on when reviews should be cleared (#1556) 2021-03-05 14:25:58 -08:00
Tyler Yahn 78c06cef35 Update docs from gitter to slack for communication (#1554)
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-02-22 08:38:12 -08:00
Tyler Yahn 6b340501b3 Update default branch name (#1505)
* Update README master branch URL to main

* Remove master branch from workflow triggers

The master branch has been renamed to main.

* Add changes to CHANGELOG

* Rename other projects default branch

All of OpenTelemetry is moving to rename `master` to `main`, this
updates all other URLs for those projects.

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-02-04 11:13:25 -08:00
Tyler Yahn 93d426a1a9 Add @dashpole as a project Approver (#1410) 2020-12-17 16:36:49 -08:00
Matej Gera a12224a454 Ensure exported interfaces have named method parameters (#1172)
* Ensure exported interface types have named arguments

* Update Styling Guide

* update CHANGELOG
2020-09-16 09:09:45 -07:00
Anthony Mirabella d91de437b2 Recommend use of initializers for config structs (#1163)
* Recommend use of initializers for config structs

Updates style guide and changes existing configure() implementations to
newConfig() as appropriate.

* Add CHANGELOG.md entry

* Update stdout exporter config initializer

* Add documentation to exported functions

* Convert otlp.Config to unexported otlp.config
2020-09-11 14:14:25 -07:00
Anthony Mirabella a787f09536 Update CONTRIBUTING.md to reflect PR process-as-applied (#1159) 2020-09-10 14:42:49 -04:00
JBD 4c5f8348c3 Document make test for testing (#1154)
Fixes #1140
2020-09-10 00:53:27 -04:00
Tyler Yahn f36759aa47 Add @XSAM as project approver (#1110)
Requirements
- [X] >=10 substantive contributions
- [X] Active >1mo
- [X] add to CODEOWNERS  (done in this pull)
- [X] Add to CONTRIBUTING.md (done in this pull)
- [X] Maintainer nomination: @MrAlias
- [X] Other maintainer(s) (@Aneurysm9) sign-off
- [X]  Add to @open-telemetry/go-approvers
2020-08-28 17:05:48 -04:00
Tyler Yahn f8b14d280e Update project maintainers (#1058)
Replace @jmacd with @Aneurysm9 as maintainer of the project. Keep @jmacd
as a project approver.
2020-08-14 07:53:42 -07:00
Tyler Yahn 7f1dc4a237 Update Contributing style guide section (#971)
* Update Contributing style guide section

* Update CONTRIBUTING.md

Correct spelling.
2020-07-28 10:23:47 -07:00
Liz Fong-Jones fd54b6c642 paivagustavo to emeritus for now (#960)
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-23 11:19:58 -07:00
Anthony Mirabella 2635f96eba Ask for changelog updates with PRs (#879)
* Ask for changelog updates with PRs

* Add PR ID to changelog entry

* move changelog entry to unreleased
2020-06-26 17:50:19 -07:00