* Unexport NoopXXX trace types
The change unexports the noop implementations and provide the NoopProvider function for user to construct noop providers. Users can access noop tracer and noop spans by using the provider.
This change removes the types users should never be directly using from the package. It improves the usability of the API by reducing the API surface to half and helping the user to focus on the canonical APIs.
Fixes#1133
* Provide noop tracer and span for internal use
* Remove obsolete doc
* Use noop span instead of nil
* Fix the broken build
* Add new propagators package
* Move B3 propagator to propagators
Update all `api/trace` dependencies in the propagator.
Export the isDeferred and isDebug methods of the SpanContext. These are
needed by the B3 propagator to track trace state.
* Move W3C trace context propagator to propagators
* Update package docs with supported encodings
* Move unified propagators code to own file
* Update b3 exported documentation
* Update trace_context exported documentation
* Add code examples for B3 propagator
* Add TraceContext example code
* Remove internal package
Move common testing declarations to the propagators_test.go file.
* Add changes to Changelog
* Add test to check default propagators
Also simplified the first lines of some package docs
to focus on what the package provides instead of
explaining the implementation details.
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Unify API Span Start/End Options
Replace both with `SpanOption`. Add a unified `SpanConfig` to match and
a `SpanConfigure` function to parse a `SpanConfig` from `SpanOption`s.
Update all the related options to use new `SpanOption`s.
* No non-zero SpanConfig defaults
The SDK uses an internal clock for the current time that cannot be use
if it does not know the time has not been set.
* Append attributes for WithAttributes
This preserves existing behavior.
* Add unit test for SpanConfigure
* Propagate changes
* Update append option documentation
* Update testing comments
* Move comments on guarantees to appropriate function
* Add documentation for SDK methods
Include SDK implementation specific information in the Tracer Start
method and Span End method.
* Add changes to Changelog
* Apply suggestions from code review
Co-authored-by: ET <evantorrie@users.noreply.github.com>
* Update the SpanKind comment in the SpanConfig
Try for a less tautological comment.
Co-authored-by: ET <evantorrie@users.noreply.github.com>
* Change name of ProbabilitySampler to TraceIdRatioBased
* Modify behavior to ignore parent span
* Add test for inclusivity property on TraceIdRatioBased sampler
* Modify tests in `trace_test.go` to reflect change in parent
span behavior
* Add to CHANGELOG
* Satisfy golint
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update Tracer configuration.
Conform to API option design outlined in #536.
Add tests to validate new TracerConfigure function
Drop the `instrumentation` prefix.
* Stick with instrumentationVersion for now
* Propagate changes
* Add changes to Changelog
* port reconnecting udp client from jaeger-client-go
* Fix precommit issues
* Fix license check
* Add initial value for max packet size
* Fix for atomic usage on 386 arch
* Modify reconnecting option to an affirmative
* Add changelog entry
* Dont hold rlock for writes
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Make trace testhelpers public
Move MockSpan and MockTracer out of internal package into the api/trace
directory.
* Do not move internal/trace/parent into testing dir
Leave internal/trace/parent/parent.go in the internal directory.
* Fix MockTracer Start method comments
Fix "TraceID".
* Run make precommit to cleanup go.mod
Cleanum go.mod and go.sum.
* Fix tracetest MockSpan structure alignment
Make MockSpan 80 bytes instead of 88 by fixing its alignment.
* Revert bridge/opentracing/internal/mock.go imports
Do not change imports lines in bridge/opentracing/internal/mock.go.
Requirements
- [X] >=10 substantive contributions
- [X] Active >1mo
- [X] add to CODEOWNERS (done in this pull)
- [X] Add to CONTRIBUTING.md (done in this pull)
- [X] Maintainer nomination: @MrAlias
- [X] Other maintainer(s) (@Aneurysm9) sign-off
- [X] Add to @open-telemetry/go-approvers
* Make metric test helpers public
* Move everything metric test related to api/metric/metrictest
* Unify metric measurement assertions
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update README.md
Replace `Installation` and `Compatible Libraries` sections with a more
comprehensive `Getting Started` section to address the two actions most
users will want to know about: instrumenting and exporting.
Remove the code example.
Add links to project boards and milestones to address project status
questions.
* Fix spelling error
* Apply suggestions from code review
Co-authored-by: ET <evantorrie@users.noreply.github.com>
Co-authored-by: ET <evantorrie@users.noreply.github.com>
Add check for github-actions.
Add missing examples and SDK go.mod
Remove redundant comments.
Change check to be weekly on Sunday to reduce load and churn.
Sort alphanumerically.
Add check to Makefile to ensure if there is a `go.mod` file there is a dependabot entry for that directory.
* Export coverage report to codecov
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
* Use orb and individual coverage files per module
* Run go cover inside module directory to account for local rewrites
Still try to upload using a single file, since orb docs seem to
indicate if you have more than one file, you're going to need to run
the orb multiple times.
* Use correct filename
* Don't do anything silly like appending a file to itself
* Handle subtle differences between FreeBSD and Linux
* Ignore opentelemetry-proto-gen files in exporters/otlp/internal
* Does codecov orb leave current directory in a bad state?
* Copy instead of move
* Ignore generated protobuf code in jaeger exporter module
Co-authored-by: Evan Torrie <evantorrie@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* fix broken example link to the example directory
* Update README.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Build on newly release version of go, go 1.15
Remove 1.13 build job per policy of supporting past two releases.
* String conversions in 1.15 require byte, rune or string.
Simply passing an integer now issues a warning.
