Chester Cheung
76bff3fe89
add hanyuancheung as an approver ( #2638 )
...
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2022-02-25 08:03:15 -08:00
Tyler Yahn
bd817df68c
Change Options to accept type not pointer ( #2558 )
...
* Change trace options to accept type not pointer
Add benchmark to show allocation improvement.
* Update CONTRIBUTING.md guidelines
* Update all Option iface
* Fix grammar in CONTRIBUTING
2022-02-01 15:51:23 -06:00
Sam Xie
24aecc561d
Update affiliation for Sam Xie ( #2458 )
2021-12-15 08:45:53 -06:00
Tyler Yahn
b42ab7d2b4
Make MadVikingGod (Aaron Clawson) a maintainer ( #2404 )
2021-11-19 07:30:32 -08:00
Robert Pająk
00a1ec5fc4
Add documentation guidelines and improve Jaeger exporter readme ( #2082 )
...
* Add documentation guidelines and improve Jaeger exporter readme
* Improve docs
* Update CONTRIBUTING.md
2021-07-16 12:07:21 -04:00
Tyler Yahn
4ffdf0343c
Add @pellard as an Approver ( #2047 )
2021-07-01 09:11:28 -07:00
Tyler Yahn
694c9a413d
Interface stability documentation ( #2012 )
...
* Interface stability documentation
* Update versioning policy
* Update CONTRIBUTING
* Document how to extend immutable interfaces
* Markdown format VERSIONING changes
2021-06-18 07:56:11 -07:00
Aaron Clawson
c1f460e097
Update API configs. ( #1921 )
...
* Added Reason to Contributing and Updated TracerConfig
* PR comment fixup
* Changed how span Options work.
* Fix Markdown linting
* Added meter configs.
* Fixes from PR comments
* fix for missing instrument
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-05-27 07:53:56 -07:00
Tyler Yahn
f06cace69b
Add @MadVikingGod as a project Approver ( #1923 )
2021-05-17 08:41:24 -07:00
Robert Pająk
ae85fab3c3
Document functional options ( #1899 )
...
* Document functional options
* Update CONTRIBUTING.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update CONTRIBUTING.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-05-11 21:28:46 -04:00
Robert Pająk
d4c8ffadad
Replace spaces to tabs in Go code snippets ( #1854 )
...
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-28 08:19:15 -07:00
Robert Pająk
392a44fa46
Refine configuration design docs ( #1841 )
...
* Refine configuration design docs
* Remove repetition
* Fix typo
* Unify code blocks
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-04-27 11:04:09 -07:00
Tyler Yahn
ca130e54e8
Markdownlint ( #1842 )
2021-04-26 08:42:41 -07:00
Tyler Yahn
c61f4b6dfc
Set @lizthegrey to emeritus status ( #1745 )
2021-03-29 11:09:09 -04:00
Tyler Yahn
26f006b806
Reinstate @paivagustavo as an Approver ( #1734 )
...
According to the [community
charter](https://github.com/open-telemetry/community/blob/main/community-membership.md#responsibilities-and-privileges-2 ):
> Expected to be responsive to review requests (inactivity for more than
> 1 month may result in suspension until active again)
Given @paivagustavo has returned to an active state, this reinstates
their status as an Approver.
2021-03-28 08:37:41 -07:00
Anthony Mirabella
90bd4ab50c
Update employer information for maintainers ( #1683 )
...
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-03-09 10:55:46 -08:00
Tyler Yahn
875a25835f
Add docs on when reviews should be cleared ( #1556 )
2021-03-05 14:25:58 -08:00
Tyler Yahn
78c06cef35
Update docs from gitter to slack for communication ( #1554 )
...
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-02-22 08:38:12 -08:00
Tyler Yahn
6b340501b3
Update default branch name ( #1505 )
...
* Update README master branch URL to main
* Remove master branch from workflow triggers
The master branch has been renamed to main.
* Add changes to CHANGELOG
* Rename other projects default branch
All of OpenTelemetry is moving to rename `master` to `main`, this
updates all other URLs for those projects.
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2021-02-04 11:13:25 -08:00
Tyler Yahn
93d426a1a9
Add @dashpole as a project Approver ( #1410 )
2020-12-17 16:36:49 -08:00
Matej Gera
a12224a454
Ensure exported interfaces have named method parameters ( #1172 )
...
* Ensure exported interface types have named arguments
* Update Styling Guide
* update CHANGELOG
2020-09-16 09:09:45 -07:00
Anthony Mirabella
d91de437b2
Recommend use of initializers for config structs ( #1163 )
...
* Recommend use of initializers for config structs
Updates style guide and changes existing configure() implementations to
newConfig() as appropriate.
* Add CHANGELOG.md entry
* Update stdout exporter config initializer
* Add documentation to exported functions
* Convert otlp.Config to unexported otlp.config
2020-09-11 14:14:25 -07:00
Anthony Mirabella
a787f09536
Update CONTRIBUTING.md to reflect PR process-as-applied ( #1159 )
2020-09-10 14:42:49 -04:00
JBD
4c5f8348c3
Document make test
for testing ( #1154 )
...
Fixes #1140
2020-09-10 00:53:27 -04:00
Tyler Yahn
f36759aa47
Add @XSAM as project approver ( #1110 )
...
Requirements
- [X] >=10 substantive contributions
- [X] Active >1mo
- [X] add to CODEOWNERS (done in this pull)
- [X] Add to CONTRIBUTING.md (done in this pull)
- [X] Maintainer nomination: @MrAlias
- [X] Other maintainer(s) (@Aneurysm9) sign-off
- [X] Add to @open-telemetry/go-approvers
2020-08-28 17:05:48 -04:00
Tyler Yahn
f8b14d280e
Update project maintainers ( #1058 )
...
Replace @jmacd with @Aneurysm9 as maintainer of the project. Keep @jmacd
as a project approver.
2020-08-14 07:53:42 -07:00
Tyler Yahn
7f1dc4a237
Update Contributing style guide section ( #971 )
...
* Update Contributing style guide section
* Update CONTRIBUTING.md
Correct spelling.
2020-07-28 10:23:47 -07:00
Liz Fong-Jones
fd54b6c642
paivagustavo to emeritus for now ( #960 )
...
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-07-23 11:19:58 -07:00
Anthony Mirabella
2635f96eba
Ask for changelog updates with PRs ( #879 )
...
* Ask for changelog updates with PRs
* Add PR ID to changelog entry
* move changelog entry to unreleased
2020-06-26 17:50:19 -07:00
ET
665c0de552
Fix affiliation of reviewer Evan Torrie ( #865 )
2020-06-23 15:49:24 -07:00
Krzesimir Nowak
55905e58c5
Remove krnowak from approvers
2020-05-15 18:18:00 +02:00
Joshua MacDonald
88100f0fc7
Add evantorrie as an approver ( #713 )
...
* Update CODEOWNERS
* Add Evan Torrie to CONTRIBUTING
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-05-12 11:52:58 -07:00
Liz Fong-Jones
a053038e52
propose a9 as approver ( #687 )
2020-04-30 13:32:57 -04:00
Rahul Patel
52b253480a
Update Maintainer for Otel Go. ( #660 )
...
* Update Maintainer for Otel Go.
- Replace Rahul Patel with Tyler Yahn as maintainer.
* Update CODEOWNERS
* Update CODEOWNERS
Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
2020-04-24 10:59:15 -07:00
Mike Goldsmith
2ccddfe82a
Update README with import instructions and how to build / test ( #505 )
...
* update README with import instructions and how to build / test
* fix typo
* remove building the code section from README.md
* add clone instructions to CONTRIBUTING.md
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Rahul Patel <rahulpa@google.com>
2020-03-12 09:52:12 -07:00
Liz Fong-Jones
43db6ec76f
Propose putting isobel to emeritus :( ( #526 )
...
* isobel to emeritus :(
* CODEOWNERS should be reviewed by maintainers only
2020-03-06 11:15:00 -05:00
Tyler Yahn
0f1771f374
Add @MrAlias as an approver ( #471 )
2020-02-10 19:36:04 -05:00
Liz Fong-Jones
7200bb943f
finish adding krnowak to approvers ( #445 )
...
- [x] >10 substantive contributions
- [x] Active >1mo
- [x] add to `CODEOWNERS` (done already in #313 )
- [x] Maintainer nomination (done already in #313 )
- [ ] Add to @open-telemetry/go-approvers
- [x] Add to `CONTRIBUTING.md` (done in this pull)
2020-01-24 13:05:29 -08:00
Cheng-Lung Sung
723639600d
Refine CONTRIBUTING.md: make test
is included in `make precomm… ( #416 )
2020-01-06 13:16:27 -05:00
Liz Fong-Jones
aefc49cfe6
Update CONTRIBUTING.md ( #417 )
...
@paivagustavo's affiliation is wrong
2020-01-05 22:00:45 -05:00
Liz Fong-Jones
b80b336eb8
Update owners/approvers list in CONTRIBUTING.md ( #409 )
2020-01-02 13:59:42 -05:00
rghetia
15bfc5bb12
Namespace import path under "/otel" ( #274 )
...
Also fixes example module paths so that they use the vanity URL instead
of the github URL.
[Closes #184 ]
2019-11-01 11:40:29 -07:00
Krzesimir Nowak
a936b8fb00
Add some docs about useful step before filing a PR ( #151 )
...
* Add a document about contributing
It is shamelessly stolen from opentelemetry-python and edited to be
relevant to opentelemetry-go. This file should explain some less
obvious things about the development of the project, like running
linters and regenerating the files.
* Force the use of go modules
Until go 1.13 modules were disabled by default if the repository was
inside GOPATH. This was causing issues when running `make precommit`
for the first time, as it could not find sources for any of the tools
used in `make precommit` under `${GOPATH}/src`. With setting the
`GO111MODULE` environment variable to `on`, we tell `go` to behave
differently, just like go 1.13 does by default.
2019-10-01 09:16:45 -07:00