go/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2025-01-24 12:56:36 +02:00
Code Issues Releases Activity

vfs: fix modtime changing when reading file into cache - fixes #5277

Browse Source 
Before this change but after:

aea8776a4368ee8a vfs: fix modtimes not updating when writing via cache #4763

When a file was opened read-only the modtime was read from the cached
file. However this modtime wasn't correct leading to an incorrect
result.

This change fixes the definition of `item.IsDirty` to be true only
when the data is dirty. This fixes the problem as a read only file
isn't considered dirty.
This commit is contained in:
Nick Craig-Wood 2021-04-26 14:16:12 +01:00
parent b78c9a65fa
commit 00a0ee1899
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vfs/vfscache/cache.go
View File

@ -549,7 +549,7 @@ func (c *Cache) purgeClean(quota int64) {
// Make a slice of clean cache files
for _, item := range c.item {
if !item.IsDataDirty() {
if !item.IsDirty() {
items = append(items, item)
}
}

9
vfs/vfscache/item.go
View File

@ -450,15 +450,8 @@ func (item *Item) Dirty() {
item.mu.Unlock()
}
// IsDirty returns true if the item is dirty
// IsDirty returns true if the item data is dirty
func (item *Item) IsDirty() bool {
item.mu.Lock()
defer item.mu.Unlock()
return item.metaDirty || item.info.Dirty
}
// IsDataDirty returns true if the item's data is dirty
func (item *Item) IsDataDirty() bool {
item.mu.Lock()
defer item.mu.Unlock()
return item.info.Dirty