go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-05-13 21:46:43 +02:00
Code Issues Releases Activity

Refactor

Browse Source
This commit is contained in:
mgechev 2017-08-27 21:03:59 -07:00
parent 555d51617f
commit 6db615d0bb
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
defaultrules/no-else-return-rule.go
View File

@ -9,7 +9,10 @@ import (
"github.com/mgechev/revive/visitors" "github.com/mgechev/revive/visitors"
) )
const ruleName = "no-else-return" const (
ruleName = "no-else-return"
failure = "if block ends with a return statement, so drop this else and outdent its block"
)
// LintElseRule lints given else constructs. // LintElseRule lints given else constructs.
type LintElseRule struct { type LintElseRule struct {
@ -48,7 +51,7 @@ func (w *lintElseVisitor) VisitIfStmt(node *ast.IfStmt) {
lastStmt := node.Body.List[len(node.Body.List)-1] lastStmt := node.Body.List[len(node.Body.List)-1]
if _, ok := lastStmt.(*ast.ReturnStmt); ok { if _, ok := lastStmt.(*ast.ReturnStmt); ok {
w.AddFailure(rules.Failure{ w.AddFailure(rules.Failure{
Failure: "if block ends with a return statement, so drop this else and outdent its block", Failure: failure,
Type: rules.FailureTypeWarning, Type: rules.FailureTypeWarning,
Position: w.GetPosition(node.Else.Pos(), node.Else.End()), Position: w.GetPosition(node.Else.Pos(), node.Else.End()),
}) })