go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-10-30 23:37:49 +02:00
Code Issues Releases Activity

refactor: reduces the number of references to deprecated *ast.Object (#1473)

Browse Source
This commit is contained in:
chavacava
2025-08-14 13:25:47 +02:00
committed by GitHub
parent b34c8e96ec
commit 9d600b6df1
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
rule/datarace.go
View File

@@ -8,6 +8,9 @@ import (
"github.com/mgechev/revive/lint"
)
//nolint:staticcheck // TODO: ast.Object is deprecated
type nodeUID *ast.Object // type of the unique id for AST nodes
// DataRaceRule lints assignments to value method-receivers.
type DataRaceRule struct{}
@@ -23,8 +26,7 @@ func (r *DataRaceRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
funcResults := funcDecl.Type.Results
//nolint:staticcheck // TODO: ast.Object is deprecated
returnIDs := map[*ast.Object]struct{}{}
returnIDs := map[nodeUID]struct{}{}
if funcResults != nil {
returnIDs = r.extractReturnIDs(funcResults.List)
}
@@ -36,7 +38,7 @@ func (r *DataRaceRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
fl := &lintFunctionForDataRaces{
onFailure: onFailure,
returnIDs: returnIDs,
rangeIDs: map[*ast.Object]struct{}{}, //nolint:staticcheck // TODO: ast.Object is deprecated
rangeIDs: map[nodeUID]struct{}{},
go122for: isGo122,
}
@@ -51,9 +53,8 @@ func (*DataRaceRule) Name() string {
return "datarace"
}
//nolint:staticcheck // TODO: ast.Object is deprecated
func (*DataRaceRule) extractReturnIDs(fields []*ast.Field) map[*ast.Object]struct{} {
r := map[*ast.Object]struct{}{}
func (*DataRaceRule) extractReturnIDs(fields []*ast.Field) map[nodeUID]struct{} {
r := map[nodeUID]struct{}{}
for _, f := range fields {
for _, id := range f.Names {
r[id.Obj] = struct{}{}
@@ -66,8 +67,8 @@ func (*DataRaceRule) extractReturnIDs(fields []*ast.Field) map[*ast.Object]struc
type lintFunctionForDataRaces struct {
_ struct{}
onFailure func(failure lint.Failure)
returnIDs map[*ast.Object]struct{} //nolint:staticcheck // TODO: ast.Object is deprecated
rangeIDs map[*ast.Object]struct{} //nolint:staticcheck // TODO: ast.Object is deprecated
returnIDs map[nodeUID]struct{}
rangeIDs map[nodeUID]struct{}
go122for bool
}