go/revive
1
0
Fork 0
mirror of https://github.com/mgechev/revive.git synced 2025-10-30 23:37:49 +02:00
Code Issues Releases Activity

fix (1217): getting parameter type names panics in presence of generic types (#1218)

Browse Source
This commit is contained in:
chavacava
2025-02-04 12:26:17 +01:00
committed by GitHub
parent a34327e65c
commit fd8d99d716
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/astutils/ast_utils.go
View File

@@ -71,6 +71,8 @@ func getFieldTypeName(typ ast.Expr) string {
return f.Sel.Name + "." + getFieldTypeName(f.X)
case *ast.StarExpr:
return "*" + getFieldTypeName(f.X)
case *ast.IndexExpr:
return getFieldTypeName(f.X) + "[" + getFieldTypeName(f.Index) + "]"
default:
panic(fmt.Sprintf("not supported type %T", typ))
}

3
testdata/golint/sort.go vendored
View File

@@ -41,3 +41,6 @@ func (vv Vv) Less(i int, j int) (result bool) { return w[i] < w[j] } // MATCH /e
type X []int
func (x X) Less(i *pkg.tip) (result bool) { return len(x) } // MATCH /exported method X.Less should have comment or be unexported/
// Test for issue #1217
func (s *synchronized[T]) Swap(other Synchronized[T]) {}