1
0
mirror of https://github.com/mgechev/revive.git synced 2024-11-28 08:49:11 +02:00
Commit Graph

145 Commits

Author SHA1 Message Date
SalvadorC
1412d0c6ed
new rule: unexported-naming (#443)
* new rule: unexported-naming

* better failure message
2020-07-23 02:17:20 +03:00
Penghui Liao
4be54f7261 Update ALE configuratoin guide
Signed-off-by: Penghui Liao <liaoishere@gmail.com>
2020-07-07 18:50:06 -07:00
chavacava
ad3100c9ec adds defer rule 2020-06-08 09:40:38 -07:00
SalvadorC
3b38f57c2d
Merge pull request #413 from chavacava/unconditional-recursion
Unconditional recursion
2020-05-15 22:08:24 +02:00
Tymoteusz Blazejczyk
acce9eb309 feat(color): updated the README.md file about overriding colorization 2020-05-14 14:49:30 -07:00
chavacava
65beded8c4 Merge remote-tracking branch 'upstream/master' into unconditional-recursion 2020-05-13 22:13:08 +02:00
SalvadorC
1da965b65f
fix issue 386: Incorrectly identifies channel draining as "empty code… (#415)
* fix issue 386: Incorrectly identifies channel draining as "empty code block"

* updates doc of empty-block rule
2020-05-10 17:43:56 -07:00
chavacava
4eb7ae0821 documents unconditional-recursion 2020-05-09 17:19:37 +02:00
chavacava
b43b33a4e6 adds identical-branches to doc 2020-05-08 22:21:34 +02:00
SalvadorC
67c83886d7
Late return rule (#406)
* fisrt working version of late-return rule

* late-update: adds doc

* renames to early-return

* fix rule failure condition

* fix alphabetical sorting of early-return
2020-05-08 11:14:21 -07:00
mgechev
a36465434a Update the project contributors 2020-03-02 11:16:40 -08:00
Bernhard Reisenberger
c15fae8f18 range-val-address: update readme and rule description 2020-02-27 08:21:39 +01:00
SalvadorC
a24e8e7b81
String of int (#342)
* string-of-int: working version

* adds doc of string-to-int
2020-02-18 09:38:01 -08:00
chavacava
74551b1bf8 cocuments cognitive-complexity 2019-12-14 16:36:42 +01:00
mgechev
88015ccf8e Update the list of contributors 2019-10-17 16:14:19 -04:00
John Rinehart
40564c5052 support global config (e.g. for company-wide settings) (#233)
* support global config (e.g. for company-wide settings)

* documented global config behavior
2019-09-17 08:38:25 -07:00
mgechev
596ef107bb Remove renovate from the list of contributors 2019-09-16 12:34:10 -07:00
mgechev
c93badef60 Update the list of contributors 2019-09-16 12:31:59 -07:00
Markus Wiegand
fa5acbc1f0 Add Revive Action to readme (#228) 2019-09-01 06:29:52 +09:00
Michal Šimon
7b27ac88b9 Add Codeac.io - Automated code review tool (#207)
* + Codeac.io service

* @ fix typo

* + CI section

* @ fix typo
2019-08-05 09:50:10 -07:00
SalvadorC
55cfae63e9 Conf reason rule disabling (#193)
* adds support for comments when enabling/disabling

* adds config flag to require disabling reason

* Update lint/file.go

adds code fmt suggestion by @mgechev

Co-Authored-By: Minko Gechev <mgechev@gmail.com>

* moves regexp compilation out of the function
fix typo in condition

* adds support for comments when enabling/disabling

* skips incomplete directives and generate a failure

* adds _directive_ concept to cope with specify-disable-reason

* adds doc
gofmt

* fixes severity is ignored
2019-08-02 08:21:33 -07:00
mgechev
5a9154b017 Update readme 2019-07-09 21:51:26 -07:00
Mario Pérez Alarcón
7ac9a99486
docs(readme): Fixes links in rules 2019-06-05 14:00:45 +02:00
Minko Gechev
22b849f286 docs: update the list of contributors 2019-05-04 19:35:21 -06:00
SalvadorC
c8ee35a500 adds blacklist to unhandled-error (#128)
* adds blacklist for unhandled-error

* uses ignoreList in place of blackList
2019-04-29 19:56:12 -07:00
Pascal Masschelier
dbcb21608a added sklearn to "Who uses revive" (#126)
added line
- [`sklearn`](https://github.com/pa-m/sklearn) - A partial port of scikit-learn written in Go
2019-04-28 20:07:52 -07:00
SalvadorC
8aa0cd8bd4 unhandled-error (new rule) (#124)
* unhandled-error (new rule)

* better failure msg

* encapsulates error type detection
2019-04-27 19:23:17 -07:00
Minko Gechev
015086ddac docs: update sample projects 2019-04-19 17:56:36 -07:00
Minko Gechev
edfee04f38 docs: update list of projects using revive 2019-04-19 17:53:01 -07:00
SalvadorC
00a86ae1fd new rule: unused-receiver (#119)
* new rule: unused-receiver

* unused-receiver: adds more test cases
2019-04-18 10:35:51 -07:00
Minko Gechev
4c0c2b62da docs: update the list of contributors 2019-04-18 07:02:50 -07:00
SalvadorC
745bcf65aa bare-return (first working version) (#117)
New rule bare-return
2019-04-17 22:55:52 +02:00
Oleg Gaidarenko
796760d728 Mention grafana in "Who uses Revive" block (#116) 2019-04-16 09:16:13 +02:00
SalvadorC
2ce440cf96 new rule: import shadowing (#114)
* Adds rule superfluous-else (an extension of indent-error-flow)

* Fix superfluous-else rule struct namming.

* Adds superfuous-else rule to the rules table

* Adds confusing-naming rule

* adds multifile test

* clean-up

* fix config.go

* clean master

* new ADS rule: newerr

* ADS-print working version

* ads-print final version

* ads-lost-err working version

* fix ads-print

* removes ads rules from master

* new rule: import-shadowing

* removes ads rules from master

* new rule: import-shadowing

* fix defaults

* adds explanations on the rule implementation
2019-03-27 11:46:20 -07:00
Minko Gechev
a307792228 docs: update the list of contributors 2019-03-21 09:31:01 -07:00
SalvadorC
fbefad8558 New rule: duplicated-imports (#111)
* Adds rule superfluous-else (an extension of indent-error-flow)

* Fix superfluous-else rule struct namming.

* Adds superfuous-else rule to the rules table

* Adds confusing-naming rule

* adds multifile test

* clean-up

* fix config.go

* clean master

* new ADS rule: newerr

* ADS-print working version

* ads-print final version

* ads-lost-err working version

* adds duplicated-imports rule

* adds duplicated-imports rule
2019-03-20 11:54:03 -07:00
Minko Gechev
6a62ee9f02 Update the list of contributors 2019-03-01 11:45:22 -08:00
xuri
b4cc152955 Add excelize and aurora to "Who uses Revive" (#96) 2018-12-10 06:05:14 -08:00
AragurDEV
50f3790f32 Add gitea to "Who uses Revive" (#94)
When merged: https://github.com/go-gitea/gitea/pull/5422 gitea will use revive.
2018-12-04 08:45:11 -08:00
Rıdvan Şümşet
1338c47ef1 Update README.md (#95) 2018-12-04 08:42:55 -08:00
Minko Gechev
b4b876c347 docs: update readme 2018-11-25 17:56:04 -08:00
James Maidment
6b24cd60a8 Fix spelling of length 2018-11-05 17:41:25 -05:00
SalvadorC
55fe366696 call-to-gc (new rule) (#90) 2018-10-31 07:32:23 -07:00
mgechev
2020b30eef
feat: add links to rules in formatters
This PR introduces:

- A new formatter called "plain" which produces the same output as "default" but also appends link to the rule
- The "friendly" and "stylish" formatters now have URLs to the rules instead of the rule names
- Update of the README, adding the "unix" and "plain" formatters
2018-10-30 16:07:32 -07:00
SalvadorC
3ef16e4c45 Doc rules description (#87)
* partial document

* complete list of rules descriptions

* Links rules in README to corresponding descriptions

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Co-Authored-By: chavacava <salvadorcavadini+github@gmail.com>

* Update RULES_DESCRIPTIONS.md

Includes @mgechev remarks
2018-10-25 20:15:13 -07:00
xuri
3c177e2824 New rule: line-length-limit (#86)
* New rule: line-length-limit

* simplify the panic message of rule line-length-limit

* Refactors `line-length-limit` rule, use private `check` method instead of `Visit`
2018-10-19 08:18:33 -04:00
mgechev
4b3d324865
docs: update the list of contributors 2018-10-17 10:07:33 -07:00
mgechev
69f012a7d9
Merge master 2018-10-11 14:55:17 -07:00
mgechev
892cedd764
docs: add description for empty-lines 2018-10-11 14:54:27 -07:00
xuri
7d2c43c827
Rename rule name waitgroup-by-copy to waitgroup-by-value 2018-10-03 16:01:41 +08:00