1
0
mirror of https://github.com/mgechev/revive.git synced 2024-11-24 08:32:22 +02:00
Commit Graph

290 Commits

Author SHA1 Message Date
renovate[bot]
1ebfe8b325 chore(deps): update golang.org/x/tools commit hash to 4d9ae51 (#143) 2019-06-06 13:28:59 +02:00
SalvadorC
89c8b61f01
Merge pull request #142 from mapreal19/patch-1
docs(readme): Fixes links in rules
2019-06-05 14:04:30 +02:00
Mario Pérez Alarcón
7ac9a99486
docs(readme): Fixes links in rules 2019-06-05 14:00:45 +02:00
renovate[bot]
fde2ca1939 chore(deps): update module olekukonko/tablewriter to v0.0.1 (#140) 2019-06-04 09:22:31 +02:00
renovate[bot]
7e63bbd126 chore(deps): update module burntsushi/toml to v0.3.1 (#136) 2019-06-04 09:17:44 +02:00
renovate[bot]
a9c3669cb9 chore(deps): update module mattn/go-runewidth to v0.0.4 (#139) 2019-06-04 09:17:17 +02:00
renovate[bot]
f5dadd6734 chore(deps): update golang.org/x/tools commit hash to 8aaa148 (#135) 2019-06-04 09:16:53 +02:00
renovate[bot]
e221038ef3 chore(deps): update module mattn/go-colorable to v0.1.2 (#137) 2019-06-04 01:10:43 +02:00
renovate[bot]
de6c8e5f22 chore(deps): update module pkg/errors to v0.8.1 (#141) 2019-06-04 01:10:21 +02:00
renovate[bot]
8056651f8f chore(deps): update golang.org/x/sys commit hash to 4c4f7f3 (#134) 2019-06-03 14:41:57 +02:00
renovate[bot]
c5e9877a56 chore(deps): update github.com/mgechev/dots commit hash to 18fa4c4 (#133) 2019-06-03 14:36:28 +02:00
renovate[bot]
f1d75c05f5 chore(deps): add renovate.json (#132) 2019-06-03 14:25:59 +02:00
SalvadorC
c967fd68ea struct-tag warns on private fields with tags (#131) 2019-06-01 10:34:43 +02:00
Minko Gechev
22b849f286 docs: update the list of contributors 2019-05-04 19:35:21 -06:00
SalvadorC
c8ee35a500 adds blacklist to unhandled-error (#128)
* adds blacklist for unhandled-error

* uses ignoreList in place of blackList
2019-04-29 19:56:12 -07:00
Pascal Masschelier
dbcb21608a added sklearn to "Who uses revive" (#126)
added line
- [`sklearn`](https://github.com/pa-m/sklearn) - A partial port of scikit-learn written in Go
2019-04-28 20:07:52 -07:00
SalvadorC
8aa0cd8bd4 unhandled-error (new rule) (#124)
* unhandled-error (new rule)

* better failure msg

* encapsulates error type detection
2019-04-27 19:23:17 -07:00
SalvadorC
e8c1baf8ac optimizes import-blacklist (#123) 2019-04-22 10:58:02 -07:00
SalvadorC
2474f6cecb simpler and more efficient implementation of unused-parameter (#121) 2019-04-21 10:13:03 -07:00
Minko Gechev
015086ddac docs: update sample projects 2019-04-19 17:56:36 -07:00
Minko Gechev
edfee04f38 docs: update list of projects using revive 2019-04-19 17:53:01 -07:00
SalvadorC
00a86ae1fd new rule: unused-receiver (#119)
* new rule: unused-receiver

* unused-receiver: adds more test cases
2019-04-18 10:35:51 -07:00
Minko Gechev
4c0c2b62da docs: update the list of contributors 2019-04-18 07:02:50 -07:00
SalvadorC
745bcf65aa bare-return (first working version) (#117)
New rule bare-return
2019-04-17 22:55:52 +02:00
Oleg Gaidarenko
796760d728 Mention grafana in "Who uses Revive" block (#116) 2019-04-16 09:16:13 +02:00
SalvadorC
2ce440cf96 new rule: import shadowing (#114)
* Adds rule superfluous-else (an extension of indent-error-flow)

* Fix superfluous-else rule struct namming.

* Adds superfuous-else rule to the rules table

* Adds confusing-naming rule

* adds multifile test

* clean-up

* fix config.go

* clean master

* new ADS rule: newerr

* ADS-print working version

* ads-print final version

* ads-lost-err working version

* fix ads-print

* removes ads rules from master

* new rule: import-shadowing

* removes ads rules from master

* new rule: import-shadowing

* fix defaults

* adds explanations on the rule implementation
2019-03-27 11:46:20 -07:00
Minko Gechev
a307792228 docs: update the list of contributors 2019-03-21 09:31:01 -07:00
Dian
44eed7edb7 fix error return rule to allow multiple error return values (#110)
* fix error return rule to allow multiple error return values

please check golint related updates here: golang/lint@8379672

When returning multiple values with an error,
lint checks if the error is the last return value.
But the implementation actually is checking for all return values
except for the last one, and throw the alert if it found an error.

There is a (edge) case where some function returning more than one error
is getting a false positive even when the last return value is an error.

This patch adds an early check, to see if the last return value is an error
and if so, it will pass silently.

* Fix return error

* add test changes
2019-03-20 11:54:27 -07:00
SalvadorC
fbefad8558 New rule: duplicated-imports (#111)
* Adds rule superfluous-else (an extension of indent-error-flow)

* Fix superfluous-else rule struct namming.

* Adds superfuous-else rule to the rules table

* Adds confusing-naming rule

* adds multifile test

* clean-up

* fix config.go

* clean master

* new ADS rule: newerr

* ADS-print working version

* ads-print final version

* ads-lost-err working version

* adds duplicated-imports rule

* adds duplicated-imports rule
2019-03-20 11:54:03 -07:00
Minko Gechev
6a62ee9f02 Update the list of contributors 2019-03-01 11:45:22 -08:00
SalvadorC
202adf0786 Fix 102 (#103)
Do not require additional newline for disabling multiple rules
2019-01-24 09:14:43 -08:00
SalvadorC
e2acdb0e10
Merge pull request #101 from mapreal19/patch-1
Adds missing `rule` in rules examples
2019-01-21 15:22:34 +01:00
Mario Pérez
d775d613d0
Adds missing rule in rules examples 2019-01-21 14:25:14 +01:00
SalvadorC
c878d3090d fixes issue #98 (#99) 2019-01-18 07:33:40 -08:00
xuri
b4cc152955 Add excelize and aurora to "Who uses Revive" (#96) 2018-12-10 06:05:14 -08:00
AragurDEV
50f3790f32 Add gitea to "Who uses Revive" (#94)
When merged: https://github.com/go-gitea/gitea/pull/5422 gitea will use revive.
2018-12-04 08:45:11 -08:00
Rıdvan Şümşet
1338c47ef1 Update README.md (#95) 2018-12-04 08:42:55 -08:00
Minko Gechev
b4b876c347 docs: update readme 2018-11-25 17:56:04 -08:00
SalvadorC
47d2b15cf9
Merge pull request #92 from jamesmaidment/fix-line-length-doc
Fix spelling of length (Closes #91, related to #93)
2018-11-06 07:09:04 +01:00
SalvadorC
623ef04eb0
Merge pull request #93 from xuri/miscellaneous
Doc updated: fix typo (see #91 and #92)
2018-11-06 07:07:17 +01:00
xuri
9fccf1407f
Doc updated: fix typo 2018-11-06 10:28:24 +08:00
James Maidment
6b24cd60a8 Fix spelling of length 2018-11-05 17:41:25 -05:00
mgechev
26ec4a5367
ci: update travis scripts 2018-10-31 12:55:27 -07:00
SalvadorC
55fe366696 call-to-gc (new rule) (#90) 2018-10-31 07:32:23 -07:00
mgechev
ad7df7dc37
ci: remove apt install 2018-10-30 16:35:41 -07:00
mgechev
46944678f0
ci: update travis config 2018-10-30 16:32:27 -07:00
mgechev
7391637be6
ci: update deployment script 2018-10-30 16:27:32 -07:00
mgechev
1eba0c6f7b
ci: update deployment script 2018-10-30 16:16:17 -07:00
mgechev
2020b30eef
feat: add links to rules in formatters
This PR introduces:

- A new formatter called "plain" which produces the same output as "default" but also appends link to the rule
- The "friendly" and "stylish" formatters now have URLs to the rules instead of the rule names
- Update of the README, adding the "unix" and "plain" formatters
2018-10-30 16:07:32 -07:00
mgechev
376425d517
refactor: remove URL field from the failure struct 2018-10-30 15:37:27 -07:00