1
0
mirror of https://github.com/mgechev/revive.git synced 2025-01-08 03:13:27 +02:00
revive/testdata
Bryan Boreham 7da6a39044
modifies-value-receiver: warn on slice or map (#943)
* modifies-value-receiver: warn on slice or map

Assignments which index into the slice or map are already ignored on
line 72, and those where the whole receiver is slice or map on line 50.
We should not ignore assignments where the member variable is slice
or map.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

* Remove extra space

---------

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Co-authored-by: Denis Voytyuk <5462781+denisvmedia@users.noreply.github.com>
2023-11-28 15:45:52 +01:00
..
golint fix trailing whitespaces (#917) 2023-10-27 07:26:27 +02:00
add-constant.go fix #759 [rule.add-constant] change 'ignoreFuncs' expressions in documentation and test (#760) 2022-10-15 11:24:32 +02:00
argument-limit.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
atomic.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
banned-characters.go Add banned characters rule (#532) (#591) 2021-10-14 20:56:29 +02:00
bare-return.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
bool-literal-in-expr.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
call-to-gc.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
cognitive-complexity.go fixes issue #451 (#452) 2020-08-05 19:25:57 +03:00
comment-spacings.go add nolint to default list of acceptable comments for comment-spacings (#822) 2023-05-09 16:20:58 +02:00
confusing-naming1.go fix #864: confusing-naming FP on methods of generic types (#869) 2023-08-12 10:56:53 +02:00
confusing-naming2.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
confusing-results.go fix trailing whitespaces (#917) 2023-10-27 07:26:27 +02:00
constant-logical-expr.go Incorrect handling of token.{LEQ,GEQ} for constant-logical-expr (#642) 2022-02-27 09:37:51 +01:00
context-as-argument.go Allow whitelist for the context parameter check (#616) 2021-12-31 17:11:18 -08:00
cyclomatic-2.go refactor(cyclomatic): improved message for cyclomatic rule (#629) 2022-01-31 17:33:43 +01:00
cyclomatic.go refactor(cyclomatic): improved message for cyclomatic rule (#629) 2022-01-31 17:33:43 +01:00
datarace.go add rule datarace (#683) 2022-04-18 09:45:42 -07:00
deep-exit_test.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
deep-exit.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
defer-loop-disabled.go adds defer rule 2020-06-08 09:40:38 -07:00
defer-only-loop-enabled.go adds defer rule 2020-06-08 09:40:38 -07:00
defer.go fix #863:false positive on return statement in a func lit passed to the deferred function (#870) 2023-08-18 11:21:42 -07:00
disable-annotations2.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
disable-annotations3.go fix issue #540 (#543) 2021-07-11 21:31:46 -07:00
disable-annotations.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
duplicated-imports.go fix trailing whitespaces (#917) 2023-10-27 07:26:27 +02:00
early-return-scope.go ifelse: option to preserve variable scope (#832) 2023-05-23 10:10:09 +02:00
early-return.go refactor: extract shared code for linting if-else chains (#821) 2023-05-17 13:51:35 +02:00
empty-block.go Prevent empty-block when looping over call expr 2023-05-01 10:44:48 +02:00
empty-lines.go fix bug #739: empty-lines false positive (#742) 2022-08-27 13:18:17 +02:00
enforce-map-style-any.go feat: add support for enforce-map-style rule (#895) 2023-09-17 11:22:11 +02:00
enforce-map-style-literal.go feat: add support for enforce-map-style rule (#895) 2023-09-17 11:22:11 +02:00
enforce-map-style-make.go feat: add support for enforce-map-style rule (#895) 2023-09-17 11:22:11 +02:00
enforce-slice-style-any.go feat: add support for enforce-slice-style rule (#900) 2023-09-23 09:05:52 +02:00
enforce-slice-style-literal.go feat: add support for enforce-slice-style rule (#900) 2023-09-23 09:05:52 +02:00
enforce-slice-style-make.go feat: add support for enforce-slice-style rule (#900) 2023-09-23 09:05:52 +02:00
error-strings-with-custom-functions.go Allow to customize user functions in rule error-strings (#703) 2022-07-05 21:51:50 +02:00
exported-issue-519.go Exported config (#565) 2021-08-26 08:36:24 -07:00
exported-issue-552.go Exported config (#565) 2021-08-26 08:36:24 -07:00
exported-issue-555.go Exported config (#565) 2021-08-26 08:36:24 -07:00
file-to-exclude.go per-rule file exclude filters (#850) (#857) 2023-08-12 08:21:11 +02:00
flag-param.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
function-length1.go new rule function-length (#504) 2021-03-20 15:45:30 -07:00
function-length2.go new rule function-length (#504) 2021-03-20 15:45:30 -07:00
function-length3.go new rule function-length (#504) 2021-03-20 15:45:30 -07:00
function-result-limit.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
get-return.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
identical-branches.go identical-branches initial implementation 2020-05-08 22:08:16 +02:00
if-return.go fix issue #537 (#538) 2021-06-29 13:04:51 -07:00
import-alias-naming-custom-config-with-multiple-values.go Add denyRegex support for import-alias-naming rule (#927) 2023-10-29 13:19:53 +01:00
import-alias-naming-custom-config-with-only-deny.go Add denyRegex support for import-alias-naming rule (#927) 2023-10-29 13:19:53 +01:00
import-alias-naming-custom-config.go feat: add support for import-alias-naming rule (#881) 2023-08-28 15:26:00 +02:00
import-alias-naming.go fix: ignore dot import aliases in import-alias-naming rule (#938) 2023-11-26 08:57:34 +01:00
import-dot.go [dot-imports] support allow list of packages (#939) 2023-11-26 10:07:12 +01:00
import-shadowing.go fix: false positive in import-shadowing for method names (#876) 2023-08-21 23:45:41 +02:00
imports-blacklist-original.go Fixes issue #619 imports-blacklist support regex (#684) 2022-04-21 16:04:00 +02:00
imports-blacklist.go Fixes issue #619 imports-blacklist support regex (#684) 2022-04-21 16:04:00 +02:00
json-data-format-atomic.go extend parsing instructions to use json object instead of plain txt (#929) 2023-11-26 10:18:36 +01:00
json-data-format-var-naming.go extend parsing instructions to use json object instead of plain txt (#929) 2023-11-26 10:18:36 +01:00
line-length-limit.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
lint-file-header1.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
lint-file-header2.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
lint-file-header3.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
lint-file-header4.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
lint-file-header5.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
lint-file-header6.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
max-public-structs.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
modifies-param.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
modifies-value-receiver.go modifies-value-receiver: warn on slice or map (#943) 2023-11-28 15:45:52 +01:00
nested-structs.go fix #824 (#829) 2023-05-16 10:31:25 +02:00
optimize-operands-order.go Add optimize-operands-order rule (#599) (#603) 2021-10-23 09:29:14 +02:00
range-val-address.go range-val-address: improve detection (#647) 2022-03-12 09:32:57 +01:00
range-val-in-closure.go fix issue #637 (#638) 2022-02-15 22:46:24 +01:00
receiver-naming-issue-669.go fix(receiver-naming): distinguish types with parameters (#692) 2022-06-18 18:47:53 +02:00
redefines-builtin-id.go fix issue #792 (#793) 2023-02-18 10:57:06 +01:00
redundant-import-alias.go feat: add rule for redundant import alias (#854) 2023-07-31 08:22:40 +02:00
string-format.go fix: support method call from structures for string-format (#840) 2023-07-29 11:27:07 +02:00
string-of-int.go Add banned characters rule (#532) (#591) 2021-10-14 20:56:29 +02:00
struct-tag-useroptions.go fix issue #520 (#802) 2023-03-14 16:16:12 -07:00
struct-tag.go Fix prefix trimming in struct-tag (#827) 2023-05-16 08:09:20 +02:00
superfluous-else-scope.go ifelse: option to preserve variable scope (#832) 2023-05-23 10:10:09 +02:00
superfluous-else.go refactor: extract shared code for linting if-else chains (#821) 2023-05-17 13:51:35 +02:00
time-equal.go fix #846: time-equal garbled message when time returned from function (#868) 2023-08-12 09:05:46 +02:00
time-naming.go fix: time-naming issue #571 (#572) 2021-09-12 16:09:14 -07:00
unchecked-type-assertion-accept-ignored.go Add unchecked-type-assertion (#889) 2023-09-17 10:58:45 +02:00
unchecked-type-assertion.go Add unchecked-type-assertion (#889) 2023-09-17 10:58:45 +02:00
unconditional-recursion.go fix: literal calls case (#909) 2023-09-30 10:18:17 +02:00
unexported-naming.go new rule: unexported-naming (#443) 2020-07-23 02:17:20 +03:00
unhandled-error-w-ignorelist.go refactor: remove refs to io/ioutil (#918) 2023-10-14 19:25:25 +02:00
unhandled-error.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
unnecessary-stmt.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
unreachable-code.go add testing.FailNow and related function to unreachable check (#711) 2022-07-20 15:41:31 -07:00
unused-param-custom-regex.go adds [allowRegex] parameter for unused-parameter and unused-receiver rules (#858) 2023-08-11 07:35:08 +02:00
unused-param.go Move away from deprecated ioutils (#825) 2023-05-16 08:06:52 +02:00
unused-receiver-custom-regex.go adds [allowRegex] parameter for unused-parameter and unused-receiver rules (#858) 2023-08-11 07:35:08 +02:00
unused-receiver.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
use-any.go Revert "fix: unnecesary alert for use-any when comments inside interface{} (#873)" (#874) 2023-08-19 08:07:28 +02:00
useless-break.go fix issue 556 (#557) 2021-08-16 12:15:17 +02:00
var-naming_test.go fix #622 (Rule 'var-naming' should allow Fuzz_xxx) (#623) 2022-01-18 15:26:29 +01:00
var-naming_upperCaseConst-false.go (var-naming) support private uppercase constants #865 (#866) 2023-08-12 08:45:42 +02:00
var-naming_upperCaseConst-true.go (var-naming) support private uppercase constants #865 (#866) 2023-08-12 08:45:42 +02:00
var-naming.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00
waitgroup-by-value.go renames fixtures as testdata to avoid spurious dependencies (#359) 2020-03-02 09:12:43 -10:00