1
0
mirror of https://github.com/go-task/task.git synced 2025-01-06 03:53:54 +02:00

Small improvement and CHANGELOG for #477

This commit is contained in:
Andrey Nering 2021-07-10 21:58:03 -03:00
parent a7594740e3
commit 1f9fd24064
2 changed files with 6 additions and 4 deletions

View File

@ -2,6 +2,8 @@
## Unreleased
- Allow using both `sources:` and `status:` in the same task
([#411](https://github.com/go-task/task/issues/411), ([#427](https://github.com/go-task/task/issues/427)), [#477](https://github.com/go-task/task/pull/477)).
- Small optimization and bug fix: don't compute variables if not needed for
`dotenv:` ([#517](https://github.com/go-task/task/issues/517)).

View File

@ -29,10 +29,11 @@ func (e *Executor) Status(ctx context.Context, calls ...taskfile.Call) error {
}
func (e *Executor) isTaskUpToDate(ctx context.Context, t *taskfile.Task) (bool, error) {
areChecksGiven := false
if len(t.Status) == 0 && len(t.Sources) == 0 {
return false, nil
}
if len(t.Status) > 0 {
areChecksGiven = true
isUpToDate, err := e.isTaskUpToDateStatus(ctx, t)
if err != nil {
return false, err
@ -43,7 +44,6 @@ func (e *Executor) isTaskUpToDate(ctx context.Context, t *taskfile.Task) (bool,
}
if len(t.Sources) > 0 {
areChecksGiven = true
checker, err := e.getStatusChecker(t)
if err != nil {
return false, err
@ -57,7 +57,7 @@ func (e *Executor) isTaskUpToDate(ctx context.Context, t *taskfile.Task) (bool,
}
}
return areChecksGiven, nil
return true, nil
}
func (e *Executor) statusOnError(t *taskfile.Task) error {