go/task
go/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2025-03-21 21:27:07 +02:00
Code Issues Releases Activity

execext.RunCommand: fix: do not pass a cancellable context to mvdan.cc/sh

Browse Source 
We used to pass to mvdan.cc/sh/interp.Runner a context that was cancelled on
reception of a OS signal. This caused the Runner to terminate the subprocess
abruptly.

The correct behavior instead is for us to completely ignore the signal and let
the subprocess deal with it. If the subprocess doesn't handle the signal, it
will be terminated. If the subprocess does handle the signal, it knows better
than us wether it wants to cleanup and terminate or do something different.

So now we pass an empty context just to make the API of interp.Runner happy

Fixes go-task/task/#458
This commit is contained in:
Marco Molteni 2021-04-22 15:30:52 +02:00 committed by Wes McNamee
parent bffb6e1a07
commit 22dfc1e265
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
internal/execext/exec.go
View File

@ -55,7 +55,16 @@ func RunCommand(ctx context.Context, opts *RunCommandOptions) error {
if err != nil {
return err
}
return r.Run(ctx, p)
// We used to pass to interp.Runner a context that was cancelled on reception of a
// OS signal. This caused the Runner to terminate the subprocess abruptly.
// The correct behavior instead is for us to completely ignore the signal and let
// the subprocess deal with it. If the subprocess doesn't handle the signal, it will
// be terminated. If the subprocess does handle the signal, it knows better than us
// wether it wants to cleanup and terminate or do something different.
// See https://github.com/go-task/task/issues/458 for details.
// So now we pass an empty context just to make the API of interp.Runner happy
return r.Run(context.Background(), p)
}
// IsExitError returns true the given error is an exis status error