1
0
mirror of https://github.com/go-task/task.git synced 2025-03-17 21:08:01 +02:00

fix: tasks being incorrectly marked as internal

This commit is contained in:
Pete Davison 2023-02-10 17:02:11 +00:00
parent e23dacd6d4
commit 74f69a21cd
3 changed files with 5 additions and 14 deletions

View File

@ -1,5 +1,9 @@
# Changelog
## Unreleased
- Fixed a bug where tasks were sometimes incorrectly marked as internal ([#1007](https://github.com/go-task/task/pull/1007) by @pd93).
## v3.20.0 - 2023-01-14
- Improve behavior and performance of status checking when using the

View File

@ -61,14 +61,6 @@ func (tfs *IncludedTaskfiles) Len() int {
return len(tfs.Keys)
}
// Merge merges the given IncludedTaskfiles into the caller one
func (tfs *IncludedTaskfiles) Merge(other *IncludedTaskfiles) {
_ = other.Range(func(key string, value IncludedTaskfile) error {
tfs.Set(key, value)
return nil
})
}
// Set sets a value to a given key
func (tfs *IncludedTaskfiles) Set(key string, includedTaskfile IncludedTaskfile) {
if tfs.Mapping == nil {

View File

@ -5,7 +5,7 @@ import (
"strings"
)
// NamespaceSeparator contains the character that separates namescapes
// NamespaceSeparator contains the character that separates namespaces
const NamespaceSeparator = ":"
// Merge merges the second Taskfile into the first
@ -21,11 +21,6 @@ func Merge(t1, t2 *Taskfile, includedTaskfile *IncludedTaskfile, namespaces ...s
t1.Output = t2.Output
}
if t1.Includes == nil {
t1.Includes = &IncludedTaskfiles{}
}
t1.Includes.Merge(t2.Includes)
if t1.Vars == nil {
t1.Vars = &Vars{}
}