mirror of
https://github.com/go-task/task.git
synced 2025-02-09 13:47:06 +02:00
feat: add a deprecation warning when running Taskfiles with a v2 schema (#1199)
This commit is contained in:
parent
75659485ee
commit
7a2f8d691c
@ -6,6 +6,8 @@
|
||||
#1194 by @deviantintegral).
|
||||
- Added [experiments documentation](https://taskfile.dev/experiments) to the
|
||||
website (#1198 by @pd93).
|
||||
- Deprecated `version: 2` schema. This will be removed in the next major release
|
||||
(#1197, #1198, #1199 by @pd93).
|
||||
|
||||
## v3.25.0 - 2023-05-22
|
||||
|
||||
|
6
setup.go
6
setup.go
@ -250,7 +250,11 @@ func (e *Executor) doVersionChecks() error {
|
||||
*v = *e.Taskfile.Version
|
||||
|
||||
if v.LessThan(taskfile.V2) {
|
||||
return fmt.Errorf(`task: Taskfile versions prior to v2 are not supported anymore`)
|
||||
return fmt.Errorf(`task: version 1 schemas are no longer supported`)
|
||||
}
|
||||
|
||||
if v.LessThan(taskfile.V3) {
|
||||
e.Logger.Errf(logger.Yellow, "task: version 2 schemas are deprecated and will be removed in a future release\nSee https://github.com/go-task/task/issues/1197 for more details\n")
|
||||
}
|
||||
|
||||
// consider as equal to the greater version if round
|
||||
|
16
task_test.go
16
task_test.go
@ -1371,7 +1371,7 @@ func TestDynamicVariablesShouldRunOnTheTaskDir(t *testing.T) {
|
||||
tt.Run(t)
|
||||
}
|
||||
|
||||
func TestDisplaysErrorOnUnsupportedVersion(t *testing.T) {
|
||||
func TestDisplaysErrorOnVersion1Schema(t *testing.T) {
|
||||
e := task.Executor{
|
||||
Dir: "testdata/version/v1",
|
||||
Stdout: io.Discard,
|
||||
@ -1379,7 +1379,19 @@ func TestDisplaysErrorOnUnsupportedVersion(t *testing.T) {
|
||||
}
|
||||
err := e.Setup()
|
||||
require.Error(t, err)
|
||||
assert.Equal(t, "task: Taskfile versions prior to v2 are not supported anymore", err.Error())
|
||||
assert.Equal(t, "task: version 1 schemas are no longer supported", err.Error())
|
||||
}
|
||||
|
||||
func TestDisplaysWarningOnVersion2Schema(t *testing.T) {
|
||||
var buff bytes.Buffer
|
||||
e := task.Executor{
|
||||
Dir: "testdata/version/v2",
|
||||
Stdout: io.Discard,
|
||||
Stderr: &buff,
|
||||
}
|
||||
err := e.Setup()
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, "task: version 2 schemas are deprecated and will be removed in a future release\nSee https://github.com/go-task/task/issues/1197 for more details\n", buff.String())
|
||||
}
|
||||
|
||||
func TestShortTaskNotation(t *testing.T) {
|
||||
|
Loading…
x
Reference in New Issue
Block a user