mirror of
https://github.com/go-task/task.git
synced 2025-12-26 00:31:38 +02:00
618538f4a8
When no ref is specified in a remote Taskfile URL, go-getter was being passed ref=HEAD which git interprets as a literal branch name, causing "Remote branch HEAD not found" errors. Now we omit the ref parameter entirely when not specified, letting git clone the remote's default branch.
248 lines
8.1 KiB
Go
248 lines
8.1 KiB
Go
package taskfile
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGitNode_ssh(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
node, err := NewGitNode("git@github.com:foo/bar.git//Taskfile.yml?ref=main", "", false)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "main", node.ref)
|
|
assert.Equal(t, "Taskfile.yml", node.path)
|
|
assert.Equal(t, "ssh://git@github.com/foo/bar.git//Taskfile.yml?ref=main", node.Location())
|
|
assert.Equal(t, "ssh://git@github.com/foo/bar.git", node.url.String())
|
|
entrypoint, err := node.ResolveEntrypoint("common.yml")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "ssh://git@github.com/foo/bar.git//common.yml?ref=main", entrypoint)
|
|
}
|
|
|
|
func TestGitNode_sshWithAltRepo(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
node, err := NewGitNode("git@github.com:foo/bar.git//Taskfile.yml?ref=main", "", false)
|
|
assert.NoError(t, err)
|
|
|
|
entrypoint, err := node.ResolveEntrypoint("git@github.com:foo/other.git//Taskfile.yml?ref=dev")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "git@github.com:foo/other.git//Taskfile.yml?ref=dev", entrypoint)
|
|
}
|
|
|
|
func TestGitNode_sshWithDir(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
node, err := NewGitNode("git@github.com:foo/bar.git//directory/Taskfile.yml?ref=main", "", false)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "main", node.ref)
|
|
assert.Equal(t, "directory/Taskfile.yml", node.path)
|
|
assert.Equal(t, "ssh://git@github.com/foo/bar.git//directory/Taskfile.yml?ref=main", node.Location())
|
|
assert.Equal(t, "ssh://git@github.com/foo/bar.git", node.url.String())
|
|
entrypoint, err := node.ResolveEntrypoint("common.yml")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "ssh://git@github.com/foo/bar.git//directory/common.yml?ref=main", entrypoint)
|
|
}
|
|
|
|
func TestGitNode_https(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
node, err := NewGitNode("https://github.com/foo/bar.git//Taskfile.yml?ref=main", "", false)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "main", node.ref)
|
|
assert.Equal(t, "Taskfile.yml", node.path)
|
|
assert.Equal(t, "https://github.com/foo/bar.git//Taskfile.yml?ref=main", node.Location())
|
|
assert.Equal(t, "https://github.com/foo/bar.git", node.url.String())
|
|
entrypoint, err := node.ResolveEntrypoint("common.yml")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "https://github.com/foo/bar.git//common.yml?ref=main", entrypoint)
|
|
}
|
|
|
|
func TestGitNode_httpsWithDir(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
node, err := NewGitNode("https://github.com/foo/bar.git//directory/Taskfile.yml?ref=main", "", false)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "main", node.ref)
|
|
assert.Equal(t, "directory/Taskfile.yml", node.path)
|
|
assert.Equal(t, "https://github.com/foo/bar.git//directory/Taskfile.yml?ref=main", node.Location())
|
|
assert.Equal(t, "https://github.com/foo/bar.git", node.url.String())
|
|
entrypoint, err := node.ResolveEntrypoint("common.yml")
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "https://github.com/foo/bar.git//directory/common.yml?ref=main", entrypoint)
|
|
}
|
|
|
|
func TestGitNode_CacheKey(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
entrypoint string
|
|
expectedKey string
|
|
}{
|
|
{
|
|
entrypoint: "https://github.com/foo/bar.git//directory/Taskfile.yml?ref=main",
|
|
expectedKey: "git.github.com.directory.Taskfile.yml.f1ddddac425a538870230a3e38fc0cded4ec5da250797b6cab62c82477718fbb",
|
|
},
|
|
{
|
|
entrypoint: "https://github.com/foo/bar.git//Taskfile.yml?ref=main",
|
|
expectedKey: "git.github.com.Taskfile.yml.39d28c1ff36f973705ae188b991258bbabaffd6d60bcdde9693d157d00d5e3a4",
|
|
},
|
|
{
|
|
entrypoint: "https://github.com/foo/bar.git//multiple/directory/Taskfile.yml?ref=main",
|
|
expectedKey: "git.github.com.directory.Taskfile.yml.1b6d145e01406dcc6c0aa572e5a5d1333be1ccf2cae96d18296d725d86197d31",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
node, err := NewGitNode(tt.entrypoint, "", false)
|
|
require.NoError(t, err)
|
|
key := node.CacheKey()
|
|
assert.Equal(t, tt.expectedKey, key)
|
|
}
|
|
}
|
|
|
|
func TestGitNode_buildURL(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
entrypoint string
|
|
expectedURL string
|
|
}{
|
|
{
|
|
name: "HTTPS with ref",
|
|
entrypoint: "https://github.com/foo/bar.git//Taskfile.yml?ref=main",
|
|
expectedURL: "git::https://github.com/foo/bar.git?ref=main&depth=1",
|
|
},
|
|
{
|
|
name: "SSH with ref",
|
|
entrypoint: "git@github.com:foo/bar.git//Taskfile.yml?ref=main",
|
|
expectedURL: "git::ssh://git@github.com/foo/bar.git?ref=main&depth=1",
|
|
},
|
|
{
|
|
name: "HTTPS with tag ref",
|
|
entrypoint: "https://github.com/foo/bar.git//Taskfile.yml?ref=v1.0.0",
|
|
expectedURL: "git::https://github.com/foo/bar.git?ref=v1.0.0&depth=1",
|
|
},
|
|
{
|
|
name: "HTTPS without ref (uses remote default branch)",
|
|
entrypoint: "https://github.com/foo/bar.git//Taskfile.yml",
|
|
expectedURL: "git::https://github.com/foo/bar.git?depth=1",
|
|
},
|
|
{
|
|
name: "SSH with directory path",
|
|
entrypoint: "git@github.com:foo/bar.git//directory/Taskfile.yml?ref=dev",
|
|
expectedURL: "git::ssh://git@github.com/foo/bar.git?ref=dev&depth=1",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
node, err := NewGitNode(tt.entrypoint, "", false)
|
|
require.NoError(t, err)
|
|
gotURL := node.buildURL()
|
|
assert.Equal(t, tt.expectedURL, gotURL)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRepoCacheKey_SameRepoSameRef(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Same repo, same ref, different files should have SAME cache key
|
|
node1, err := NewGitNode("https://github.com/foo/bar.git//file1.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
node2, err := NewGitNode("https://github.com/foo/bar.git//dir/file2.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
key1 := node1.repoCacheKey()
|
|
key2 := node2.repoCacheKey()
|
|
|
|
assert.Equal(t, key1, key2, "Same repo+ref should generate same cache key regardless of file path")
|
|
}
|
|
|
|
func TestRepoCacheKey_SameRepoDifferentRef(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Same repo, different ref should have DIFFERENT cache keys
|
|
node1, err := NewGitNode("https://github.com/foo/bar.git//file.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
node2, err := NewGitNode("https://github.com/foo/bar.git//file.yml?ref=dev", "", false)
|
|
require.NoError(t, err)
|
|
|
|
key1 := node1.repoCacheKey()
|
|
key2 := node2.repoCacheKey()
|
|
|
|
assert.NotEqual(t, key1, key2, "Different refs should generate different cache keys")
|
|
}
|
|
|
|
func TestRepoCacheKey_DifferentRepos(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Different repos should have DIFFERENT cache keys
|
|
node1, err := NewGitNode("https://github.com/foo/bar.git//file.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
node2, err := NewGitNode("https://github.com/foo/other.git//file.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
key1 := node1.repoCacheKey()
|
|
key2 := node2.repoCacheKey()
|
|
|
|
assert.NotEqual(t, key1, key2, "Different repos should generate different cache keys")
|
|
}
|
|
|
|
func TestRepoCacheKey_NoRefVsExplicitRef(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// No ref (uses default branch) vs explicit ref should have DIFFERENT cache keys
|
|
node1, err := NewGitNode("https://github.com/foo/bar.git//file.yml", "", false)
|
|
require.NoError(t, err)
|
|
|
|
node2, err := NewGitNode("https://github.com/foo/bar.git//file.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
key1 := node1.repoCacheKey()
|
|
key2 := node2.repoCacheKey()
|
|
|
|
assert.NotEqual(t, key1, key2, "No ref and explicit ref should generate different cache keys")
|
|
}
|
|
|
|
func TestRepoCacheKey_SSHvsHTTPS(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// SSH vs HTTPS pointing to same repo should have SAME cache key
|
|
// They clone the same repo, so we want to share the cache
|
|
node1, err := NewGitNode("git@github.com:foo/bar.git//file.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
node2, err := NewGitNode("https://github.com/foo/bar.git//file.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
key1 := node1.repoCacheKey()
|
|
key2 := node2.repoCacheKey()
|
|
|
|
assert.Equal(t, key1, key2, "SSH and HTTPS for same repo should share cache")
|
|
}
|
|
|
|
func TestRepoCacheKey_Consistency(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Calling repoCacheKey multiple times on same node should return same key
|
|
node, err := NewGitNode("https://github.com/foo/bar.git//file.yml?ref=main", "", false)
|
|
require.NoError(t, err)
|
|
|
|
key1 := node.repoCacheKey()
|
|
key2 := node.repoCacheKey()
|
|
key3 := node.repoCacheKey()
|
|
|
|
assert.Equal(t, key1, key2)
|
|
assert.Equal(t, key2, key3)
|
|
}
|