jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2026-06-19 22:58:55 +02:00
Code Issues Releases Activity

Merge pull request #224 from marcusholl/pr/transportRequestReleaseDecoupleTests

Browse Source 
Release transport request: decouple tests
This commit is contained in:
Marcus Holl
2018-08-14 12:29:59 +02:00
committed by GitHub
parent 8ee36e3c36 bfb131407d
commit 5e805e4a42
2 changed files with 72 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/groovy/TransportRequestReleaseTest.groovy
+39 -8
View File
@@ -83,22 +83,53 @@ public class TransportRequestReleaseTest extends BasePiperTest {
@Test
public void releaseTransportRequestFailureTest() {
helper.registerAllowedMethod('sh', [Map], { Map m -> return 1 })
thrown.expect(AbortException)
thrown.expectMessage("Cannot release Transport Request '001'. Return code from cmclient: 1.")
thrown.expectMessage("Something went wrong")
jsr.step.call(script: nullScript, changeDocumentId: '001', transportRequestId: '001')
ChangeManagement cm = new ChangeManagement(nullScript) {
void releaseTransportRequest(String changeId,
String transportRequestId,
String endpoint,
String credentialsId,
String clientOpts) {
throw new ChangeManagementException('Something went wrong')
}
}
jsr.step.call(script: nullScript, changeDocumentId: '001', transportRequestId: '001', cmUtils: cm)
}
@Test
public void releaseTransportRequestSuccessTest() {
helper.registerAllowedMethod('sh', [Map], { Map m -> return 0 })
jlr.expect("[INFO] Closing transport request '002' for change document '001'.")
jlr.expect("[INFO] Transport Request '002' has been successfully closed.")
jsr.step.call(script: nullScript, changeDocumentId: '001', transportRequestId: '001')
Map receivedParams = [:]
assert jlr.log.contains("[INFO] Closing transport request '001' for change document '001'.")
assert jlr.log.contains("[INFO] Transport Request '001' has been successfully closed.")
ChangeManagement cm = new ChangeManagement(nullScript) {
void releaseTransportRequest(String changeId,
String transportRequestId,
String endpoint,
String credentialsId,
String clientOpts) {
receivedParams.changeId = changeId
receivedParams.transportRequestId = transportRequestId
receivedParams.endpoint = endpoint
receivedParams.credentialsId = credentialsId
receivedParams.clientOpts = clientOpts
}
}
jsr.step.call(script: nullScript, changeDocumentId: '001', transportRequestId: '002', cmUtils: cm)
assert receivedParams == [changeId: '001',
transportRequestId: '002',
endpoint: 'https://example.org/cm',
credentialsId: 'CM',
clientOpts: '']
}
}
test/groovy/com/sap/piper/cm/ChangeManagementTest.groovy
+33
View File
@@ -216,6 +216,39 @@ public void testGetCommandLineWithCMClientOpts() {
'me')
}
@Test
public void testReleaseTransportRequestSucceeds() {
// the regex provided below is an implicit check that the command line is fine.
script.setReturnValue(JenkinsShellCallRule.Type.REGEX, 'release-transport.*-cID 001.*-tID 002', 0)
new ChangeManagement(nullScript).releaseTransportRequest('001',
'002',
'https://example.org',
'me',
'openSesame')
// no assert required here, since the regex registered above to the script rule is an implicit check for
// the command line.
}
@Test
public void testReleaseTransportRequestFails() {
thrown.expect(ChangeManagementException)
thrown.expectMessage("Cannot release Transport Request '002'. Return code from cmclient: 1.")
// the regex provided below is an implicit check that the command line is fine.
script.setReturnValue(JenkinsShellCallRule.Type.REGEX, 'release-transport.*-cID 001.*-tID 002', 1)
new ChangeManagement(nullScript).releaseTransportRequest('001',
'002',
'https://example.org',
'me',
'openSesame')
}
private GitUtils gitUtilsMock(boolean insideWorkTree, String[] changeIds) {
return new GitUtils() {
public boolean insideWorkTree() {